-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New design of VaButton implementation #1923
Comments
@RVitaly1978 @asvae @Derranion @rustem-nasyrov take a look, please. |
@xx13 can you explain why we're getting rid of outline buttons? |
3 - I don't see a point. If outline buttons are solution we don't want our users to employ - why give them tools? I suggest supporting outline preset or removing altogether. Other points look reasonable. 👯 |
@asvae we are switching from styles to its functions. one can customize |
Let's discuss that in grooming :) |
Closed via #1945 |
New buttons (figma) have some new states, that will affect the list of component's props.
pressed
state. I can't see it anywhere at all. May be we should create new composableusePressed
.outline
prop and state (no design for it, watch next option).borderColor
prop (undefined as default). In purpose to create old-like outline buttons based onsecondary
state of the new design (suggestion by Vasily).flat
prop toplain
.type
prop. It's seems to be double of thetag
prop. ~~5.1. NEW: visual presets (
primary, secondary, plain, plain-opacity
) will be located inGlobal Config
and connected with components via Feat #1806: Presets for all components & components config structure change #19215.2. NEW: opacity variables (e.g.:
opacity-hover, hover-opacity
etc.) will be located inColor Config
.Add theborderRadius
prop (undefined
as default). To allow users to change default border radius (suggestion by Vasily).round
will serve as a helper forborder-radius: 50%
.rounded
prop (all new variants are square).Change defaultcolor
prop value toundefined
(by default appearance will depend on newtype
/style
prop).iconColor
prop if we want different colors for text & icon (suggestion by Vasily).The text was updated successfully, but these errors were encountered: