-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat #1806: Presets for all components & components config structure change #1921
Merged
Derranion
merged 3 commits into
epicmaxco:release/1.5.0
from
Derranion:feat/component-presets
Jun 21, 2022
Merged
Feat #1806: Presets for all components & components config structure change #1921
Derranion
merged 3 commits into
epicmaxco:release/1.5.0
from
Derranion:feat/component-presets
Jun 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Derranion
requested review from
asvae,
m0ksem,
rustem-nasyrov,
RVitaly1978 and
aluarius
June 7, 2022 15:30
m0ksem
approved these changes
Jun 7, 2022
asvae
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome. Thanks!
I believe this would be a huge asset for internal (picker, tables) and external component usage.
aluarius
approved these changes
Jun 8, 2022
RVitaly1978
reviewed
Jun 9, 2022
This was referenced Jun 9, 2022
This was referenced Jun 16, 2022
Open
rustem-nasyrov
approved these changes
Jun 16, 2022
minor minor tweaks minor style Minor demo
Derranion
force-pushed
the
feat/component-presets
branch
from
June 21, 2022 16:16
8a7057a
to
a2be91e
Compare
Derranion
changed the title
Feat #1806: Presets for all components
Feat #1806: Presets for all components & components config structure change
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Presets
has been added to all usable components.Closes #1806
Closes #1967
We can use
preset
prop
everywhere to have as manyprops
as we want, at once, in a single word.Also it is possible to set this inside the
Va-config
(local config
) andGlobal config
(components
\componentsAll
).Usage example is under the spoiler.
Demo:
Documentation is in the other pull request.
Types of changes