[#1923] New buttons design implementation #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aluarius
requested review from
asvae,
Derranion,
m0ksem,
rustem-nasyrov and
RVitaly1978
aluarius
changed the title
m0ksem
requested changes
Jun 14, 2022
RVitaly1978
requested changes
Jun 15, 2022
# Conflicts: # packages/ui/src/components/va-button/VaButton.vue
Derranion
reviewed
Jun 15, 2022
There was a problem hiding this comment.
If I get this point correctly:
- Integrate presets functionality after Feat #1806: Presets for all components
We will just have predefined list of Presets for the VaButton.
If you want you could just send me these presets object I'll add it in my current PR.
m0ksem
added
feature
aluarius
requested review from
RVitaly1978,
Derranion,
rustem-nasyrov and
m0ksem
# Conflicts: # packages/ui/src/components/va-button-dropdown/VaButtonDropdown.vue # packages/ui/src/components/va-button-group/VaButtonGroup.vue # packages/ui/src/components/va-button-toggle/VaButtonToggle.vue # packages/ui/src/components/va-button/VaButton.vue
…new-buttons-implementation # Conflicts: # packages/ui/src/components/va-button-dropdown/VaButtonDropdown.vue # packages/ui/src/components/va-button-group/VaButtonGroup.vue # packages/ui/src/components/va-button-toggle/VaButtonToggle.vue # packages/ui/src/components/va-button/VaButton.vue # packages/ui/src/composables/useHover.ts
…new-buttons-implementation
rustem-nasyrov
approved these changes
Jul 15, 2022
# Conflicts: # packages/docs/src/components/DocsExample.vue # packages/docs/src/components/DocsNavigation.vue # packages/docs/src/components/header/Header.vue # packages/docs/src/locales/ru/ru.json # packages/ui/src/components/va-button/VaButton.vue # packages/ui/src/composables/index.ts
m0ksem
changed the title
m0ksem
approved these changes
Aug 3, 2022
packages/ui/src/components/va-button-dropdown/VaButtonDropdown.vue
Outdated
Show resolved
Hide resolved
|
We need to split composables into utils like useHover, usePressed, useHTMLElement, useClientOnly etc. and mixins like useHoverable, useFormElement, usePressable, useSelectable, useParsable. Maaaaaaah, I think this must be written somewhere before implementation... Naming is quite important here.. |
…new-buttons-implementation # Conflicts: # packages/docs/src/locales/en/en.json # packages/docs/src/locales/ru/ru.json # packages/docs/src/page-configs/ui-elements/app-bar/examples/Bottom.vue # packages/docs/src/page-configs/ui-elements/app-bar/page-config.ts # packages/docs/src/page-configs/ui-elements/button-dropdown/examples/Colors.vue # packages/ui/src/components/va-button-dropdown/VaButtonDropdown.vue # packages/ui/src/composables/index.ts
This was referenced Aug 11, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #1923
Close: #809
Description
Work in progress.
VaButtoncomponent was fully rewritten according to the new design.VaButton.largestate after design is ready.Please, take a look to the new implementation and, if possible, compare it with figma.
Types of changes