Skip to content

Commit

Permalink
add text to direct readers to addressing package reviews section, closes
Browse files Browse the repository at this point in the history
  • Loading branch information
joshwlambert committed Feb 26, 2024
1 parent 9939a57 commit 012e5d7
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions code-review.qmd
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ The pull request can now be made from the `review` branch to the `v_020` branch

This process is similar to the [release comparison feature provided by GitHub](https://docs.github.com/en/repositories/releasing-projects-on-github/comparing-releases), but that feature does not allow commenting and suggesting like the pull request interface.

Now that the partial review pull request is set up, see the [Addressing package reviews section](https://epiverse-trace.github.io/blueprints/code-review.html#addressing-package-reviews) for ways to incorporate changes from reviewer's comments and complete the code review.

### Full package review

::: {.callout-tip title="Read more about this principle in application"}
Expand Down Expand Up @@ -75,6 +77,8 @@ git push origin review

Now the full package review pull request can be made on GitHub, targeting `empty` from `review`.

Once reviewer comments and suggestions are received, methods for incorporating changes and completing the full package review are outlined in the [next section: Addressing package reviews section](https://epiverse-trace.github.io/blueprints/code-review.html#addressing-package-reviews).

### Addressing package reviews

We have used two strategies for integrating suggestions in package reviews.
Expand Down

0 comments on commit 012e5d7

Please sign in to comment.