Describe epidemics design decisions #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwlambert
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Fantastic work @pratikunterwegs. Exactly what is required for a complex package to explain style and substance. I've left a few minor comments, but all good to get this merged when you're ready.
vignettes/design-principles.Rmd
Outdated
|
|
||
| **Fig. 1:** _epidemics_ is designed to allow easy combination of composable elements with a model structure taken from a library of published models, with sensible default parameters, to allow public health practitioners to conveniently model epidemic scenarios and the efficacy of response strategies. | ||
|
|
||
| <img src="../man/figures/epidemics_architecture.png" width="700" /> |
There was a problem hiding this comment.
Will depend on screen size, but the text in this figure is relatively hard to read for me. Could make the whole figure a bit larger or edit the figure to increase font size.
There was a problem hiding this comment.
Agreed. I've increased the size a bit, but it doesn't seem to be helping. I'll leave this as it is for now, and perhaps consider splitting it up in a future version.
Co-authored-by: Joshua Lambert <joshua.lambert@lshtm.ac.uk>
Co-authored-by: Joshua Lambert <joshua.lambert@lshtm.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a design vignette that aims to fix #69. This vignette refers to changes incoming in #176.