Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pkg setup #24

Merged
merged 20 commits into from
Sep 27, 2022
Merged

Feature/pkg setup #24

merged 20 commits into from
Sep 27, 2022

Conversation

joshwlambert
Copy link
Member

Updates:

Please let me know if there is anything missing from the package in terms of basic setup.

Joshua Lambert and others added 16 commits September 22, 2022 14:05
updates to Rbuildignore, gitignore and Rproj
b2a5dc5
@joshwlambert
added MIT license and added dependency to R 3.5.0 due to check warning
b429f64
@joshwlambert
added testing structure (fixes #10) and added initial testing for eac…
e583bfa 
…h function (fixes #13)
@joshwlambert
added Github actions workflow, fixes #11
558a002
@joshwlambert
added code coverage, fixes #12
92c63a8
@joshwlambert
added automated lint checking through GHA, fixes #14
a123d11
@joshwlambert
fixed bug in fit_function_gamma_range, fixes #16
d050b5f
@joshwlambert
fixed bug in fit_function_weibull_range, fixes #17
02a4384
@joshwlambert
added stats namespace, fixes #20
5d0a219
@joshwlambert
updated DESCRIPTION and added working function examples to documentat…
6e73b36 
…ion, WIP #19
@joshwlambert
moved data from R/sysdata.rda to inst/extdata/parameters.csv, deleted…
12bec37 
… data folder and updated functions and tests to read data, fixes #5
@joshwlambert
added utils namespace to read.csv, fixes #21
ff7306c
@joshwlambert
remove note for global variables from using dplyr's non-standard eval…
4b2643b 
…uation
@joshwlambert
added and fixed documentation for fitting functions, WIP #19
fc71bc1
@joshwlambert
linting package, fixes #23
f5f73dc
@joshwlambert
updated documentation
9ddc8ec
@joshwlambert joshwlambert marked this pull request as ready for review September 26, 2022 10:44
thibautjombart
thibautjombart approved these changes Sep 26, 2022
View reviewed changes
Copy link

@thibautjombart thibautjombart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work! I loved that the code was really easy to read and follow. I have not checked the math bits.

I will accept the PR but raised 2 separate issues which are not urgent and are probably best addressed later:

DESCRIPTION Outdated Show resolved Hide resolved
R/epidist.R Show resolved Hide resolved
R/epidist.R Outdated Show resolved Hide resolved
R/extract_param.R Show resolved Hide resolved
R/extract_param.R Show resolved Hide resolved
R/epidist.R Show resolved Hide resolved
R/list_distributions.R Outdated Show resolved Hide resolved
R/list_distributions.R Outdated Show resolved Hide resolved
tests/testthat/test-list_distributions.R Show resolved Hide resolved
@joshwlambert joshwlambert merged commit e4930ba into main Sep 27, 2022
@joshwlambert joshwlambert deleted the feature/pkg_setup branch September 27, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibautjombart thibautjombart thibautjombart approved these changes

@adamkucharski adamkucharski Awaiting requested review from adamkucharski

Assignees
No one assigned
Labels
None yet
Projects
No open projects
epiparameter setup
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshwlambert @thibautjombart