Feature/improve doc #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwlambert
requested review from
adamkucharski,
thibautjombart and
pratikunterwegs
Codecov Report
@@ Coverage Diff @@
## main #33 +/- ##
=======================================
Coverage 94.63% 94.63%
=======================================
Files 3 3
Lines 205 205
=======================================
Hits 194 194
Misses 11 11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pratikunterwegs
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Looks good to me, thanks for adding all of this @joshwlambert, nice work, I'll use this as a reference! I've left only two minor comments, one of those is about lintr warnings in R/epidist.R.
…anged argument from type to delay_dist and updated tests
|
Took a look at the new changes, look fine to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General improvements to documentation:
This pull request does not make any changes to the source code of
epiparameter.