Refactor epireview_to_epidist() to fix issues with as_epidist()
#334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ollapse = ...) in epireview_to_epidist
This was referenced Jun 14, 2024
…n epireview_to_epidist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites large parts of the
epireview_to_epidist()function to make it more robust to the various parameter entries from the {epireview} R package.The issues that led to this refactor are: #303, #306 and #327. Each of these should be resolved by the changes made in this PR and a unit test has been added to the package to cover each of these cases. I will post a reproducible example demonstrating the fix in each respective issue.
as_epidist()function documentation is also updated.