Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify probability distribution in as_epidist() #335

Merged
merged 9 commits into from
Jun 24, 2024

Conversation

joshwlambert
Copy link
Member

This PR addresses #310 by extending as_epidist() to accept a prob_dist argument. This is then read by epireview_to_epidist() and can be used to parameterise a distribution if parameters or summary statistics are available but a probability distribution is not specified.

A section has been added to the data_from_epireview.Rmd vignette to outline how this feature works and to warn users against using this feature improperly.

Unit tests have been added to check prob_dist passed via ... in as_epidist() works as expected and Faye et al. (2015) has been added to references.JSON as it is cited in data_from_epireview.Rmd.

@joshwlambert joshwlambert added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 17, 2024
Copy link
Member

@adamkucharski adamkucharski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is looking very nice! Just added a small comment about vignette clarity

vignettes/articles/data_from_epireview.Rmd Show resolved Hide resolved
@joshwlambert joshwlambert merged commit 325562f into main Jun 24, 2024
10 checks passed
@joshwlambert joshwlambert deleted the attach_prob_dist_in_as_epidist branch June 24, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants