Do not propose automated blog post for patch releases #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tourmaline-marshmallow-241b40 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chartgerink
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
That seems like a valid change. The amount of PRs that we did not want to merge was more than expected - so this is a warranted change.
Tracking the update in the blueprints over at epiverse-trace/blueprints#98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some assumptions on git tag formatting but it seems reasonable to me. In particular, usethis, our recommend tool to create GitHub release, will generate tags with the following format
v1.0.0.This clashes with epiverse-trace/blueprints#70 but matches @joshwlambert's request in #135:
I believe critical fixes should not be released as patches and this will spare us some notification spam.
What do you think?