Only inspect a subset of par() in helper-state #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwlambert
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Thanks @Bisaloo, this looks like a nice fix. Is there any documentation that you could link to in helper-state.R that states that "cxy", "usr", "xaxp" are the only graphics parameters altered by plot()?
|
This is the best I have at the moment. It does resolve the issues for epiparameter. I propose we add more parameters in the future if we ever notice they cause issues. Does this sound reasonable? |
Yep, good with me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #163.