Fix simulation bug for vector allocation #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwlambert
force-pushed
the
fix_alloc_error
branch
from
72b9da3
to
07f57a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #89 by fixing a bug in
.sim_network_bp()whereby if the outbreak saturated but did not exceed the pre-allocated vectors in.sim_network_bp()then the calculation of the vector index (vec_idx) would be incorrect leading to a bug which failed in areplacement length zeroerror. This should be resolved in this PR by expanding the allocated vectors when the length of the vector is equalled as well as exceeded.