-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add episodes on estimate superspreading and simulate chains (trial 04) #29
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/epiverse-trace/tutorials-middle/compare/md-outputs..md-outputs-PR-29 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-05-01 00:05:34 +0000 |
cfc27fe
to
cfc195e
Compare
cfc195e
to
0307b4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting together, some nice examples here. Have added review to content in superspreading-estimate.Rmd
and will revisit superspreading-simulate.Rmd
when more added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work putting this together – lots of great content for learners. Have added few comments on the superspreading-simulate
episode, mostly around consistency and clarity
@adamkucharski major comments collected. I'll leave the others for next week. Regarding the extreme k = 0.02. We can try to look for studies that estimated and published this from the MERS data. This k value is the one estimated in the superspreading-estimate episode. Should we add some additional context as papers on MERS with complementary estimates in a callout? |
@joshwlambert @jamesmbaazam could we have your review during the coming week? We expect to merge this on Thursday 25th April. |
Co-authored-by: Adam Kucharski <adam.kucharski@lshtm.ac.uk>
Co-authored-by: Adam Kucharski <adam.kucharski@lshtm.ac.uk>
Co-authored-by: Adam Kucharski <adam.kucharski@lshtm.ac.uk>
Co-authored-by: Adam Kucharski <adam.kucharski@lshtm.ac.uk>
Co-authored-by: Abdoelnaser M Degoot <degoot@aims.ac.za> Co-authored-by: James Azam <james.m.azam@gmail.com>
Co-authored-by: James Azam <james.m.azam@gmail.com>
1710286
to
dcfa576
Compare
Thanks for your reviews! I moved the larger ones to issues for further inspection and evaluation:
I plan to merge this after the checks pass. Then I'll open a |
Fix #20
PR is now ready to review
I'll appreciate your specific feedback providing a clear next step to remove, change or add content.
how to review?
follow the steps in the reviewer role section of the contributing.md file
Before running
sandpaper::build_lesson()
, in theconfig.yaml
file deactivate these episodes:if local rendering doesn't work, please, report them in Issues.
preliminary deployment to review:
md-outputs-PR-29