Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestLeaseGrantErrConnClosed fails #8329

Closed
gyuho opened this issue Jul 28, 2017 · 0 comments
Closed

TestLeaseGrantErrConnClosed fails #8329

gyuho opened this issue Jul 28, 2017 · 0 comments
Assignees
@gyuho
Labels
area/testing

Comments

@gyuho
Copy link
Contributor

gyuho commented Jul 28, 2017 •
edited
Loading 

--- FAIL: TestLeaseGrantErrConnClosed (0.08s)
	lease_test.go:290: expected grpc: the client connection is closing, got context canceled

With recent gRPC upgrade to v1.5.1 #8296, client Close (which cancels the client.context) gives context canceled
gyuho added a commit to gyuho/etcd that referenced this issue Aug 1, 2017
@gyuho
clientv3/integration: match context canceled on client close
b89ef7e 
Fix etcd-io#8329.

Different behavior from grpc/grpc-go#1369,
in grpc-go transportMonitor.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
@gyuho gyuho mentioned this issue Aug 1, 2017
Merged
visheshnp pushed a commit to visheshnp/etcd that referenced this issue Aug 3, 2017
@gyuho @visheshnp
clientv3/integration: match context canceled on client close
ffc1997 
Fix etcd-io#8329.

Different behavior from grpc/grpc-go#1369,
in grpc-go transportMonitor.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gyuho gyuho

Labels
area/testing
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gyuho