Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientv3/integration: match context canceled on client close #8349

Merged
merged 1 commit into from
Aug 1, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Aug 1, 2017

Fix #8329.

Different behavior from grpc/grpc-go#1369,
in grpc-go transportMonitor.

Fix etcd-io#8329.

Different behavior from grpc/grpc-go#1369,
in grpc-go transportMonitor.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Copy link
Contributor

@heyitsanthony heyitsanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gyuho gyuho merged commit 45e6b65 into etcd-io:master Aug 1, 2017
@gyuho gyuho deleted the fix-lease-test branch August 1, 2017 21:53
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@585b1d7). Click here to learn what that means.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8349   +/-   ##
=========================================
  Coverage          ?   76.54%           
=========================================
  Files             ?      349           
  Lines             ?    27361           
  Branches          ?        0           
=========================================
  Hits              ?    20943           
  Misses            ?     4922           
  Partials          ?     1496
Impacted Files Coverage Δ
clientv3/client.go 82.91% <ø> (ø)
clientv3/retry.go 59.42% <96.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 585b1d7...b89ef7e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants