Do not create new addrConn when connection error happens #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
force-pushed
the
addrConn_redo_for_balancer
branch
2 times, most recently
from
24a95a7
to
9a81212
Compare
menghanl
force-pushed
the
addrConn_redo_for_balancer
branch
from
6961ab6
to
df9862c
Compare
dfawley
reviewed
Jul 18, 2017
clientconn.go
Outdated
| select { | ||
| case <-t.Error(): | ||
| ac.cc.resetAddrConn(ac.addr, false, errNetworkIO) | ||
| if err := ac.resetTransport(false); err != nil { |
There was a problem hiding this comment.
Refactor?
var drain bool
select {
case <-t.Error():
default:
drain = true
}
if err := ac.resetTransport(drain); err != nil {
...
dfawley
approved these changes
Jul 19, 2017
clientconn.go
Outdated
| // 2) goaway was received, a new ac will replace the old ac. | ||
| // The old ac should be deleted from cc.conns, but the | ||
| // underlying transport should drain rather than close. | ||
| // a buggy Balancer notifies duplicated Addresses; |
There was a problem hiding this comment.
"a buggy Balancer that reports duplicate Addresses."
clientconn.go
Outdated
| @@ -949,28 +949,22 @@ func (ac *addrConn) transportMonitor() { | |||
| ac.adjustParams(t.GetGoAwayReason()) | |||
| // If GoAway happens without any network I/O error, the underlying transport | |||
| // will be gracefully closed, and a new transport will be created. | |||
| // (the transport will be closed when all the pending RPCs finished or failed.). | |||
| // (the transport will be closed when all the pending RPCs finished or failed.) | |||
There was a problem hiding this comment.
Capital "T" at the start of the sentence.
menghanl
force-pushed
the
addrConn_redo_for_balancer
branch
from
7f43dea
to
f305355
Compare
menghanl
force-pushed
the
addrConn_redo_for_balancer
branch
from
f305355
to
b67bdb1
Compare
dfawley
approved these changes
Jul 20, 2017
menghanl
added a commit
that referenced
this pull request
Jul 27, 2017
gyuho
added a commit
to gyuho/etcd
that referenced
this pull request
Aug 1, 2017
Fix etcd-io#8329. Different behavior from grpc/grpc-go#1369, in grpc-go transportMonitor. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
visheshnp
pushed a commit
to visheshnp/etcd
that referenced
this pull request
Aug 3, 2017
Fix etcd-io#8329. Different behavior from grpc/grpc-go#1369, in grpc-go transportMonitor. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just reset the underlying transport instead.