-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSGi: ClassNotFoundException: javax.security.cert.X509Certificate cannot be found by io.etcd.jetcd-all_0.3.0.SNAPSHOT #382
Comments
solved a number of issues; starting to look more interesting now we're blocked by etcd-io/jetcd#382
long time I did't test it |
@lburgazzoli so yeah it's actually totally broken - I was just able to reproduce this, by making the ClientServiceTest actually "do something" ... currently it only I'll see if I can fix this - and try to include a non-regression test in |
TODO With the ClientServiceTest actually "doing something" now (before it dit not really), it only works if you have an etcd locally running ("sudo systemctl start etcd") ... we would need to actually start a server, like the tests in jetcd-core do, for the ClientServiceTest to pass on CI.
I have a fix in vorburger@84a50c4, but with the |
TODO With the ClientServiceTest actually "doing something" now (before it dit not really), it only works if you have an etcd locally running ("sudo systemctl start etcd") ... we would need to actually start a server, like the tests in jetcd-core do, for the ClientServiceTest to pass on CI.
TODO With the ClientServiceTest actually "doing something" now (before it dit not really), it only works if you have an etcd locally running ("sudo systemctl start etcd") ... we would need to actually start a server, like the tests in jetcd-core do, for the ClientServiceTest to pass on CI.
TODO With the ClientServiceTest actually "doing something" now (before it dit not really), it only works if you have an etcd locally running ("sudo systemctl start etcd") ... we would need to actually start a server, like the tests in jetcd-core do, for the ClientServiceTest to pass on CI.
and ensure future non-regression by making the ClientServiceTest actually "do something" now (before it dit not really). This can only work if we have an etcd locally running ("sudo systemctl start etcd") ... so we need to actually start a server, like the tests in jetcd-core do, for this test to pass on CI, and really prove that jetcd-all could be loaded and used (!) under OSGi. For this, we use the new launcher artifact introduced in previous commits. It's a bit of a PITA to use launcher (based on testcontainers) with Pax Exam. We solve this by introducing the PaxExamWrapperTest which uses JUnitCore to programmatically launch ClientServiceChecks (formerly ClientServiceTest). To make it clear that jetcd-launcher does not work under OSGi, we do not package it as a bundle anymore, so rm maven-bundle-plugin / MANIFEST.
and ensure future non-regression by making the ClientServiceTest actually "do something" now (before it dit not really). This can only work if we have an etcd locally running ("sudo systemctl start etcd") ... so we need to actually start a server, like the tests in jetcd-core do, for this test to pass on CI, and really prove that jetcd-all could be loaded and used (!) under OSGi. For this, we use the new launcher artifact introduced in previous commits. It's a bit of a PITA to use launcher (based on testcontainers) with Pax Exam. We solve this by introducing the PaxExamWrapperTest which uses JUnitCore to programmatically launch ClientServiceChecks (formerly ClientServiceTest). To make it clear that jetcd-launcher does not work under OSGi, we do not package it as a bundle anymore, so rm maven-bundle-plugin / MANIFEST.
I'm hitting this while playing over in https://github.com/vorburger/opendaylight-etcd :
I guess the
MANIFEST.MF
of the jetcd-all-*.jar is missingjavax.security.cert
in itsImport-Package
..@lburgazzoli does jetcd-all-*.jar work for you under OSGi?
The text was updated successfully, but these errors were encountered: