etcd launcher (based on Testcontainers)

[vorburger]

[This is similar to #361, but based on jetcd code as-is with Testcontainers, instead of ch.vorburger.exec]

It can be useful for projects using this jetcd project to be able to start etcd server in their respective tests. And not just for tests, but possibly also to simplify at least development (but probably never production) set ups - think "embedded database" (à la Derby, h2, MariaDB4j & Co.).

The tests in this project use Testcontainers to achieve this, but this is currently tucked away and hidden in package io.etcd.jetcd.internal.infrastructure in src/test/java of jetcd-core, and therefore not available to anything else.

How about we offer a new published artifact, let me propose to name it jetcd-launcher, where we move io.etcd.jetcd.internal.infrastructure into, as a "supported" utility API? I would, at least eventually, probably even make it generic enough so that it could be implemented not just by Testcontainers, but, later, may be, also by simple local exec as in #361.

@lburgazzoli @fanminshi @hexfusion @gyuho @bsideup OK for you if I raise a PR proposing this?

[lburgazzoli]

Fine with me but I’d sai this low priority

On Thu, 6 Sep 2018 at 19:50, Michael Vorburger ⛑️ ***@***.***> wrote: [This is similar to #361 <#361>, but based on jetcd code as-is with Testcontainers, instead of ch.vorburger.exec <https://github.com/vorburger/ch.vorburger.exec>] It can be useful for projects using this jetcd project to be able to start etcd server in their respective tests. And not just for tests, but possibly also to simplify at least development (but probably never production) set ups - think "embedded database" (à la Derby, h2, MariaDB4j & Co.). The tests in this project use Testcontainers to achieve this, but this is currently tucked away and hidden in package io.etcd.jetcd.internal.infrastructure in src/test/java of jetcd-core, and therefore not available to anything else. How about we offer a new published artifact, let me propose to name it *jetcd-launcher*, where we move io.etcd.jetcd.internal.infrastructure into, as a "supported" utility API? I would, at least eventually, probably even make it generic enough so that it could be implemented not just by Testcontainers, but, later, may be, also by simple local *exec* as in #361 <#361>. @lburgazzoli <https://github.com/lburgazzoli> @fanminshi <https://github.com/fanminshi> @hexfusion <https://github.com/hexfusion> @gyuho <https://github.com/gyuho> @bsideup <https://github.com/bsideup> OK for you if I raise a PR proposing this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#384>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AByEhepMLjRPx1IItfRqspIT32ALUPQvks5uYWBdgaJpZM4Wdade> .

-- -- Luca Burgazzoli

[vorburger]

Fine with me but I’d sai this low priority

but I need it to be able to contribute a non-regression test for #382, AND I'm wiling to actually do it... 😃

[fanminshi]

it sounds like a good idea to me. free feel to work on it.

[vorburger]

done! But let's keep this issue open, so that remember to add a blurb about it to the README ...