fix jetcd-all which was broken under OSGi (#382) #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vorburger
force-pushed
the
issue383-fix-broken-osgi
branch
from
84a50c4
to
cb79697
Compare
|
it's failing :) |
and ensure future non-regression by making the
ClientServiceTest actually "do something" now (before
it dit not really). This can only work if we have an etcd locally running
("sudo systemctl start etcd") ... so we need to actually start a server,
like the tests in jetcd-core do, for this test to pass on CI, and really
prove that jetcd-all could be loaded and used (!) under OSGi.
For this, we use the new launcher artifact introduced in previous commits.
It's a bit of a PITA to use launcher (based on testcontainers) with Pax Exam.
We solve this by introducing the PaxExamWrapperTest which uses JUnitCore to
programmatically launch ClientServiceChecks (formerly ClientServiceTest).
To make it clear that jetcd-launcher does not work under OSGi, we do not
package it as a bundle anymore, so rm maven-bundle-plugin / MANIFEST.
vorburger
force-pushed
the
issue383-fix-broken-osgi
branch
from
cb79697
to
13eb64a
Compare
vorburger
changed the title
No - not anymore! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #382. It builds on top of and uses #386.
Read commit message and JavaDoc in PaxExamWrapperTest for further details.