Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launcher (see #384) #386

Merged
merged 3 commits into from
Sep 6, 2018
Merged

Launcher (see #384) #386

merged 3 commits into from
Sep 6, 2018

Conversation

vorburger
Copy link
Member

see #384

@vorburger
move jetcd.internal.infrastructure into new launcher/ artifact (etcd-…
b396290 
…io#384)
@vorburger
rm TestConstants (it makes less sense in io.etcd.jetcd.launcher)
33365f8
@vorburger
mv LifecycleListener from EtcdCluster to EtcdContainer
cd28b61 
because from the PoV of a consumer of this utility, the
LifecycleListener is something you pass to the (constructor of) the
EtcdContainer.  If you are just looking at EtcdCluster[Factory], you
don'thave to know about LifecycleListener.
@lburgazzoli lburgazzoli merged commit 8f5305a into etcd-io:master Sep 6, 2018
@vorburger vorburger mentioned this pull request Sep 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lburgazzoli lburgazzoli lburgazzoli approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vorburger @lburgazzoli