feat: upgrade to Expo 47 #299
Conversation
| import { ExpoConfig, PublishHook } from '@expo/config-types'; | ||
| import { ConfigPlugin, createRunOncePlugin, WarningAggregator } from 'expo/config-plugins'; | ||
| import type { ExpoConfig } from 'expo/config'; | ||
| import type { PublishHook } from '@expo/config-types'; |
There was a problem hiding this comment.
PublishHook doesn't exist in the re-exports from what I can see. It's not in the exported d.ts files though, so doesn't hurt (I moved @expo/config-types to devDependencies)
| @@ -48,26 +46,27 @@ | |||
| "rimraf": "^3.0.2" | |||
| }, | |||
| "peerDependencies": { | |||
| "expo": "*", | |||
| "expo": ">=47.0.0", | |||
There was a problem hiding this comment.
this is why I think this is a breaking change. In theory, future SDK updates won't, tho
There was a problem hiding this comment.
Yeah, we probably don't want to use the re-exported ones for that reason, I don't think we should make it a breaking release just for that.
There was a problem hiding this comment.
if #301 is breaking, then they can both go in?
There was a problem hiding this comment.
If either of them is breaking, then both of them will have to wait for a bit. I'm not ready to create a fork in the road based on supported SDK versions, and ending up applying changes to both.
|
Thank you very much for your contribution. I've wrapped these changes into #302, as those are also breaking changes and I'd rather ship a single major release. |
Checklist
Why
This package currently pulls in
"@expo/config-plugins": "~5.0.0"and"@expo/config-types": "^46.0.1", which are both for SDK 46.How
Looking at https://blog.expo.dev/expo-sdk-47-a0f6f5c038af, imports should be moved to
expopackage which would allow us to not have this PR for future SDK releases 🙂Test Plan
Just TS - I haven't tried to apply this to a project.