Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade @sentry/react-native #301

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Nov 16, 2022

Checklist

Why

The current version is quite outdated.

Closes #293

How

Upgraded all @sentry packages, and made the necessary type change.

I'm not sure if this should be considered a breaking change?

Test Plan

Not sure - hopefully you have some test app you can use? 😀

CHANGELOG.md Outdated Show resolved Hide resolved
@SimenB SimenB mentioned this pull request Nov 17, 2022
1 task
@kbrandwijk
Copy link
Contributor

Would this be breaking because Sentry now expects these fields to be either set or undefined, and expo-device returns null?

@SimenB
Copy link
Contributor Author

SimenB commented Nov 17, 2022

I don't think so - I assume the type is stricter than the implementation 🙂 Haven't checked tho.

The reason I think this might be breaking is simply because the user's version must match

@kbrandwijk
Copy link
Contributor

Thank you very much for your contribution. I've wrapped these changes into #302, as those are also breaking changes and I'd rather ship a single major release.

@kbrandwijk kbrandwijk closed this Nov 23, 2022
@SimenB
Copy link
Contributor Author

SimenB commented Nov 23, 2022

you can land this on a separate branch (then land that in bulk for release) so the commit (and the contribution) is kept in history. I personally don't care (just happy to see movement! 🥳), but I think in general that's a better approach than bundling it all under "eas support"

@kbrandwijk kbrandwijk reopened this Nov 23, 2022
@kbrandwijk
Copy link
Contributor

You're right, I forget that matters for external contributions.

@kbrandwijk kbrandwijk merged commit 9844a1c into expo:main Nov 23, 2022
@SimenB SimenB deleted the update-sentry branch November 23, 2022 10:16
@SimenB
Copy link
Contributor Author

SimenB commented Nov 23, 2022

Thanks!

@kbrandwijk
Copy link
Contributor

@SimenB If you restore the other 2 branches, I'd be happy to do the same there.

@SimenB
Copy link
Contributor Author

SimenB commented Nov 23, 2022

Done 👍 I'm happy to rebase if needed (I assume they conflict with this PR)

(rebased them)

@kbrandwijk
Copy link
Contributor

It doesn't let me reopen the PRs
image
Could I bother you to put up 2 new PRs? You can just reference the old ones for details. Sorry for the inconvenience.

@SimenB
Copy link
Contributor Author

SimenB commented Nov 23, 2022

hah, should have held off on the rebase 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump underlying Sentry JS dependency?
3 participants