Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EAS Update #302

Merged
merged 11 commits into from
Nov 24, 2022
Merged

Add support for EAS Update #302

merged 11 commits into from
Nov 24, 2022

Conversation

kbrandwijk
Copy link
Contributor

Checklist

Why

This PR adds support for EAS Update.

How

This PR adds support for EAS Update through the following set of changes:

  • Uses the new Updates.isEmbeddedLaunch property of expo-updates to determine whether a build or an update is loaded.
  • For the base build, uses the existing logic for setting the dist value that matches the default behavior of the embedded scripts that are used at build time to set dist
  • For updates, uses the Updates.updateId as unique identifier for dist. The release field is untouched, as the update applies to the same release (major version and build number/version code).
  • Upgrading expo-updates required an upgrade to Expo SDK 47. This will be the minimum supported SDK release for this version.
  • As part of the upgrade, @sentry/react-native is also bumped to the latest version
  • Sentry has introduced @sentry/react as a wrapper for @sentry/browser. As this is more applicable to the web projects this libary is used for, this is now exported as Sentry.React.*. The exports also stay available through Sentry.Browser.* for backwards compatibility purposes.

Test Plan

This version of sentry-expo has been successfully used in manual testing in an app for both builds and updates.

package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/sentry.ts Outdated Show resolved Hide resolved
@kbrandwijk kbrandwijk merged commit 0b507a1 into main Nov 24, 2022
@kbrandwijk kbrandwijk deleted the kbrandwijk/eas-update-support branch November 24, 2022 13:09
@kbrandwijk
Copy link
Contributor Author

🎉

Does https://github.com/expo/expo/blob/4fdd6db265db5fac025fffd1dbc33143d7c8a7ed/packages/expo/bundledNativeModules.json#L103 and https://github.com/expo/expo/blob/4fdd6db265db5fac025fffd1dbc33143d7c8a7ed/packages/expo/bundledNativeModules.json#L108 need to be updated?

Absolutely, which is why expo/expo#20201 is pending merge. I always want to make sure there's no issues with the release before making it the default for everyone.

@solarisn
Copy link

solarisn commented Jan 17, 2023

Any advice for sourcemap uploads to Sentry for EAS Updates? Will there be support for automatic upload as a post-publish hook when deploying an EAS Update? Thanks for your work on this!

@SimenB
Copy link
Contributor

SimenB commented Jan 17, 2023

You can try to adapt expo/expo#19753 (comment)

@solarisn
Copy link

There are new instructions for managing sourcemap upload when running using EAS Updates inside of the official Expo documentation:
https://docs.expo.dev/guides/using-sentry/#uploading-source-maps-for-updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants