skip QUERY method test

[jonchurch]

related: #5615

First step is to stop running this test until there is a node version which supports QUERY properly.

resolves the failure we see in node 21 latest and node 22 latest

[wesleytodd]

I wonder if we should do this in the methods package? Not sure how widely used that is outside of express but this could help in a more broad way if done there.

[joeyguerra]

Adding it to the methods module makes sense because it's an HTTP VERB.

[jonchurch]

Good point.

From the readme of methods though, that doesn't sound like the contract that it claims to expose:

methods

This is an array of lower-cased method names that Node.js supports. If Node.js provides the http.METHODS export, then this is the same array lower-cased, otherwise it is a snapshot of the verbs from Node.js 0.10.

[ctcpip]

I have seen a lot of skipped tests in codebases that stay skipped long after they should have been fixed.

Can we do something preventative to avoid this happening in this case? For example, a check against process.version. The idea being that the TODO is inverted and becomes a task to re-commit to the skip when a new version is being tested (which importantly is forced via a test failure), rather than a TODO to remember to bring back/fix the test.

[wesleytodd]

that Node.js supports

But it doesnt yet support it correctly, so I feel like that is alright.

[jonchurch]

Thats a good point though @ctcpip

How bout we skip it in 21 and 22, until we know what patch it should work in?

Edit: PR updated to do just that

The benefit to the ecosystem here is that this test failed node's citgm for express. We found a gap in Node between http.METHODS and actual support because it failed. We got that information, filed a bug, can act on it by skipping in affected releases, and are waiting for a patch.

But if 23 came out and it was broken, we'd def want to know that. Same for if it somehow could go red in any other past release.

We can skip with
// todo: enable test on 21 and 22 in supported versions once they land

[ctcpip]

awesome