-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable custom source file extensions through cli args or rn-cli.config.js #13689
Conversation
test fails with this error: UnableToResolveError: Unable to resolve module `./a` from `/root/index.jsx`: Directory /root/a doesn't exist at UnableToResolveError (packager/src/node-haste/DependencyGraph/ResolutionRequest.js:625:5) at ResolutionRequest._loadAsDir (packager/src/node-haste/DependencyGraph/ResolutionRequest.js:585:13) at tryResolveSync (packager/src/node-haste/DependencyGraph/ResolutionRequest.js:441:16) at tryResolveSync (packager/src/node-haste/DependencyGraph/ResolutionRequest.js:88:12) ...
I updated the TestCustomSourceExts repo to have incremental commits so people can see exactly what changed from a regular old blank react-native app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! The "default config" system is a bit of a mess, for example packager/defaults
really is the "base", not overridable defaults. We'll look into fixing that later on. This changeset follows the same way assetExts
had been done so that's good.
@jeanlauliac has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's been a bunch of changes happening, I'm rebasing this on the latest and doing a few tweaks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just putting back it in 'change requested' state while waiting for the rebase, but I'm dealing with it and there's no action needed on your part right now.
I'll ship that tomorrow morning London-time. |
4a86f93 is the upgraded version I landed. @ds300 Do you want to check it out in https://github.com/ds300/TestCustomSourceExts and verify it covers what you need? |
@jeanlauliac I'm getting this error after switching to your branch. The cause wasn't obvious from initial inspection.
Your changes look sensible to me otherwise. This is probably related to other changes that have happened in the meantime. I'll try to take a proper look on Sunday evening UK time. |
I've been eager to use this for a while and have been kicking the tires a bit. With a With this environment everything seems to work great except for source maps -- they are off by a few lines. |
@jmfirth I think that's an orthogonal issue. This PR doesn't say anything about how source transformation should happen. And in particular the transformer I wrote for the test repo is extremely simplistic and doesn't compose the tsc source map with the babel one. So if you are using that, the discrepancy you observe makes sense. |
@jeanlauliac the issue was obvious after all. There has been a breaking change in handling the Now the path given to cc @davidaurelio this seems like a bad design decision to me, since it makes it super awkward to have a config file in a multi-dev project, unless I'm missing something. But also that's beside the point for this PR. Making the path absolute makes the problem go away, and now I get a new error, but I also get that same error if I run a blank RN project against master, so it is likely to be unrelated. In other words, I'm happy with your changes @jeanlauliac 👍 |
Hey @ds300, that was the case before my commit as well. I agree it is awkward. Correct me if I am wrong, but I think my changeset did not change behavior at all: before, both config file and |
Feel free to send a PR that changes the base of the resolution to |
Oh, true, @davidaurelio my apologies. I didn't look too closely at the history. Will investigate tonight to find out exactly when support for relative paths was removed and why. |
Closing, let's open separate tasks or PRs to address the other issues. On an unrelated note, I'm disappointed in myself that I didn't properly give you credit for the changeset. Even though I rebased and changed a few things, you provided most of the idea and original code. I will be careful to maintain a correct Authored-by field next time I merge a PR. I regret not doing so. |
Slightly confused with what's happening with this PR. Has it been released with 0.45 ? |
@johnnycopperstone yep. |
Summary: This sync includes the following changes: - **[d83601080](facebook/react@d83601080)**: Wrap retrySuspendedRoot using SchedulerTracing (#13776) //<Sophie Alpert>// - **[40a521aa7](facebook/react@40a521aa7)**: Terminology: Functional -> Function Component (#13775) //<Dan Abramov>// - **[605ab10a4](facebook/react@605ab10a4)**: Add envify transform to scheduler package (#13766) //<Michael Ridgway>// - **[acc7f404c](facebook/react@acc7f404c)**: Restart from root if promise pings before end of render phase (#13774) //<Andrew Clark>// - **[cbc224028](facebook/react@cbc224028)**: fix - small misspelling (#13768) //<Spencer Davies>// - **[4eabeef11](facebook/react@4eabeef11)**: Rename ReactSuspenseWithTestRenderer-test -> ReactSuspense-test //<Andrew Clark>// - **[95a3e1c2e](facebook/react@95a3e1c2e)**: Rename ReactSuspense-test -> ReactSuspenseWithNoopRenderer-test //<Andrew Clark>// - **[96bcae9d5](facebook/react@96bcae9d5)**: Jest + test renderer helpers for concurrent mode (#13751) //<Andrew Clark>// - **[5c783ee75](facebook/react@5c783ee75)**: Remove unreachable code (#13762) //<Heaven>// - **[36c5d69ca](facebook/react@36c5d69ca)**: Always warn about legacy context within StrictMode tree (#13760) //<Brian Vaughn>// - **[3e9a5de88](facebook/react@3e9a5de88)**: UMD react-cache build (#13761) //<Maksim Markelov>// - **[8315a30b9](facebook/react@8315a30b9)**: --save is no longer needed (#13756) //<Joe Cortopassi>// - **[ce96e2df4](facebook/react@ce96e2df4)**: Rename simple-cache-provider to react-cache (#13755) //<Andrew Clark>// - **[c5212646f](facebook/react@c5212646f)**: Removed extra typeof checks for contextType.unstable_read (#13736) //<Brian Vaughn>// - **[806eebdae](facebook/react@806eebdae)**: Enable getDerivedStateFromError (#13746) //<Brian Vaughn>// - **[a0733fe13](facebook/react@a0733fe13)**: pure (#13748) //<Andrew Clark>// - **[4d17c3f05](facebook/react@4d17c3f05)**: [scheduler] Improve naive fallback version used in non-DOM environments //<Andrew Clark>// - **[469005d87](facebook/react@469005d87)**: Revise `AttributeType` React Native Flow Type (#13737) //<Timothy Yung>// - **[0dc0ddc1e](facebook/react@0dc0ddc1e)**: Rename AsyncMode -> ConcurrentMode (#13732) //<Dominic Gannaway>// - **[7601c3765](facebook/react@7601c3765)**: Ensure "addEventListener" exists on "window" for "scheduler" package (#13731) //<Dominic Gannaway>// - **[d0c0ec98e](facebook/react@d0c0ec98e)**: Added a PureComponent contextType test (#13729) //<Brian Vaughn>// - **[4b68a6498](facebook/react@4b68a6498)**: Support class component static contextType attribute (#13728) //<Brian Vaughn>// - **[f305d2a48](facebook/react@f305d2a48)**: [scheduler] Priority levels, continuations, and wrapped callbacks (#13720) //<Andrew Clark>// - **[970a34bae](facebook/react@970a34bae)**: Bump babel-eslint and remove flow supressions (#13727) //<Brian Ng>// - **[13965b4d3](facebook/react@13965b4d3)**: Interaction tracking ref-counting bug fixes (WIP) (#13590) //<Brian Vaughn>// - **[17e703cb9](facebook/react@17e703cb9)**: Restore global window.event after event dispatching (#13688) (#13697) //<Sergei Startsev>// - **[a775a767a](facebook/react@a775a767a)**: Remove redundant logic (#13502) //<Heaven>// - **[e1a067dea](facebook/react@e1a067dea)**: Fix circular dependency in TracingSubscriptions (#13689) //<Maksim Markelov>// - **[518812eeb](facebook/react@518812eeb)**: Clarify comment (#13684) //<Heaven>// - **[eeb817785](facebook/react@eeb817785)**: Remove some old files from stats //<Dan>// - **[7ea3ca1d1](facebook/react@7ea3ca1d1)**: Rename schedule to scheduler (#13683) //<Dan Abramov>// - **[bec2ddaf1](facebook/react@bec2ddaf1)**: Update bundle sizes for 16.5.2 release //<Brian Vaughn>// - **[4269fafb0](facebook/react@4269fafb0)**: Updating package versions for release 16.5.2 //<Brian Vaughn>// - **[4380f9ba1](facebook/react@4380f9ba1)**: Revert "Updating package versions for release 16.6.0-alpha.0" //<Brian Vaughn>// - **[72fad84e7](facebook/react@72fad84e7)**: Revert "Updating dependencies for react-noop-renderer" //<Brian Vaughn>// - **[c3fad5acf](facebook/react@c3fad5acf)**: Revert "Update bundle sizes for 16.6.0-alpha.0 release" //<Brian Vaughn>// - **[dd9120561](facebook/react@dd9120561)**: Kepp calling peformWork consistent (#13596) //<Heaven>// - **[42d12317a](facebook/react@42d12317a)**: Update bundle sizes for 16.6.0-alpha.0 release //<Brian Vaughn>// - **[489614c4f](facebook/react@489614c4f)**: Updating dependencies for react-noop-renderer //<Brian Vaughn>// - **[351c9015c](facebook/react@351c9015c)**: Updating package versions for release 16.6.0-alpha.0 //<Brian Vaughn>// - **[a210b5b44](facebook/react@a210b5b44)**: Revert "Do not bind topLevelType to dispatch" (#13674) //<Dan Abramov>// - **[1d8a75fef](facebook/react@1d8a75fef)**: remove flow typings from Schedule.js (#13662) //<Alexey Raspopov>// - **[d92114b98](facebook/react@d92114b98)**: Resubmit: Fix updateWrapper causing re-render textarea, even though their data (#13643) //<Nathan Hunzaker>// - **[0c9c591bf](facebook/react@0c9c591bf)**: Do not bind topLevelType to dispatch (#13618) //<Nathan Hunzaker>// - **[9f819a5ea](facebook/react@9f819a5ea)**: [schedule] Refactor Schedule, remove React-isms (#13582) //<Andrew Clark>// - **[9c961c0a2](facebook/react@9c961c0a2)**: Fix some iframe edge cases (#13650) //<Jérôme Steunou>// - **[8bc0bcabe](facebook/react@8bc0bcabe)**: Add UMD production+profiling entry points (#13642) //<Brian Vaughn>// - **[b488a5d9c](facebook/react@b488a5d9c)**: Fix test comment typo (#13568) //<Heaven>// - **[4bcee5621](facebook/react@4bcee5621)**: Rename "tracking" API to "tracing" (#13641) //<Brian Vaughn>// - **[72217d081](facebook/react@72217d081)**: Update bundle sizes for 16.5.1 release //<Dan Abramov>// - **[8b93a60c5](facebook/react@8b93a60c5)**: Updating package versions for release 16.5.1 //<Dan Abramov>// - **[ecbf7af40](facebook/react@ecbf7af40)**: Enhance dev warnings for forwardRef render function (#13627) (#13636) //<Andres Rojas>// - **[228240085](facebook/react@228240085)**: Delete TapEventPlugin (#13630) //<Dan Abramov>// - **[a079011f9](facebook/react@a079011f9)**: ð Stop syncing the value attribute on inputs (behind a feature flag) (#13526) //<Nathan Hunzaker>// - **[a7bd7c3c0](facebook/react@a7bd7c3c0)**: Allow reading default feature flags from bundle tests (#13629) //<Dan Abramov>// - **[d3bbfe09c](facebook/react@d3bbfe09c)**: Fix IE version in comment //<Dan Abramov>// - **[1b2646a40](facebook/react@1b2646a40)**: Fix warning without stack for ie9 (#13620) //<Aliaksandr Manzhula>// - **[e49f3ca08](facebook/react@e49f3ca08)**: honor displayName set on ForwardRef if available (#13615) //<Evan Jacobs>// Release Notes: [GENERAL] [FEATURE] [React] - React sync for revisions ade5e69...d836010 Reviewed By: bvaughn Differential Revision: D10118547 fbshipit-source-id: ecde7ada80331abdc8bd7d279e0f3dbe9acde071
Summary: This sync includes the following changes: - **[d83601080](facebook/react@d83601080)**: Wrap retrySuspendedRoot using SchedulerTracing (#13776) //<Sophie Alpert>// - **[40a521aa7](facebook/react@40a521aa7)**: Terminology: Functional -> Function Component (#13775) //<Dan Abramov>// - **[605ab10a4](facebook/react@605ab10a4)**: Add envify transform to scheduler package (#13766) //<Michael Ridgway>// - **[acc7f404c](facebook/react@acc7f404c)**: Restart from root if promise pings before end of render phase (#13774) //<Andrew Clark>// - **[cbc224028](facebook/react@cbc224028)**: fix - small misspelling (#13768) //<Spencer Davies>// - **[4eabeef11](facebook/react@4eabeef11)**: Rename ReactSuspenseWithTestRenderer-test -> ReactSuspense-test //<Andrew Clark>// - **[95a3e1c2e](facebook/react@95a3e1c2e)**: Rename ReactSuspense-test -> ReactSuspenseWithNoopRenderer-test //<Andrew Clark>// - **[96bcae9d5](facebook/react@96bcae9d5)**: Jest + test renderer helpers for concurrent mode (#13751) //<Andrew Clark>// - **[5c783ee75](facebook/react@5c783ee75)**: Remove unreachable code (#13762) //<Heaven>// - **[36c5d69ca](facebook/react@36c5d69ca)**: Always warn about legacy context within StrictMode tree (#13760) //<Brian Vaughn>// - **[3e9a5de88](facebook/react@3e9a5de88)**: UMD react-cache build (#13761) //<Maksim Markelov>// - **[8315a30b9](facebook/react@8315a30b9)**: --save is no longer needed (#13756) //<Joe Cortopassi>// - **[ce96e2df4](facebook/react@ce96e2df4)**: Rename simple-cache-provider to react-cache (#13755) //<Andrew Clark>// - **[c5212646f](facebook/react@c5212646f)**: Removed extra typeof checks for contextType.unstable_read (#13736) //<Brian Vaughn>// - **[806eebdae](facebook/react@806eebdae)**: Enable getDerivedStateFromError (#13746) //<Brian Vaughn>// - **[a0733fe13](facebook/react@a0733fe13)**: pure (#13748) //<Andrew Clark>// - **[4d17c3f05](facebook/react@4d17c3f05)**: [scheduler] Improve naive fallback version used in non-DOM environments //<Andrew Clark>// - **[469005d87](facebook/react@469005d87)**: Revise `AttributeType` React Native Flow Type (#13737) //<Timothy Yung>// - **[0dc0ddc1e](facebook/react@0dc0ddc1e)**: Rename AsyncMode -> ConcurrentMode (#13732) //<Dominic Gannaway>// - **[7601c3765](facebook/react@7601c3765)**: Ensure "addEventListener" exists on "window" for "scheduler" package (#13731) //<Dominic Gannaway>// - **[d0c0ec98e](facebook/react@d0c0ec98e)**: Added a PureComponent contextType test (#13729) //<Brian Vaughn>// - **[4b68a6498](facebook/react@4b68a6498)**: Support class component static contextType attribute (#13728) //<Brian Vaughn>// - **[f305d2a48](facebook/react@f305d2a48)**: [scheduler] Priority levels, continuations, and wrapped callbacks (#13720) //<Andrew Clark>// - **[970a34bae](facebook/react@970a34bae)**: Bump babel-eslint and remove flow supressions (#13727) //<Brian Ng>// - **[13965b4d3](facebook/react@13965b4d3)**: Interaction tracking ref-counting bug fixes (WIP) (#13590) //<Brian Vaughn>// - **[17e703cb9](facebook/react@17e703cb9)**: Restore global window.event after event dispatching (#13688) (#13697) //<Sergei Startsev>// - **[a775a767a](facebook/react@a775a767a)**: Remove redundant logic (#13502) //<Heaven>// - **[e1a067dea](facebook/react@e1a067dea)**: Fix circular dependency in TracingSubscriptions (#13689) //<Maksim Markelov>// - **[518812eeb](facebook/react@518812eeb)**: Clarify comment (#13684) //<Heaven>// - **[eeb817785](facebook/react@eeb817785)**: Remove some old files from stats //<Dan>// - **[7ea3ca1d1](facebook/react@7ea3ca1d1)**: Rename schedule to scheduler (#13683) //<Dan Abramov>// - **[bec2ddaf1](facebook/react@bec2ddaf1)**: Update bundle sizes for 16.5.2 release //<Brian Vaughn>// - **[4269fafb0](facebook/react@4269fafb0)**: Updating package versions for release 16.5.2 //<Brian Vaughn>// - **[4380f9ba1](facebook/react@4380f9ba1)**: Revert "Updating package versions for release 16.6.0-alpha.0" //<Brian Vaughn>// - **[72fad84e7](facebook/react@72fad84e7)**: Revert "Updating dependencies for react-noop-renderer" //<Brian Vaughn>// - **[c3fad5acf](facebook/react@c3fad5acf)**: Revert "Update bundle sizes for 16.6.0-alpha.0 release" //<Brian Vaughn>// - **[dd9120561](facebook/react@dd9120561)**: Kepp calling peformWork consistent (#13596) //<Heaven>// - **[42d12317a](facebook/react@42d12317a)**: Update bundle sizes for 16.6.0-alpha.0 release //<Brian Vaughn>// - **[489614c4f](facebook/react@489614c4f)**: Updating dependencies for react-noop-renderer //<Brian Vaughn>// - **[351c9015c](facebook/react@351c9015c)**: Updating package versions for release 16.6.0-alpha.0 //<Brian Vaughn>// - **[a210b5b44](facebook/react@a210b5b44)**: Revert "Do not bind topLevelType to dispatch" (#13674) //<Dan Abramov>// - **[1d8a75fef](facebook/react@1d8a75fef)**: remove flow typings from Schedule.js (#13662) //<Alexey Raspopov>// - **[d92114b98](facebook/react@d92114b98)**: Resubmit: Fix updateWrapper causing re-render textarea, even though their data (#13643) //<Nathan Hunzaker>// - **[0c9c591bf](facebook/react@0c9c591bf)**: Do not bind topLevelType to dispatch (#13618) //<Nathan Hunzaker>// - **[9f819a5ea](facebook/react@9f819a5ea)**: [schedule] Refactor Schedule, remove React-isms (#13582) //<Andrew Clark>// - **[9c961c0a2](facebook/react@9c961c0a2)**: Fix some iframe edge cases (#13650) //<Jérôme Steunou>// - **[8bc0bcabe](facebook/react@8bc0bcabe)**: Add UMD production+profiling entry points (#13642) //<Brian Vaughn>// - **[b488a5d9c](facebook/react@b488a5d9c)**: Fix test comment typo (#13568) //<Heaven>// - **[4bcee5621](facebook/react@4bcee5621)**: Rename "tracking" API to "tracing" (#13641) //<Brian Vaughn>// - **[72217d081](facebook/react@72217d081)**: Update bundle sizes for 16.5.1 release //<Dan Abramov>// - **[8b93a60c5](facebook/react@8b93a60c5)**: Updating package versions for release 16.5.1 //<Dan Abramov>// - **[ecbf7af40](facebook/react@ecbf7af40)**: Enhance dev warnings for forwardRef render function (#13627) (#13636) //<Andres Rojas>// - **[228240085](facebook/react@228240085)**: Delete TapEventPlugin (#13630) //<Dan Abramov>// - **[a079011f9](facebook/react@a079011f9)**: ð Stop syncing the value attribute on inputs (behind a feature flag) (#13526) //<Nathan Hunzaker>// - **[a7bd7c3c0](facebook/react@a7bd7c3c0)**: Allow reading default feature flags from bundle tests (#13629) //<Dan Abramov>// - **[d3bbfe09c](facebook/react@d3bbfe09c)**: Fix IE version in comment //<Dan Abramov>// - **[1b2646a40](facebook/react@1b2646a40)**: Fix warning without stack for ie9 (#13620) //<Aliaksandr Manzhula>// - **[e49f3ca08](facebook/react@e49f3ca08)**: honor displayName set on ForwardRef if available (#13615) //<Evan Jacobs>// Release Notes: [GENERAL] [FEATURE] [React] - React sync for revisions ade5e69...d836010 Reviewed By: bvaughn Differential Revision: D10118547 fbshipit-source-id: ecde7ada80331abdc8bd7d279e0f3dbe9acde071
Summary: This sync includes the following changes: - **[d83601080](facebook/react@d83601080)**: Wrap retrySuspendedRoot using SchedulerTracing (facebook#13776) //<Sophie Alpert>// - **[40a521aa7](facebook/react@40a521aa7)**: Terminology: Functional -> Function Component (facebook#13775) //<Dan Abramov>// - **[605ab10a4](facebook/react@605ab10a4)**: Add envify transform to scheduler package (facebook#13766) //<Michael Ridgway>// - **[acc7f404c](facebook/react@acc7f404c)**: Restart from root if promise pings before end of render phase (facebook#13774) //<Andrew Clark>// - **[cbc224028](facebook/react@cbc224028)**: fix - small misspelling (facebook#13768) //<Spencer Davies>// - **[4eabeef11](facebook/react@4eabeef11)**: Rename ReactSuspenseWithTestRenderer-test -> ReactSuspense-test //<Andrew Clark>// - **[95a3e1c2e](facebook/react@95a3e1c2e)**: Rename ReactSuspense-test -> ReactSuspenseWithNoopRenderer-test //<Andrew Clark>// - **[96bcae9d5](facebook/react@96bcae9d5)**: Jest + test renderer helpers for concurrent mode (facebook#13751) //<Andrew Clark>// - **[5c783ee75](facebook/react@5c783ee75)**: Remove unreachable code (facebook#13762) //<Heaven>// - **[36c5d69ca](facebook/react@36c5d69ca)**: Always warn about legacy context within StrictMode tree (facebook#13760) //<Brian Vaughn>// - **[3e9a5de88](facebook/react@3e9a5de88)**: UMD react-cache build (facebook#13761) //<Maksim Markelov>// - **[8315a30b9](facebook/react@8315a30b9)**: --save is no longer needed (facebook#13756) //<Joe Cortopassi>// - **[ce96e2df4](facebook/react@ce96e2df4)**: Rename simple-cache-provider to react-cache (facebook#13755) //<Andrew Clark>// - **[c5212646f](facebook/react@c5212646f)**: Removed extra typeof checks for contextType.unstable_read (facebook#13736) //<Brian Vaughn>// - **[806eebdae](facebook/react@806eebdae)**: Enable getDerivedStateFromError (facebook#13746) //<Brian Vaughn>// - **[a0733fe13](facebook/react@a0733fe13)**: pure (facebook#13748) //<Andrew Clark>// - **[4d17c3f05](facebook/react@4d17c3f05)**: [scheduler] Improve naive fallback version used in non-DOM environments //<Andrew Clark>// - **[469005d87](facebook/react@469005d87)**: Revise `AttributeType` React Native Flow Type (facebook#13737) //<Timothy Yung>// - **[0dc0ddc1e](facebook/react@0dc0ddc1e)**: Rename AsyncMode -> ConcurrentMode (facebook#13732) //<Dominic Gannaway>// - **[7601c3765](facebook/react@7601c3765)**: Ensure "addEventListener" exists on "window" for "scheduler" package (facebook#13731) //<Dominic Gannaway>// - **[d0c0ec98e](facebook/react@d0c0ec98e)**: Added a PureComponent contextType test (facebook#13729) //<Brian Vaughn>// - **[4b68a6498](facebook/react@4b68a6498)**: Support class component static contextType attribute (facebook#13728) //<Brian Vaughn>// - **[f305d2a48](facebook/react@f305d2a48)**: [scheduler] Priority levels, continuations, and wrapped callbacks (facebook#13720) //<Andrew Clark>// - **[970a34bae](facebook/react@970a34bae)**: Bump babel-eslint and remove flow supressions (facebook#13727) //<Brian Ng>// - **[13965b4d3](facebook/react@13965b4d3)**: Interaction tracking ref-counting bug fixes (WIP) (facebook#13590) //<Brian Vaughn>// - **[17e703cb9](facebook/react@17e703cb9)**: Restore global window.event after event dispatching (facebook#13688) (facebook#13697) //<Sergei Startsev>// - **[a775a767a](facebook/react@a775a767a)**: Remove redundant logic (facebook#13502) //<Heaven>// - **[e1a067dea](facebook/react@e1a067dea)**: Fix circular dependency in TracingSubscriptions (facebook#13689) //<Maksim Markelov>// - **[518812eeb](facebook/react@518812eeb)**: Clarify comment (facebook#13684) //<Heaven>// - **[eeb817785](facebook/react@eeb817785)**: Remove some old files from stats //<Dan>// - **[7ea3ca1d1](facebook/react@7ea3ca1d1)**: Rename schedule to scheduler (facebook#13683) //<Dan Abramov>// - **[bec2ddaf1](facebook/react@bec2ddaf1)**: Update bundle sizes for 16.5.2 release //<Brian Vaughn>// - **[4269fafb0](facebook/react@4269fafb0)**: Updating package versions for release 16.5.2 //<Brian Vaughn>// - **[4380f9ba1](facebook/react@4380f9ba1)**: Revert "Updating package versions for release 16.6.0-alpha.0" //<Brian Vaughn>// - **[72fad84e7](facebook/react@72fad84e7)**: Revert "Updating dependencies for react-noop-renderer" //<Brian Vaughn>// - **[c3fad5acf](facebook/react@c3fad5acf)**: Revert "Update bundle sizes for 16.6.0-alpha.0 release" //<Brian Vaughn>// - **[dd9120561](facebook/react@dd9120561)**: Kepp calling peformWork consistent (facebook#13596) //<Heaven>// - **[42d12317a](facebook/react@42d12317a)**: Update bundle sizes for 16.6.0-alpha.0 release //<Brian Vaughn>// - **[489614c4f](facebook/react@489614c4f)**: Updating dependencies for react-noop-renderer //<Brian Vaughn>// - **[351c9015c](facebook/react@351c9015c)**: Updating package versions for release 16.6.0-alpha.0 //<Brian Vaughn>// - **[a210b5b44](facebook/react@a210b5b44)**: Revert "Do not bind topLevelType to dispatch" (facebook#13674) //<Dan Abramov>// - **[1d8a75fef](facebook/react@1d8a75fef)**: remove flow typings from Schedule.js (facebook#13662) //<Alexey Raspopov>// - **[d92114b98](facebook/react@d92114b98)**: Resubmit: Fix updateWrapper causing re-render textarea, even though their data (facebook#13643) //<Nathan Hunzaker>// - **[0c9c591bf](facebook/react@0c9c591bf)**: Do not bind topLevelType to dispatch (facebook#13618) //<Nathan Hunzaker>// - **[9f819a5ea](facebook/react@9f819a5ea)**: [schedule] Refactor Schedule, remove React-isms (facebook#13582) //<Andrew Clark>// - **[9c961c0a2](facebook/react@9c961c0a2)**: Fix some iframe edge cases (facebook#13650) //<Jérôme Steunou>// - **[8bc0bcabe](facebook/react@8bc0bcabe)**: Add UMD production+profiling entry points (facebook#13642) //<Brian Vaughn>// - **[b488a5d9c](facebook/react@b488a5d9c)**: Fix test comment typo (facebook#13568) //<Heaven>// - **[4bcee5621](facebook/react@4bcee5621)**: Rename "tracking" API to "tracing" (facebook#13641) //<Brian Vaughn>// - **[72217d081](facebook/react@72217d081)**: Update bundle sizes for 16.5.1 release //<Dan Abramov>// - **[8b93a60c5](facebook/react@8b93a60c5)**: Updating package versions for release 16.5.1 //<Dan Abramov>// - **[ecbf7af40](facebook/react@ecbf7af40)**: Enhance dev warnings for forwardRef render function (facebook#13627) (facebook#13636) //<Andres Rojas>// - **[228240085](facebook/react@228240085)**: Delete TapEventPlugin (facebook#13630) //<Dan Abramov>// - **[a079011f9](facebook/react@a079011f9)**: ð Stop syncing the value attribute on inputs (behind a feature flag) (facebook#13526) //<Nathan Hunzaker>// - **[a7bd7c3c0](facebook/react@a7bd7c3c0)**: Allow reading default feature flags from bundle tests (facebook#13629) //<Dan Abramov>// - **[d3bbfe09c](facebook/react@d3bbfe09c)**: Fix IE version in comment //<Dan Abramov>// - **[1b2646a40](facebook/react@1b2646a40)**: Fix warning without stack for ie9 (facebook#13620) //<Aliaksandr Manzhula>// - **[e49f3ca08](facebook/react@e49f3ca08)**: honor displayName set on ForwardRef if available (facebook#13615) //<Evan Jacobs>// Release Notes: [GENERAL] [FEATURE] [React] - React sync for revisions ade5e69...d836010 Reviewed By: bvaughn Differential Revision: D10118547 fbshipit-source-id: ecde7ada80331abdc8bd7d279e0f3dbe9acde071
Ping @cpojer - This is the replacement PR for #11932
Motivation (required)
Allow the packager to load files from other compile-to-JS languages without developers having to specify file extensions in
require
calls.Approach
Add an optional
getSourceExts
method torn-cli.config.js
, like the existinggetAssetExts
. Set defaults of'js'
and'json'
(as were being used before) and make sure the options are propagated through to the packager appropriately, then use them in module resolution.Extensions specified by
getSourceExts
do not override the defaults but are combined with them, otherwise first-party react-native code would not be loaded.Test Plan (required)
Tests for the changes to node-haste are included. I couldn't find any integration tests for
rn-cli.config.js
or the cli config opts anywhere, so I figured it wouldn't be necessary to add those. If that is required, it would be dope if someone with the appropriate knowledge could help direct that effort.Here is a repo that shows it working: https://github.com/ds300/TestCustomSourceExts
Cheers