Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing space-evenly #17805

Closed
wants to merge 1 commit into from
Closed

Implementing space-evenly #17805

wants to merge 1 commit into from

Conversation

gedeagas
Copy link
Contributor

Motivation

So in v0.52.0 space-evenly is introduced but not yet implemented (1050e0b by @woehrl01). This pull request implements the space-evenly.

Test Plan

Manual Testing.
notes marker

Release Notes

[IOS] [FEATURE] [Yoga] Adding space-evenly on justify-content in iOS
[ANDROID] [FEATURE] [Yoga] - Adding space-evenly on justify-content in Android

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. cla signed labels Jan 31, 2018
@gedeagas gedeagas mentioned this pull request Jan 31, 2018
Closed
@pull-bot
Copy link

Attention: @shergin

Generated by 🚫 dangerJS

@gedeagas
Copy link
Contributor Author

Referencing an issue about this
#17728

@shergin
Copy link
Contributor

shergin commented Jan 31, 2018

@gedeagas Thank you!! ❤️

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jan 31, 2018
facebook-github-bot
facebook-github-bot approved these changes Jan 31, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mizinin
Copy link

mizinin commented Feb 17, 2018

It would be very cool to cherry-pick this patch into current stable branch (0.53) and make update

Plo4ox pushed a commit to Plo4ox/react-native that referenced this pull request Feb 17, 2018
@gedeagas
Implementing space-evenly
af11ea7 
Summary:
So in v0.52.0 space-evenly is introduced but not yet implemented (1050e0b by woehrl01). This pull request implements the space-evenly.

Manual Testing.
![notes marker](https://i.imgur.com/IXmezVY.png)

[IOS] [FEATURE] [Yoga] Adding space-evenly on justify-content in iOS
[ANDROID] [FEATURE] [Yoga] - Adding space-evenly on justify-content in Android
Closes facebook#17805

Differential Revision: D6858294

Pulled By: shergin

fbshipit-source-id: 7a705ca05f58603ef4588e1bfd16c16a78f8a390
@GollyJer
Copy link

GollyJer commented Mar 2, 2018 •
edited
Loading

Can we please get this merged?
Just banged my head against a wall for a few hours. I didn't realize "introduced" doesn't mean "implemented". 😄
This feature will make photo grids significantly easier to create.

The docs state 'space-evenly' is an available option.
https://facebook.github.io/react-native/docs/flexbox.html#justify-content
2018-03-02_12h40_45

@gedeagas
Copy link
Contributor Author

gedeagas commented Mar 3, 2018

Hi, @GollyJer this feature is fully supported for react-native 0.54 above.

The docs that live right now is for react-native version 0.54. Sadly if you use react-native version 0.53 you will not be able to use this feature hence the docs for 0.53 are not stating space-evenly (https://facebook.github.io/react-native/docs/0.53/flexbox.html).

if you have a problem using this on react-native version 0.54 please feel free to ask me.

@turnrye
Copy link
Contributor

turnrye commented Mar 4, 2018 •
edited
Loading

@GollyJer sorry for the confusion -- working to update the 0.52 changelog to clarify.

aleclarson pushed a commit to ptmt/react-native-macos that referenced this pull request Feb 4, 2019
@gedeagas @aleclarson
Implementing space-evenly
91d566d 
Summary:
So in v0.52.0 space-evenly is introduced but not yet implemented (1050e0b by woehrl01). This pull request implements the space-evenly.

Manual Testing.
![notes marker](https://i.imgur.com/IXmezVY.png)

[IOS] [FEATURE] [Yoga] Adding space-evenly on justify-content in iOS
[ANDROID] [FEATURE] [Yoga] - Adding space-evenly on justify-content in Android
Closes facebook/react-native#17805

Differential Revision: D6858294

Pulled By: shergin

fbshipit-source-id: 7a705ca05f58603ef4588e1bfd16c16a78f8a390
aleclarson pushed a commit to aleclarson/react-native-macos that referenced this pull request Feb 4, 2019
@gedeagas @aleclarson
Implementing space-evenly
3336ce1 
Summary:
So in v0.52.0 space-evenly is introduced but not yet implemented (1050e0b by woehrl01). This pull request implements the space-evenly.

Manual Testing.
![notes marker](https://i.imgur.com/IXmezVY.png)

[IOS] [FEATURE] [Yoga] Adding space-evenly on justify-content in iOS
[ANDROID] [FEATURE] [Yoga] - Adding space-evenly on justify-content in Android
Closes facebook/react-native#17805

Differential Revision: D6858294

Pulled By: shergin

fbshipit-source-id: 7a705ca05f58603ef4588e1bfd16c16a78f8a390
facebook-github-bot pushed a commit that referenced this pull request Feb 12, 2020
@gaearon @facebook-github-bot
React Native sync for revisions 19f6fe1...241c446
aa41fd5 
Summary:
This sync includes the following changes:
- **[57333ca33](facebook/react@57333ca33 )**: Show first component stack in context warning (#17922) //<Dan Abramov>//
- **[cf0081263](facebook/react@cf0081263 )**: Upgrade to jest 25 (#17896) //<Simen Bekkhus>//
- **[6faf6f5eb](facebook/react@6faf6f5eb )**: Update to flow 0.97 (#17892) //<Nicolas Gallagher>//
- **[81e30c7ff](facebook/react@81e30c7ff )**: Remove unused modules from legacy event responders (#17907) //<Nicolas Gallagher>//
- **[3c713d513](facebook/react@3c713d513 )**: chore: update to latest release of babel (#17897) //<Simen Bekkhus>//
- **[3b3decf87](facebook/react@3b3decf87 )**: add warning when owner and self are different for string refs (#17864) //<Luna Ruan>//
- **[6c00c5bba](facebook/react@6c00c5bba )**: Update to flow-bin@0.89 (#17842) //<Nicolas Gallagher>//
- **[cf7a0c24d](facebook/react@cf7a0c24d )**: Remove dynamic GKs for selective/train (#17888) //<Sebastian Markbåge>//
- **[c322f5913](facebook/react@c322f5913 )**: Add unstable_renderSubtreeIntoContainer and unstable_createPortal feature flags (#17880) //<Dominic Gannaway>//
- **[f2fd484af](facebook/react@f2fd484af )**: Add React.createFactory() deprecation warning (#17878) //<Dominic Gannaway>//
- **[0c04acaf8](facebook/react@0c04acaf8 )**: Remove FB specific build (#17875) //<Sebastian Markbåge>//
- **[9fd760ce7](facebook/react@9fd760ce7 )**: Add disable <textarea/> children flag (#17874) //<Dominic Gannaway>//
- **[a209a97ed](facebook/react@a209a97ed )**: Add feature flag around React.createFactory (#17873) //<Dominic Gannaway>//
- **[95bd7aad7](facebook/react@95bd7aad7 )**: Remove renderPhaseUpdates Map (#17625) //<Andrew Clark>//
- **[b43b36dd9](facebook/react@b43b36dd9 )**: Remove ReactInstanceMap_DO_NOT_USE shim (#17861) //<Dominic Gannaway>//
- **[9e075d16b](facebook/react@9e075d16b )**: [react-interactions] Remove deprecated Scope APIs + update Focus components/docs (#17859) //<Dominic Gannaway>//
- **[b6173e6](facebook/react@b6173e643 )**: [react-interactions] Add DO_NOT_USE to Scope methods (#17835) //<Dominic Gannaway>//
- **[f4ca909e0](facebook/react@f4ca909e0 )**: react-refresh@0.7.2 //<Dan>//
- **[255d9ac5f](facebook/react@255d9ac5f )**: [Fresh] Fix edge case with early function call (#17824) //<Dan Abramov>//
- **[d8570ec6e](facebook/react@d8570ec6e )**: Create ReactFabric.stopSurface and use that for bridgeless mode binding (#16164) //<Emily>//
- **[5d6129b5d](facebook/react@5d6129b5d )**: Update ReactSuspenseList-test.internal.js (#17034) //<Ganapati V S>//
- **[3ac81a57f](facebook/react@3ac81a57f )**: Update create-react-app note for eslint-plugin-react-hooks (#16982) //<Tao>//
- **[e70672149](facebook/react@e70672149 )**: Update Flow to 0.84 (#17805) //<Dan Abramov>//
- **[b979db4e7](facebook/react@b979db4e7 )**: Bump Prettier (#17811) //<Dan Abramov>//

Changelog:
[General][Changed] - React Native sync for revisions 19f6fe1...241c446

Reviewed By: yungsters

Differential Revision: D19623180

fbshipit-source-id: 3cdecb33aa66dfc21a2b347bf7f63a5b27fcf6ea
osdnk pushed a commit to osdnk/react-native that referenced this pull request Mar 9, 2020
@gaearon @osdnk
React Native sync for revisions 19f6fe1...241c446
a330aa1 
Summary:
This sync includes the following changes:
- **[57333ca33](facebook/react@57333ca33 )**: Show first component stack in context warning (facebook#17922) //<Dan Abramov>//
- **[cf0081263](facebook/react@cf0081263 )**: Upgrade to jest 25 (facebook#17896) //<Simen Bekkhus>//
- **[6faf6f5eb](facebook/react@6faf6f5eb )**: Update to flow 0.97 (facebook#17892) //<Nicolas Gallagher>//
- **[81e30c7ff](facebook/react@81e30c7ff )**: Remove unused modules from legacy event responders (facebook#17907) //<Nicolas Gallagher>//
- **[3c713d513](facebook/react@3c713d513 )**: chore: update to latest release of babel (facebook#17897) //<Simen Bekkhus>//
- **[3b3decf87](facebook/react@3b3decf87 )**: add warning when owner and self are different for string refs (facebook#17864) //<Luna Ruan>//
- **[6c00c5bba](facebook/react@6c00c5bba )**: Update to flow-bin@0.89 (facebook#17842) //<Nicolas Gallagher>//
- **[cf7a0c24d](facebook/react@cf7a0c24d )**: Remove dynamic GKs for selective/train (facebook#17888) //<Sebastian Markbåge>//
- **[c322f5913](facebook/react@c322f5913 )**: Add unstable_renderSubtreeIntoContainer and unstable_createPortal feature flags (facebook#17880) //<Dominic Gannaway>//
- **[f2fd484af](facebook/react@f2fd484af )**: Add React.createFactory() deprecation warning (facebook#17878) //<Dominic Gannaway>//
- **[0c04acaf8](facebook/react@0c04acaf8 )**: Remove FB specific build (facebook#17875) //<Sebastian Markbåge>//
- **[9fd760ce7](facebook/react@9fd760ce7 )**: Add disable <textarea/> children flag (facebook#17874) //<Dominic Gannaway>//
- **[a209a97ed](facebook/react@a209a97ed )**: Add feature flag around React.createFactory (facebook#17873) //<Dominic Gannaway>//
- **[95bd7aad7](facebook/react@95bd7aad7 )**: Remove renderPhaseUpdates Map (facebook#17625) //<Andrew Clark>//
- **[b43b36dd9](facebook/react@b43b36dd9 )**: Remove ReactInstanceMap_DO_NOT_USE shim (facebook#17861) //<Dominic Gannaway>//
- **[9e075d16b](facebook/react@9e075d16b )**: [react-interactions] Remove deprecated Scope APIs + update Focus components/docs (facebook#17859) //<Dominic Gannaway>//
- **[b6173e6](facebook/react@b6173e643 )**: [react-interactions] Add DO_NOT_USE to Scope methods (facebook#17835) //<Dominic Gannaway>//
- **[f4ca909e0](facebook/react@f4ca909e0 )**: react-refresh@0.7.2 //<Dan>//
- **[255d9ac5f](facebook/react@255d9ac5f )**: [Fresh] Fix edge case with early function call (facebook#17824) //<Dan Abramov>//
- **[d8570ec6e](facebook/react@d8570ec6e )**: Create ReactFabric.stopSurface and use that for bridgeless mode binding (facebook#16164) //<Emily>//
- **[5d6129b5d](facebook/react@5d6129b5d )**: Update ReactSuspenseList-test.internal.js (facebook#17034) //<Ganapati V S>//
- **[3ac81a57f](facebook/react@3ac81a57f )**: Update create-react-app note for eslint-plugin-react-hooks (facebook#16982) //<Tao>//
- **[e70672149](facebook/react@e70672149 )**: Update Flow to 0.84 (facebook#17805) //<Dan Abramov>//
- **[b979db4e7](facebook/react@b979db4e7 )**: Bump Prettier (facebook#17811) //<Dan Abramov>//

Changelog:
[General][Changed] - React Native sync for revisions 19f6fe1...241c446

Reviewed By: yungsters

Differential Revision: D19623180

fbshipit-source-id: 3cdecb33aa66dfc21a2b347bf7f63a5b27fcf6ea
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

@shergin shergin Awaiting requested review from shergin

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gedeagas @pull-bot @shergin @mizinin @GollyJer @turnrye @facebook-github-bot