[Circle] Update build-js-bundle run step #17824
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always build the JavaScript bundle, to ensure failures here are surfaced regardless of failures that may happen earlier in this workflow
facebook-github-bot
added
CLA Signed
facebook-github-bot
approved these changes
Feb 1, 2018
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Plo4ox
pushed a commit
to Plo4ox/react-native
that referenced
this pull request
Feb 17, 2018
Summary: Always build the JavaScript bundle, to ensure failures here are surfaced regardless of failures that may happen earlier in this workflow Closes facebook#17824 Differential Revision: D6872794 Pulled By: hramos fbshipit-source-id: bab3b9cfa6cecb578e9a3cffae27e1ce355588d2
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 12, 2020
Summary: This sync includes the following changes: - **[57333ca33](facebook/react@57333ca33 )**: Show first component stack in context warning (#17922) //<Dan Abramov>// - **[cf0081263](facebook/react@cf0081263 )**: Upgrade to jest 25 (#17896) //<Simen Bekkhus>// - **[6faf6f5eb](facebook/react@6faf6f5eb )**: Update to flow 0.97 (#17892) //<Nicolas Gallagher>// - **[81e30c7ff](facebook/react@81e30c7ff )**: Remove unused modules from legacy event responders (#17907) //<Nicolas Gallagher>// - **[3c713d513](facebook/react@3c713d513 )**: chore: update to latest release of babel (#17897) //<Simen Bekkhus>// - **[3b3decf87](facebook/react@3b3decf87 )**: add warning when owner and self are different for string refs (#17864) //<Luna Ruan>// - **[6c00c5bba](facebook/react@6c00c5bba )**: Update to flow-bin@0.89 (#17842) //<Nicolas Gallagher>// - **[cf7a0c24d](facebook/react@cf7a0c24d )**: Remove dynamic GKs for selective/train (#17888) //<Sebastian Markbåge>// - **[c322f5913](facebook/react@c322f5913 )**: Add unstable_renderSubtreeIntoContainer and unstable_createPortal feature flags (#17880) //<Dominic Gannaway>// - **[f2fd484af](facebook/react@f2fd484af )**: Add React.createFactory() deprecation warning (#17878) //<Dominic Gannaway>// - **[0c04acaf8](facebook/react@0c04acaf8 )**: Remove FB specific build (#17875) //<Sebastian Markbåge>// - **[9fd760ce7](facebook/react@9fd760ce7 )**: Add disable <textarea/> children flag (#17874) //<Dominic Gannaway>// - **[a209a97ed](facebook/react@a209a97ed )**: Add feature flag around React.createFactory (#17873) //<Dominic Gannaway>// - **[95bd7aad7](facebook/react@95bd7aad7 )**: Remove renderPhaseUpdates Map (#17625) //<Andrew Clark>// - **[b43b36dd9](facebook/react@b43b36dd9 )**: Remove ReactInstanceMap_DO_NOT_USE shim (#17861) //<Dominic Gannaway>// - **[9e075d16b](facebook/react@9e075d16b )**: [react-interactions] Remove deprecated Scope APIs + update Focus components/docs (#17859) //<Dominic Gannaway>// - **[b6173e6](facebook/react@b6173e643 )**: [react-interactions] Add DO_NOT_USE to Scope methods (#17835) //<Dominic Gannaway>// - **[f4ca909e0](facebook/react@f4ca909e0 )**: react-refresh@0.7.2 //<Dan>// - **[255d9ac5f](facebook/react@255d9ac5f )**: [Fresh] Fix edge case with early function call (#17824) //<Dan Abramov>// - **[d8570ec6e](facebook/react@d8570ec6e )**: Create ReactFabric.stopSurface and use that for bridgeless mode binding (#16164) //<Emily>// - **[5d6129b5d](facebook/react@5d6129b5d )**: Update ReactSuspenseList-test.internal.js (#17034) //<Ganapati V S>// - **[3ac81a57f](facebook/react@3ac81a57f )**: Update create-react-app note for eslint-plugin-react-hooks (#16982) //<Tao>// - **[e70672149](facebook/react@e70672149 )**: Update Flow to 0.84 (#17805) //<Dan Abramov>// - **[b979db4e7](facebook/react@b979db4e7 )**: Bump Prettier (#17811) //<Dan Abramov>// Changelog: [General][Changed] - React Native sync for revisions 19f6fe1...241c446 Reviewed By: yungsters Differential Revision: D19623180 fbshipit-source-id: 3cdecb33aa66dfc21a2b347bf7f63a5b27fcf6ea
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: This sync includes the following changes: - **[57333ca33](facebook/react@57333ca33 )**: Show first component stack in context warning (facebook#17922) //<Dan Abramov>// - **[cf0081263](facebook/react@cf0081263 )**: Upgrade to jest 25 (facebook#17896) //<Simen Bekkhus>// - **[6faf6f5eb](facebook/react@6faf6f5eb )**: Update to flow 0.97 (facebook#17892) //<Nicolas Gallagher>// - **[81e30c7ff](facebook/react@81e30c7ff )**: Remove unused modules from legacy event responders (facebook#17907) //<Nicolas Gallagher>// - **[3c713d513](facebook/react@3c713d513 )**: chore: update to latest release of babel (facebook#17897) //<Simen Bekkhus>// - **[3b3decf87](facebook/react@3b3decf87 )**: add warning when owner and self are different for string refs (facebook#17864) //<Luna Ruan>// - **[6c00c5bba](facebook/react@6c00c5bba )**: Update to flow-bin@0.89 (facebook#17842) //<Nicolas Gallagher>// - **[cf7a0c24d](facebook/react@cf7a0c24d )**: Remove dynamic GKs for selective/train (facebook#17888) //<Sebastian Markbåge>// - **[c322f5913](facebook/react@c322f5913 )**: Add unstable_renderSubtreeIntoContainer and unstable_createPortal feature flags (facebook#17880) //<Dominic Gannaway>// - **[f2fd484af](facebook/react@f2fd484af )**: Add React.createFactory() deprecation warning (facebook#17878) //<Dominic Gannaway>// - **[0c04acaf8](facebook/react@0c04acaf8 )**: Remove FB specific build (facebook#17875) //<Sebastian Markbåge>// - **[9fd760ce7](facebook/react@9fd760ce7 )**: Add disable <textarea/> children flag (facebook#17874) //<Dominic Gannaway>// - **[a209a97ed](facebook/react@a209a97ed )**: Add feature flag around React.createFactory (facebook#17873) //<Dominic Gannaway>// - **[95bd7aad7](facebook/react@95bd7aad7 )**: Remove renderPhaseUpdates Map (facebook#17625) //<Andrew Clark>// - **[b43b36dd9](facebook/react@b43b36dd9 )**: Remove ReactInstanceMap_DO_NOT_USE shim (facebook#17861) //<Dominic Gannaway>// - **[9e075d16b](facebook/react@9e075d16b )**: [react-interactions] Remove deprecated Scope APIs + update Focus components/docs (facebook#17859) //<Dominic Gannaway>// - **[b6173e6](facebook/react@b6173e643 )**: [react-interactions] Add DO_NOT_USE to Scope methods (facebook#17835) //<Dominic Gannaway>// - **[f4ca909e0](facebook/react@f4ca909e0 )**: react-refresh@0.7.2 //<Dan>// - **[255d9ac5f](facebook/react@255d9ac5f )**: [Fresh] Fix edge case with early function call (facebook#17824) //<Dan Abramov>// - **[d8570ec6e](facebook/react@d8570ec6e )**: Create ReactFabric.stopSurface and use that for bridgeless mode binding (facebook#16164) //<Emily>// - **[5d6129b5d](facebook/react@5d6129b5d )**: Update ReactSuspenseList-test.internal.js (facebook#17034) //<Ganapati V S>// - **[3ac81a57f](facebook/react@3ac81a57f )**: Update create-react-app note for eslint-plugin-react-hooks (facebook#16982) //<Tao>// - **[e70672149](facebook/react@e70672149 )**: Update Flow to 0.84 (facebook#17805) //<Dan Abramov>// - **[b979db4e7](facebook/react@b979db4e7 )**: Bump Prettier (facebook#17811) //<Dan Abramov>// Changelog: [General][Changed] - React Native sync for revisions 19f6fe1...241c446 Reviewed By: yungsters Differential Revision: D19623180 fbshipit-source-id: 3cdecb33aa66dfc21a2b347bf7f63a5b27fcf6ea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always build the JavaScript bundle, to ensure failures here are surfaced regardless of failures that may happen earlier in this workflow