Give RNPM the ability to look for plugins in @scoped modules
#21082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Good catch! I like that PR. |
|
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 13, 2018
There was a problem hiding this comment.
grabbou is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
gengjiawen
pushed a commit
to gengjiawen/react-native
that referenced
this pull request
Sep 14, 2018
…ook#21082) Summary: This PR gives RNPM the ability to look for plugins in `scoped` modules. The regexes for finding RNPM plugins will match these hypothetical examples: * `rnpm-plugin-foo` * `org/rnpm-plugin-foo` The regexes for finding React Native plugins will match these hypothetical examples: * `react-native-foo` * `org/react-native-foo` * `The controller you requested could not be found./module` (will be useful in the slimmening) * `The controller you requested could not be found./module` RNPM plugins will be able to benefit from this immediately, but React Native plugins will run into this Metro issue currently: facebook/metro#241 Pull Request resolved: facebook#21082 Differential Revision: D9809094 Pulled By: hramos fbshipit-source-id: 4b0694ad4119b37dd5664af52c48e48ebe4d7404
kelset
pushed a commit
that referenced
this pull request
Sep 21, 2018
Summary: This PR gives RNPM the ability to look for plugins in `scoped` modules. The regexes for finding RNPM plugins will match these hypothetical examples: * `rnpm-plugin-foo` * `org/rnpm-plugin-foo` The regexes for finding React Native plugins will match these hypothetical examples: * `react-native-foo` * `org/react-native-foo` * `The controller you requested could not be found./module` (will be useful in the slimmening) * `The controller you requested could not be found./module` RNPM plugins will be able to benefit from this immediately, but React Native plugins will run into this Metro issue currently: facebook/metro#241 Pull Request resolved: #21082 Differential Revision: D9809094 Pulled By: hramos fbshipit-source-id: 4b0694ad4119b37dd5664af52c48e48ebe4d7404
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: This PR gives RNPM the ability to look for plugins in `scoped` modules. The regexes for finding RNPM plugins will match these hypothetical examples: * `rnpm-plugin-foo` * `org/rnpm-plugin-foo` The regexes for finding React Native plugins will match these hypothetical examples: * `react-native-foo` * `org/react-native-foo` * `The controller you requested could not be found./module` (will be useful in the slimmening) * `The controller you requested could not be found./module` RNPM plugins will be able to benefit from this immediately, but React Native plugins will run into this Metro issue currently: facebook/metro#241 Pull Request resolved: facebook/react-native#21082 Differential Revision: D9809094 Pulled By: hramos fbshipit-source-id: 4b0694ad4119b37dd5664af52c48e48ebe4d7404
react-native-bot
removed
the
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
…ook#21082) Summary: This PR gives RNPM the ability to look for plugins in `scoped` modules. The regexes for finding RNPM plugins will match these hypothetical examples: * `rnpm-plugin-foo` * `org/rnpm-plugin-foo` The regexes for finding React Native plugins will match these hypothetical examples: * `react-native-foo` * `org/react-native-foo` * `The controller you requested could not be found./module` (will be useful in the slimmening) * `The controller you requested could not be found./module` RNPM plugins will be able to benefit from this immediately, but React Native plugins will run into this Metro issue currently: facebook/metro#241 Pull Request resolved: facebook#21082 Differential Revision: D9809094 Pulled By: hramos fbshipit-source-id: 4b0694ad4119b37dd5664af52c48e48ebe4d7404
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 6, 2021
Summary: This sync includes the following changes: - **[c9aab1c9d](facebook/react@c9aab1c9d )**: react-refresh@0.10.0 //<Dan Abramov>// - **[516b76b9a](facebook/react@516b76b9a )**: [Fast Refresh] Support callthrough HOCs ([#21104](facebook/react#21104)) //<Dan Abramov>// - **[0853aab74](facebook/react@0853aab74 )**: Log all errors to console.error by default ([#21130](facebook/react#21130)) //<Sebastian Markbåge>// - **[d1294c9d4](facebook/react@d1294c9d4 )**: Add global onError handler ([#21129](facebook/react#21129)) //<Sebastian Markbåge>// - **[64983aab5](facebook/react@64983aab5 )**: Remove redundant setUpdatePriority call ([#21127](facebook/react#21127)) //<Andrew Clark>// - **[634cc52e6](facebook/react@634cc52e6 )**: Delete dead variable: currentEventWipLanes ([#21123](facebook/react#21123)) //<Andrew Clark>// - **[1102224bb](facebook/react@1102224bb )**: Fix: flushSync changes priority inside effect ([#21122](facebook/react#21122)) //<Andrew Clark>// - **[dbe98a5aa](facebook/react@dbe98a5aa )**: Move sync task queue to its own module ([#21109](facebook/react#21109)) //<Andrew Clark>// - **[3ba5c8737](facebook/react@3ba5c8737 )**: Remove Scheduler indirection ([#21107](facebook/react#21107)) //<Andrew Clark>// - **[46b68eaf6](facebook/react@46b68eaf6 )**: Delete LanePriority type ([#21090](facebook/react#21090)) //<Andrew Clark>// - **[dcd13045e](facebook/react@dcd13045e )**: Use Lane to track root callback priority ([#21089](facebook/react#21089)) //<Andrew Clark>// - **[5f21a9fca](facebook/react@5f21a9fca )**: Clean up host pointers in level 2 of clean-up flag ([#21112](facebook/react#21112)) //<Andrew Clark>// - **[32d6f39ed](facebook/react@32d6f39ed )**: [Fizz] Support special HTML/SVG/MathML tags to suspend ([#21113](facebook/react#21113)) //<Sebastian Markbåge>// - **[a77dd13ed](facebook/react@a77dd13ed )**: Delete enableDiscreteEventFlushingChange ([#21110](facebook/react#21110)) //<Andrew Clark>// - **[048ee4c0c](facebook/react@048ee4c0c )**: Use `act` in fuzz tester to flush expired work ([#21108](facebook/react#21108)) //<Andrew Clark>// - **[556644e23](facebook/react@556644e23 )**: Fix plurals ([#21106](facebook/react#21106)) //<Sebastian Markbåge>// - **[8b741437b](facebook/react@8b741437b )**: Rename SuspendedWork to Task ([#21105](facebook/react#21105)) //<Sebastian Markbåge>// - **[38a1aedb4](facebook/react@38a1aedb4 )**: [Fizz] Add FormatContext and Refactor Work ([#21103](facebook/react#21103)) //<Sebastian Markbåge>// - **[1b7e471b9](facebook/react@1b7e471b9 )**: React Native New Architecture: Support passing nativeViewTag to getInspectorDataForViewAtPoint callback, for React DevTools compat ([#21080](facebook/react#21080)) //<Joshua Gross>// - **[4a99c5c3a](facebook/react@4a99c5c3a )**: Use highest priority lane to detect interruptions ([#21088](facebook/react#21088)) //<Andrew Clark>// - **[77be52729](facebook/react@77be52729 )**: Remove LanePriority from computeExpirationTime ([#21087](facebook/react#21087)) //<Andrew Clark>// - **[3221e8fba](facebook/react@3221e8fba )**: Remove LanePriority from getBumpedLaneForHydration ([#21086](facebook/react#21086)) //<Andrew Clark>// - **[05ec0d764](facebook/react@05ec0d764 )**: Entangled expired lanes with SyncLane ([#21083](facebook/react#21083)) //<Andrew Clark>// - **[03ede83d2](facebook/react@03ede83d2 )**: Use EventPriority to track update priority ([#21082](facebook/react#21082)) //<Andrew Clark>// - **[a63f0953b](facebook/react@a63f0953b )**: Delete SyncBatchedLane ([#21061](facebook/react#21061)) //<Ricky>// - **[fa868d6be](facebook/react@fa868d6be )**: Make opaque EventPriority type a Lane internally ([#21065](facebook/react#21065)) //<Andrew Clark>// - **[eb58c3909](facebook/react@eb58c3909 )**: react-hooks/exhaustive-deps: Handle optional chained methods as dependency ([#20204](facebook/react#20204)) ([#20247](facebook/react#20247)) //<Ari Perkkiö>// - **[7b84dbd16](facebook/react@7b84dbd16 )**: Fail build on deep requires in npm packages ([#21063](facebook/react#21063)) //<Dan Abramov>// - **[2c9d8efc8](facebook/react@2c9d8efc8 )**: Add react-reconciler/constants entry point ([#21062](facebook/react#21062)) //<Dan Abramov>// - **[d0eaf7829](facebook/react@d0eaf7829 )**: Move priorities to separate import to break cycle ([#21060](facebook/react#21060)) //<Andrew Clark>// - **[435cff986](facebook/react@435cff986 )**: [Fizz] Expose callbacks in options for when various stages of the content is done ([#21056](facebook/react#21056)) //<Sebastian Markbåge>// - **[25bfa287f](facebook/react@25bfa287f )**: [Experiment] Add feature flag for more aggressive memory clean-up of deleted fiber trees ([#21039](facebook/react#21039)) //<Benoit Girard>// - **[8fe7810e7](facebook/react@8fe7810e7 )**: Remove already completed comment ([#21054](facebook/react#21054)) //<Sebastian Markbåge>// - **[6c3202b1e](facebook/react@6c3202b1e )**: [Fizz] Use identifierPrefix to avoid conflicts within the same response ([#21037](facebook/react#21037)) //<Sebastian Markbåge>// - **[dcdf8de7e](facebook/react@dcdf8de7e )**: Remove discrete lanes and priorities ([#21040](facebook/react#21040)) //<Andrew Clark>// - **[ca99ae97b](facebook/react@ca99ae97b )**: Replace some flushExpired callsites ([#20975](facebook/react#20975)) //<Ricky>// - **[1fafac002](facebook/react@1fafac002 )**: Use SyncLane for discrete event hydration ([#21038](facebook/react#21038)) //<Andrew Clark>// Changelog: [General][Changed] - React Native sync for revisions 6d3ecb7...c9aab1c jest_e2e[run_all_tests] Reviewed By: JoshuaGross Differential Revision: D27436763 fbshipit-source-id: da79a41e26bffdcdacd293178062edf098e9b58a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives RNPM the ability to look for plugins in
@scopedmodules.The regexes for finding RNPM plugins will match these hypothetical examples:
rnpm-plugin-foo@org/rnpm-plugin-fooThe regexes for finding React Native plugins will match these hypothetical examples:
react-native-foo@org/react-native-foo@react-native/module(will be useful in the slimmening)@react-native-foo/moduleRNPM plugins will be able to benefit from this immediately, but React Native plugins will run into this Metro issue currently:
facebook/metro#241
Test Plan:
Test cases have been added to
findPlugins.spec.js.Release Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
[CLI] [ENHANCEMENT] [local-cli/core/tests/findPlugins.spec.js] - Tests for scoped modules have been added
[CLI] [ENHANCEMENT] [local-cli/core/findPlugins.js] -
isRNPMPlugin()andisReactNativePlugin()have been updated to check a package name against an array of regexes, rather than simply checking for a prefix[CLI] [ENHANCEMENT] [local-cli/core/index.js] - Fixed
getProjectCommands()to be able to handle scoped modules