Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back temporary experimental_ aliases for Server Actions APIs #27461

Merged

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Oct 4, 2023

This adds back the experimental_-prefixed Server Actions APIs to the experimental builds only, so that apps that use those don't immediately break when upgrading. The APIs will log a warning to encourage people to move to the unprefixed version, or to switch to the canary release channel.

We can remove these in a few weeks after we've given people a chance to upgrade.

This does not affect the canary builds at all, since they never had the prefixed versions to begin with.

This adds back the `experimental_`-prefixed Server Actions APIs to
the experimental builds only, so that apps that use those don't
immediately break when upgrading. The APIs will log a warning to
encourage people to move to the unprefixed version, or to switch to
the canary release channel.

We can remove these in a few weeks after we've given people a chance
to upgrade.

This does not affect the canary builds at all, since they never had
the prefixed versions to begin with.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 4, 2023
@acdlite acdlite changed the title Add back temporary experimental_ alias Add back temporary experimental_ aliases for Server Actions APIs Oct 4, 2023
@react-sizebot
Copy link

Comparing: 44d40a0...ee9d1e7

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 174.46 kB 174.46 kB = 54.27 kB 54.27 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.08% 176.16 kB 176.31 kB +0.08% 54.84 kB 54.88 kB
facebook-www/ReactDOM-prod.classic.js = 564.48 kB 564.48 kB = 99.37 kB 99.37 kB
facebook-www/ReactDOM-prod.modern.js = 548.21 kB 548.21 kB = 96.44 kB 96.44 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react/cjs/react.production.min.js +0.79% 9.25 kB 9.32 kB +0.67% 3.44 kB 3.46 kB
oss-experimental/react/umd/react.profiling.min.js +0.69% 9.20 kB 9.26 kB +0.57% 3.52 kB 3.54 kB
oss-experimental/react/umd/react.production.min.js +0.68% 9.20 kB 9.26 kB +0.60% 3.52 kB 3.54 kB
oss-experimental/react/cjs/react.development.js +0.32% 102.41 kB 102.74 kB +0.31% 27.67 kB 27.76 kB
oss-experimental/react/umd/react.development.js +0.32% 107.23 kB 107.57 kB +0.32% 27.83 kB 27.92 kB

Generated by 🚫 dangerJS against ee9d1e7

@acdlite acdlite merged commit ca237d6 into facebook:main Oct 4, 2023
2 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 4, 2023
…27461)

This adds back the `experimental_`-prefixed Server Actions APIs to the
experimental builds only, so that apps that use those don't immediately
break when upgrading. The APIs will log a warning to encourage people to
move to the unprefixed version, or to switch to the canary release
channel.

We can remove these in a few weeks after we've given people a chance to
upgrade.

This does not affect the canary builds at all, since they never had the
prefixed versions to begin with.

DiffTrain build for [ca237d6](ca237d6)
gnoff added a commit that referenced this pull request Oct 5, 2023
…seFormState` and `useFormStatus` (#27470)

in #27461 the experimental prefix was added back for `useFormState` and
`useFormStatus` in react-dom. However these functions are also exported
from the server rendering stub too and when using the stub with
experimental prefixes their absence causes unexpected errors.

This change adds back the experimental prefix for these two hooks to
match the experimental build of react-dom.
Umeshmalik pushed a commit to Umeshmalik/react that referenced this pull request Oct 8, 2023
…seFormState` and `useFormStatus` (facebook#27470)

in facebook#27461 the experimental prefix was added back for `useFormState` and
`useFormStatus` in react-dom. However these functions are also exported
from the server rendering stub too and when using the stub with
experimental prefixes their absence causes unexpected errors.

This change adds back the experimental prefix for these two hooks to
match the experimental build of react-dom.
Umeshmalik pushed a commit to Umeshmalik/react that referenced this pull request Oct 8, 2023
…acebook#27461)

This adds back the `experimental_`-prefixed Server Actions APIs to the
experimental builds only, so that apps that use those don't immediately
break when upgrading. The APIs will log a warning to encourage people to
move to the unprefixed version, or to switch to the canary release
channel.

We can remove these in a few weeks after we've given people a chance to
upgrade.

This does not affect the canary builds at all, since they never had the
prefixed versions to begin with.
alunyov pushed a commit to alunyov/react that referenced this pull request Oct 11, 2023
…acebook#27461)

This adds back the `experimental_`-prefixed Server Actions APIs to the
experimental builds only, so that apps that use those don't immediately
break when upgrading. The APIs will log a warning to encourage people to
move to the unprefixed version, or to switch to the canary release
channel.

We can remove these in a few weeks after we've given people a chance to
upgrade.

This does not affect the canary builds at all, since they never had the
prefixed versions to begin with.
alunyov pushed a commit to alunyov/react that referenced this pull request Oct 11, 2023
…seFormState` and `useFormStatus` (facebook#27470)

in facebook#27461 the experimental prefix was added back for `useFormState` and
`useFormStatus` in react-dom. However these functions are also exported
from the server rendering stub too and when using the stub with
experimental prefixes their absence causes unexpected errors.

This change adds back the experimental prefix for these two hooks to
match the experimental build of react-dom.
ztanner added a commit to vercel/next.js that referenced this pull request Oct 16, 2023
…experimental prefix for server action APIs (#56809)

The latest React canary builds have a few changes that need to be
adopted for compatability.

1. the `useFormState` and `useFormStatus` hooks in `react-dom` and the
`formData` opiont in `react-dom/server` are no longer prefixed with
`experimental_`
2. server content (an undocumented React feature) has been removed. Next
only had trivial intenral use of this API and did not expose a coherent
feature to Next users (no ability to seed context on refetches). It is
still possible that some users used the React server context APIs which
is why this should go into Next 14.

### React upstream changes

- facebook/react#27513
- facebook/react#27514
- facebook/react#27511
- facebook/react#27508
- facebook/react#27502
- facebook/react#27474
- facebook/react#26789
- facebook/react#27500
- facebook/react#27488
- facebook/react#27458
- facebook/react#27471
- facebook/react#27470
- facebook/react#27464
- facebook/react#27456
- facebook/react#27462
- facebook/react#27461
- facebook/react#27460
- facebook/react#27459
- facebook/react#27454
- facebook/react#27457
- facebook/react#27453
- facebook/react#27401
- facebook/react#27443
- facebook/react#27445
- facebook/react#27364
- facebook/react#27440
- facebook/react#27436

---------

Co-authored-by: Zack Tanner <zacktanner@gmail.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: Jiachi Liu <inbox@huozhi.im>
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…acebook#27461)

This adds back the `experimental_`-prefixed Server Actions APIs to the
experimental builds only, so that apps that use those don't immediately
break when upgrading. The APIs will log a warning to encourage people to
move to the unprefixed version, or to switch to the canary release
channel.

We can remove these in a few weeks after we've given people a chance to
upgrade.

This does not affect the canary builds at all, since they never had the
prefixed versions to begin with.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…seFormState` and `useFormStatus` (facebook#27470)

in facebook#27461 the experimental prefix was added back for `useFormState` and
`useFormStatus` in react-dom. However these functions are also exported
from the server rendering stub too and when using the stub with
experimental prefixes their absence causes unexpected errors.

This change adds back the experimental prefix for these two hooks to
match the experimental build of react-dom.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
…27461)

This adds back the `experimental_`-prefixed Server Actions APIs to the
experimental builds only, so that apps that use those don't immediately
break when upgrading. The APIs will log a warning to encourage people to
move to the unprefixed version, or to switch to the canary release
channel.

We can remove these in a few weeks after we've given people a chance to
upgrade.

This does not affect the canary builds at all, since they never had the
prefixed versions to begin with.

DiffTrain build for commit ca237d6.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
…seFormState` and `useFormStatus` (#27470)

in #27461 the experimental prefix was added back for `useFormState` and
`useFormStatus` in react-dom. However these functions are also exported
from the server rendering stub too and when using the stub with
experimental prefixes their absence causes unexpected errors.

This change adds back the experimental prefix for these two hooks to
match the experimental build of react-dom.

DiffTrain build for commit 546178f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants