Fix Broken Links In Documentation #28321

justindhillon · 2024-02-13T21:32:40Z

Summary

I used link-inspector to find a bunch of broken links in this projects documentation. Here is what I fixed:

https://www.html5rocks.com/en/tutorials/canvas/hidpi/ --> https://web.dev/articles/canvas-hidipi

https://w3c.github.io/webcomponents/spec/custom/#custom-elements-core-concepts --> https://www.w3.org/TR/custom-elements/

https://github.com/facebookarchive/fixed-data-table/blob/main/src/vendor_upstream/dom/normalizeWheel.js --> https://github.com/facebookarchive/fixed-data-table/blob/master/src/vendor_upstream/dom/normalizeWheel.js

https://upload.wikimedia.org/wikipedia/commons/e/ee/Atom_%282%29.png --> https://upload.wikimedia.org/wikipedia/commons/1/1b/Atom.png

Support my work

I used link-inspector to find and fix this issue. If you find this PR useful, give the repo a ⭐

…endor_upstream/dom/normalizeWheel.js

…ReactCacheOld.js

facebook-github-bot · 2024-02-13T21:32:46Z

Hi @justindhillon!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

react-sizebot · 2024-02-13T21:37:13Z

Comparing: 01ab35a...2a822b2

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.89 kB	176.89 kB	=	55.14 kB	55.14 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	179.00 kB	179.00 kB	=	55.80 kB	55.80 kB
facebook-www/ReactDOM-prod.classic.js	=	594.04 kB	594.04 kB	=	104.94 kB	104.94 kB
facebook-www/ReactDOM-prod.modern.js	=	577.33 kB	577.33 kB	=	101.96 kB	101.96 kB
test_utils/ReactAllWarnings.js	Deleted	66.40 kB	0.00 kB	Deleted	16.26 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	66.40 kB	0.00 kB	Deleted	16.26 kB	0.00 kB

Generated by 🚫 dangerJS against 2a822b2

facebook-github-bot · 2024-02-13T22:14:14Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

rickhanlonii · 2024-02-20T19:41:35Z

Is this all of them? I'd like to land all the fixes at once instead of over multiple PRs.

justindhillon · 2024-02-21T05:56:33Z

Yes @rickhanlonii , this is all of them!

rickhanlonii · 2024-02-23T05:16:56Z

packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js

@@ -3698,7 +3698,7 @@ export function pushStartInstance(
      return pushSelfClosing(target, props, type);
    }
    // These are reserved SVG and MathML elements, that are never custom elements.
-    // https://w3c.github.io/webcomponents/spec/custom/#custom-elements-core-concepts
+    // https://www.w3.org/TR/custom-elements/


I think this is the right link: https://html.spec.whatwg.org/multipage/custom-elements.html#custom-elements-core-concepts

Same below

Thanks for the feedback! It has been updated with new link.

…ements-core-concepts

rickhanlonii · 2024-03-03T22:44:32Z

Thanks!

## Summary I used [link-inspector](https://github.com/justindhillon/link-inspector) to find a bunch of broken links in this projects documentation. Here is what I fixed: https://www.html5rocks.com/en/tutorials/canvas/hidpi/ --> https://web.dev/articles/canvas-hidipi https://w3c.github.io/webcomponents/spec/custom/#custom-elements-core-concepts --> https://www.w3.org/TR/custom-elements/ https://github.com/facebookarchive/fixed-data-table/blob/main/src/vendor_upstream/dom/normalizeWheel.js --> https://github.com/facebookarchive/fixed-data-table/blob/master/src/vendor_upstream/dom/normalizeWheel.js https://upload.wikimedia.org/wikipedia/commons/e/ee/Atom_%282%29.png --> https://upload.wikimedia.org/wikipedia/commons/1/1b/Atom.png ## Support my work I used [link-inspector](https://github.com/justindhillon/link-inspector) to find and fix this issue. If you find this PR useful, give the repo a :star: DiffTrain build for [034130c](034130c)

* feat[devtools]: symbolicate source for inspected element ([hoxyq](https://github.com/hoxyq) in [#28471](#28471)) * refactor[devtools]: lazily define source for fiber based on component stacks ([hoxyq](https://github.com/hoxyq) in [#28351](#28351)) * fix[devtools/tree/element]: onClick -> onMouseDown to handle first click correctly ([hoxyq](https://github.com/hoxyq) in [#28486](#28486)) * [DOM] disable legacy mode behind flag ([gnoff](https://github.com/gnoff) in [#28468](#28468)) * Fix Broken Links In Documentation ([justindhillon](https://github.com/justindhillon) in [#28321](#28321)) * Update /link URLs to react.dev ([rickhanlonii](https://github.com/rickhanlonii) in [#28477](#28477)) * [tests] add support for @GATE pragma ([gnoff](https://github.com/gnoff) in [#28479](#28479)) * Devtools: Unwrap Promise in useFormState ([eps1lon](https://github.com/eps1lon) in [#28319](#28319)) * Add support for rendering BigInt ([eps1lon](https://github.com/eps1lon) in [#24580](#24580)) * Include server component names in the componentStack in DEV ([sebmarkbage](https://github.com/sebmarkbage) in [#28415](#28415))

## Summary I used [link-inspector](https://github.com/justindhillon/link-inspector) to find a bunch of broken links in this projects documentation. Here is what I fixed: https://www.html5rocks.com/en/tutorials/canvas/hidpi/ --> https://web.dev/articles/canvas-hidipi https://w3c.github.io/webcomponents/spec/custom/#custom-elements-core-concepts --> https://www.w3.org/TR/custom-elements/ https://github.com/facebookarchive/fixed-data-table/blob/main/src/vendor_upstream/dom/normalizeWheel.js --> https://github.com/facebookarchive/fixed-data-table/blob/master/src/vendor_upstream/dom/normalizeWheel.js https://upload.wikimedia.org/wikipedia/commons/e/ee/Atom_%282%29.png --> https://upload.wikimedia.org/wikipedia/commons/1/1b/Atom.png ## Support my work I used [link-inspector](https://github.com/justindhillon/link-inspector) to find and fix this issue. If you find this PR useful, give the repo a :star:

* feat[devtools]: symbolicate source for inspected element ([hoxyq](https://github.com/hoxyq) in [facebook#28471](facebook#28471)) * refactor[devtools]: lazily define source for fiber based on component stacks ([hoxyq](https://github.com/hoxyq) in [facebook#28351](facebook#28351)) * fix[devtools/tree/element]: onClick -> onMouseDown to handle first click correctly ([hoxyq](https://github.com/hoxyq) in [facebook#28486](facebook#28486)) * [DOM] disable legacy mode behind flag ([gnoff](https://github.com/gnoff) in [facebook#28468](facebook#28468)) * Fix Broken Links In Documentation ([justindhillon](https://github.com/justindhillon) in [facebook#28321](facebook#28321)) * Update /link URLs to react.dev ([rickhanlonii](https://github.com/rickhanlonii) in [facebook#28477](facebook#28477)) * [tests] add support for @GATE pragma ([gnoff](https://github.com/gnoff) in [facebook#28479](facebook#28479)) * Devtools: Unwrap Promise in useFormState ([eps1lon](https://github.com/eps1lon) in [facebook#28319](facebook#28319)) * Add support for rendering BigInt ([eps1lon](https://github.com/eps1lon) in [facebook#24580](facebook#24580)) * Include server component names in the componentStack in DEV ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#28415](facebook#28415))

## Summary I used [link-inspector](https://github.com/justindhillon/link-inspector) to find a bunch of broken links in this projects documentation. Here is what I fixed: https://www.html5rocks.com/en/tutorials/canvas/hidpi/ --> https://web.dev/articles/canvas-hidipi https://w3c.github.io/webcomponents/spec/custom/#custom-elements-core-concepts --> https://www.w3.org/TR/custom-elements/ https://github.com/facebookarchive/fixed-data-table/blob/main/src/vendor_upstream/dom/normalizeWheel.js --> https://github.com/facebookarchive/fixed-data-table/blob/master/src/vendor_upstream/dom/normalizeWheel.js https://upload.wikimedia.org/wikipedia/commons/e/ee/Atom_%282%29.png --> https://upload.wikimedia.org/wikipedia/commons/1/1b/Atom.png ## Support my work I used [link-inspector](https://github.com/justindhillon/link-inspector) to find and fix this issue. If you find this PR useful, give the repo a :star: DiffTrain build for commit 034130c.

justindhillon added 6 commits February 13, 2024 12:58

fix documentation link for hidpi canvas

c02d5c3

https://www.w3.org/TR/custom-elements/

bc1caa4

https://www.w3.org/TR/custom-elements/

18cebff

https://github.com/facebookarchive/fixed-data-table/blob/master/src/v…

83c2098

…endor_upstream/dom/normalizeWheel.js

https://github.com/facebook/react/blob/main/packages/react-cache/src/…

6f3793f

…ReactCacheOld.js

https://upload.wikimedia.org/wikipedia/commons/1/1b/Atom.png

106f652

facebook-github-bot added the CLA Signed label Feb 13, 2024

rickhanlonii reviewed Feb 23, 2024

View reviewed changes

justindhillon added 2 commits February 27, 2024 20:11

Merge branch 'facebook:main' into broken-links

3ba1d82

https://html.spec.whatwg.org/multipage/custom-elements.html#custom-el…

2a822b2

…ements-core-concepts

rickhanlonii merged commit 034130c into facebook:main Mar 3, 2024
38 checks passed

hoxyq mentioned this pull request Mar 5, 2024

React DevTools 5.0.1 -> 5.0.2 #28496

Merged

ztanner mentioned this pull request Mar 18, 2024

Update React from 6c3b8dbfe to a4939017f vercel/next.js#63413

Closed

gnoff mentioned this pull request Mar 25, 2024

Update React from 14898b6a9 to e373190fa vercel/next.js#63685

Closed

ztanner mentioned this pull request Apr 2, 2024

Update React from 14898b6a9 to a870b2d54 vercel/next.js#63976

Closed

eps1lon mentioned this pull request Apr 19, 2024

Update React from 14898b6a9 to c3048aab4 vercel/next.js#64798

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Broken Links In Documentation #28321

Fix Broken Links In Documentation #28321

justindhillon commented Feb 13, 2024

facebook-github-bot commented Feb 13, 2024

react-sizebot commented Feb 13, 2024 •

edited

Loading

facebook-github-bot commented Feb 13, 2024

rickhanlonii commented Feb 20, 2024

justindhillon commented Feb 21, 2024

rickhanlonii Feb 23, 2024

justindhillon Feb 28, 2024

rickhanlonii commented Mar 3, 2024

Fix Broken Links In Documentation #28321

Fix Broken Links In Documentation #28321

Conversation

justindhillon commented Feb 13, 2024

Summary

Support my work

facebook-github-bot commented Feb 13, 2024

Action Required

Process

react-sizebot commented Feb 13, 2024 • edited Loading

Critical size changes

Significant size changes

facebook-github-bot commented Feb 13, 2024

rickhanlonii commented Feb 20, 2024

justindhillon commented Feb 21, 2024

rickhanlonii Feb 23, 2024

Choose a reason for hiding this comment

justindhillon Feb 28, 2024

Choose a reason for hiding this comment

rickhanlonii commented Mar 3, 2024

react-sizebot commented Feb 13, 2024 •

edited

Loading