Update isConcurrent RTR option usage #28546

jackpope · 2024-03-12T18:22:06Z

Reverting some of #27804 which renamed this option to stable. This PR just replaces internal usage to make upcoming PRs cleaner.

Keeping isConcurrent unstable for the next major release in order to enable a broader deprecation of RTR and be consistent with concurrent rendering everywhere for next major. (#28498)

Next major will use concurrent root
The old behavior (legacy root by default, concurrent root with unstable option) will be preserved for React Native until new architecture is fully shipped.
Flag and legacy root usage can be removed after RN dependency is unblocked without an additional breaking change

react-sizebot · 2024-03-12T18:25:08Z

Comparing: 7d6f1e3...2a36964

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	177.10 kB	177.10 kB	=	55.20 kB	55.20 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	177.64 kB	177.64 kB	=	55.53 kB	55.53 kB
facebook-www/ReactDOM-prod.classic.js	=	593.92 kB	593.92 kB	=	104.85 kB	104.85 kB
facebook-www/ReactDOM-prod.modern.js	=	577.18 kB	577.18 kB	=	101.91 kB	101.91 kB
test_utils/ReactAllWarnings.js	Deleted	66.60 kB	0.00 kB	Deleted	16.28 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	66.60 kB	0.00 kB	Deleted	16.28 kB	0.00 kB

Generated by 🚫 dangerJS against 2a36964

eps1lon

Can we not remove isConcurrent entirely and just use unstable_isConcurrent or is there already too much code at FB using that option?

jackpope · 2024-03-13T14:42:47Z

@eps1lon Yes we can -- I can replace any FB usage. Was planning to make that change in #28498 . But it makes more sense here. Updated

Reverting some of #27804 which renamed this option to stable. This PR just replaces internal usage to make upcoming PRs cleaner. Keeping isConcurrent unstable for the next major release in order to enable a broader deprecation of RTR and be consistent with concurrent rendering everywhere for next major. (#28498) - Next major will use concurrent root - The old behavior (legacy root by default, concurrent root with unstable option) will be preserved for React Native until new architecture is fully shipped. - Flag and legacy root usage can be removed after RN dependency is unblocked without an additional breaking change DiffTrain build for [3832730](3832730)

Resolve conflict between #28508 and #28546

Reverting some of facebook#27804 which renamed this option to stable. This PR just replaces internal usage to make upcoming PRs cleaner. Keeping isConcurrent unstable for the next major release in order to enable a broader deprecation of RTR and be consistent with concurrent rendering everywhere for next major. (facebook#28498) - Next major will use concurrent root - The old behavior (legacy root by default, concurrent root with unstable option) will be preserved for React Native until new architecture is fully shipped. - Flag and legacy root usage can be removed after RN dependency is unblocked without an additional breaking change

Resolve conflict between facebook#28508 and facebook#28546

Full list of changes: * Look for a ReactMemoCacheSentinel on state ([gsathya](https://github.com/gsathya) in [#28831](#28831)) * Use use() in the Cache if available ([sebmarkbage](https://github.com/sebmarkbage) in [#28793](#28793)) * feat[devtools-fusebox]: support theme option ([hoxyq](https://github.com/hoxyq) in [#28832](#28832)) * feat[devtools]: add package for fusebox integration ([hoxyq](https://github.com/hoxyq) in [#28553](#28553)) * feat[devtools]: add method for connecting backend with custom messaging protocol ([hoxyq](https://github.com/hoxyq) in [#28552](#28552)) * Rename SECRET INTERNALS to `__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE` ([sebmarkbage](https://github.com/sebmarkbage) in [#28789](#28789)) * Flatten ReactSharedInternals ([sebmarkbage](https://github.com/sebmarkbage) in [#28783](#28783)) * feat[devtools]: ship source maps for content scripts and ignore list installHook script ([hoxyq](https://github.com/hoxyq) in [#28730](#28730)) * Track Owner for Server Components in DEV ([sebmarkbage](https://github.com/sebmarkbage) in [#28753](#28753)) * Move ReactDOMLegacy implementation into RootFB ([sebmarkbage](https://github.com/sebmarkbage) in [#28656](#28656)) * Reland #28672: Remove IndeterminateComponent ([gnoff](https://github.com/gnoff) in [#28681](#28681)) * Remove reference to deleted <Cache> in un-linted file ([josephsavona](https://github.com/josephsavona) in [#28715](#28715)) * [be] Remove unshipped experimental <Cache> element type ([josephsavona](https://github.com/josephsavona) in [#28698](#28698)) * Revert "Remove module pattern function component support" ([rickhanlonii](https://github.com/rickhanlonii) in [#28670](#28670)) * Remove module pattern function component support ([gnoff](https://github.com/gnoff) in [#27742](#27742)) * [RTR] Enable warning flag ([jackpope](https://github.com/jackpope) in [#28419](#28419)) * Update error messages ([rickhanlonii](https://github.com/rickhanlonii) in [#28652](#28652)) * fix[devtools/ci]: split profiling cache test for different react versions and toEqual checker ([hoxyq](https://github.com/hoxyq) in [#28628](#28628)) * Guard against legacy context not being supported in DevTools fixture ([eps1lon](https://github.com/eps1lon) in [#28596](#28596)) * Use `declare const` instead of `declare var` ([kassens](https://github.com/kassens) in [#28599](#28599)) * Update isConcurrent RTR option usage ([jackpope](https://github.com/jackpope) in [#28546](#28546)) * Disable legacy context ([kassens](https://github.com/kassens) in [#27991](#27991)) * Remove invokeGuardedCallback and replay trick ([sebmarkbage](https://github.com/sebmarkbage) in [#28515](#28515)) * Remove remaining usages of ReactTestUtils in tests unrelated to `react-dom/test-util` ([eps1lon](https://github.com/eps1lon) in [#28534](#28534)) * fix[devtools/e2e]: fixed source inspection in e2e tests ([hoxyq](https://github.com/hoxyq) in [#28518](#28518)) * Devtools: Display actual pending state when inspecting `useTransition` ([eps1lon](https://github.com/eps1lon) in [#28499](#28499))

Reverting some of #27804 which renamed this option to stable. This PR just replaces internal usage to make upcoming PRs cleaner. Keeping isConcurrent unstable for the next major release in order to enable a broader deprecation of RTR and be consistent with concurrent rendering everywhere for next major. (#28498) - Next major will use concurrent root - The old behavior (legacy root by default, concurrent root with unstable option) will be preserved for React Native until new architecture is fully shipped. - Flag and legacy root usage can be removed after RN dependency is unblocked without an additional breaking change DiffTrain build for commit 3832730.

Resolve conflict between #28508 and #28546 DiffTrain build for commit 6a01aca.

Rename isConcurrent RTR option back to unstable

4a3ab53

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 12, 2024

jackpope requested review from eps1lon, kassens and noahlemen March 12, 2024 18:22

eps1lon reviewed Mar 13, 2024

View reviewed changes

Remove option

2a36964

eps1lon approved these changes Mar 13, 2024

View reviewed changes

jackpope merged commit 3832730 into facebook:main Mar 18, 2024
38 checks passed

jackpope deleted the unstable_isConcurrent_rename branch March 18, 2024 15:35

jackpope mentioned this pull request Mar 18, 2024

Fix ReactHooksInspectionIntegration-test #28577

Merged

jackpope added a commit that referenced this pull request Mar 18, 2024

Fix ReactHooksInspectionIntegration-test (#28577)

6a01aca

Resolve conflict between #28508 and #28546

ztanner mentioned this pull request Mar 21, 2024

Update React from 6c3b8dbfe to a4939017f vercel/next.js#63413

Closed

gnoff mentioned this pull request Mar 25, 2024

Update React from 14898b6a9 to e373190fa vercel/next.js#63685

Closed

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

Fix ReactHooksInspectionIntegration-test (facebook#28577)

619caa1

Resolve conflict between facebook#28508 and facebook#28546

hoxyq mentioned this pull request Apr 15, 2024

React DevTools 5.0.2 -> 5.1.0 #28840

Merged

bigfootjon pushed a commit that referenced this pull request Apr 18, 2024

Fix ReactHooksInspectionIntegration-test (#28577)

bf40fbf

Resolve conflict between #28508 and #28546 DiffTrain build for commit 6a01aca.

eps1lon mentioned this pull request Apr 19, 2024

Update React from 14898b6a9 to c3048aab4 vercel/next.js#64798

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update isConcurrent RTR option usage #28546

Update isConcurrent RTR option usage #28546

jackpope commented Mar 12, 2024

react-sizebot commented Mar 12, 2024 •

edited

Loading

eps1lon left a comment

jackpope commented Mar 13, 2024

Update isConcurrent RTR option usage #28546

Update isConcurrent RTR option usage #28546

Conversation

jackpope commented Mar 12, 2024

react-sizebot commented Mar 12, 2024 • edited Loading

Critical size changes

Significant size changes

eps1lon left a comment

Choose a reason for hiding this comment

jackpope commented Mar 13, 2024

react-sizebot commented Mar 12, 2024 •

edited

Loading