Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set disableModulePatternComponents flag to __NEXT_MAJOR__ #28579

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented Mar 18, 2024

No description provided.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 18, 2024
@kassens kassens requested a review from acdlite March 18, 2024 18:51
@react-sizebot
Copy link

Comparing: 0aab065...3897731

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.83 kB 176.83 kB = 54.91 kB 54.90 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 173.55 kB 173.26 kB = 54.11 kB 54.04 kB
facebook-www/ReactDOM-prod.classic.js = 594.27 kB 594.27 kB = 104.44 kB 104.44 kB
facebook-www/ReactDOM-prod.modern.js = 577.53 kB 577.53 kB = 101.47 kB 101.47 kB
test_utils/ReactAllWarnings.js Deleted 66.63 kB 0.00 kB Deleted 16.28 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-reconciler/cjs/react-reconciler.development.js = 928.75 kB 926.86 kB = 197.75 kB 197.50 kB
oss-experimental/react-art/umd/react-art.development.js = 941.13 kB 939.18 kB = 197.32 kB 197.09 kB
oss-experimental/react-art/umd/react-art.production.min.js = 135.33 kB 135.04 kB = 42.24 kB 42.16 kB
oss-experimental/react-server/cjs/react-server.production.js = 166.53 kB 166.16 kB = 38.51 kB 38.41 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.production.min.js = 93.22 kB 93.01 kB = 28.53 kB 28.46 kB
oss-experimental/react-art/cjs/react-art.development.js = 825.28 kB 823.39 kB = 178.04 kB 177.80 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.min.js = 123.28 kB 122.99 kB = 37.75 kB 37.66 kB
oss-experimental/react-dom/cjs/react-dom-server.node.production.min.js = 91.44 kB 91.23 kB = 27.70 kB 27.64 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.development.js = 840.12 kB 838.17 kB = 176.32 kB 176.10 kB
oss-experimental/react-dom/umd/react-dom-server.browser.development.js = 467.39 kB 466.31 kB = 99.89 kB 99.77 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js = 802.16 kB 800.27 kB = 174.32 kB 174.03 kB
oss-experimental/react-dom/umd/react-dom-server-legacy.browser.development.js = 458.58 kB 457.50 kB = 98.82 kB 98.72 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.production.min.js = 89.31 kB 89.10 kB = 27.20 kB 27.18 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.development.js = 447.12 kB 446.06 kB = 99.05 kB 98.93 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.development.js = 446.54 kB 445.48 kB = 98.92 kB 98.80 kB
oss-experimental/react-dom/cjs/react-dom-server.node.development.js = 444.91 kB 443.85 kB = 98.11 kB 98.00 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.production.min.js = 87.85 kB 87.64 kB = 26.81 kB 26.76 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.development.js = 439.97 kB 438.91 kB = 98.32 kB 98.19 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.development.js = 438.12 kB 437.06 kB = 97.85 kB 97.73 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.min.js = 86.30 kB 86.09 kB = 26.09 kB 26.04 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js = 431.81 kB 430.76 kB = 95.96 kB 95.83 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.min.js = 114.24 kB 113.95 kB = 35.40 kB 35.33 kB
oss-experimental/react-dom/umd/react-dom-server.browser.production.min.js = 87.92 kB 87.70 kB = 27.18 kB 27.13 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.production.min.js = 83.41 kB 83.20 kB = 25.29 kB 25.23 kB
oss-experimental/react-dom/umd/react-dom-server-legacy.browser.production.min.js = 83.49 kB 83.28 kB = 25.69 kB 25.64 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.production.min.js = 105.15 kB 104.86 kB = 32.56 kB 32.50 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.min.js = 104.86 kB 104.57 kB = 32.21 kB 32.15 kB
oss-experimental/react-art/cjs/react-art.production.min.js = 98.12 kB 97.84 kB = 30.18 kB 30.12 kB
oss-experimental/react-server/cjs/react-server.development.js = 210.98 kB 209.92 kB = 48.90 kB 48.78 kB
oss-experimental/react-server/cjs/react-server.production.min.js = 40.94 kB 40.73 kB = 12.86 kB 12.83 kB
test_utils/ReactAllWarnings.js Deleted 66.63 kB 0.00 kB Deleted 16.28 kB 0.00 kB

Generated by 🚫 dangerJS against 3897731

@kassens kassens requested review from gnoff and rickhanlonii March 18, 2024 18:54
@kassens kassens merged commit 9c75cd5 into facebook:main Mar 18, 2024
38 checks passed
kassens added a commit to kassens/react that referenced this pull request Mar 18, 2024
I missed this in facebook#28579, for the next major of RN OSS we should also
enable this flag.
kassens added a commit to kassens/react that referenced this pull request Mar 20, 2024
I missed this in facebook#28579, for the next major of RN OSS we should also
enable this flag.
@kassens kassens deleted the pr28579 branch March 25, 2024 17:57
gnoff added a commit to gnoff/next.js that referenced this pull request Mar 25, 2024
- facebook/react#28596
- facebook/react#28625
- facebook/react#28616
- facebook/react#28491
- facebook/react#28583
- facebook/react#28427
- facebook/react#28613
- facebook/react#28599
- facebook/react#28611
- facebook/react#28610
- facebook/react#28606
- facebook/react#28598
- facebook/react#28549
- facebook/react#28557
- facebook/react#28467
- facebook/react#28591
- facebook/react#28459
- facebook/react#28590
- facebook/react#28564
- facebook/react#28582
- facebook/react#28579
- facebook/react#28578
- facebook/react#28521
- facebook/react#28550
- facebook/react#28576
- facebook/react#28577
- facebook/react#28571
- facebook/react#28572
- facebook/react#28560
- facebook/react#28569
- facebook/react#28573
- facebook/react#28546
- facebook/react#28568
- facebook/react#28562
- facebook/react#28566
- facebook/react#28565
- facebook/react#28559
- facebook/react#28508
- facebook/react#20432
- facebook/react#28555
- facebook/react#24730
- facebook/react#28472
- facebook/react#27991
- facebook/react#28514
- facebook/react#28548
- facebook/react#28526
- facebook/react#28515
- facebook/react#28533
- facebook/react#28532
- facebook/react#28531
- facebook/react#28407
- facebook/react#28522
- facebook/react#28538
- facebook/react#28509
- facebook/react#28534
- facebook/react#28527
- facebook/react#28528
- facebook/react#28519
- facebook/react#28411
- facebook/react#28520
- facebook/react#28518
- facebook/react#28493
- facebook/react#28504
- facebook/react#28499
- facebook/react#28501
- facebook/react#28496
- facebook/react#28471
- facebook/react#28351
- facebook/react#28486
- facebook/react#28490
- facebook/react#28488
- facebook/react#28468
- facebook/react#28321
- facebook/react#28477
- facebook/react#28479
- facebook/react#28480
- facebook/react#28478
- facebook/react#28464
- facebook/react#28475
- facebook/react#28456
- facebook/react#28319
- facebook/react#28345
- facebook/react#28337
- facebook/react#28335
- facebook/react#28466
- facebook/react#28462
- facebook/react#28322
- facebook/react#28444
- facebook/react#28448
- facebook/react#28449
- facebook/react#28446
- facebook/react#28447
- facebook/react#24580
- facebook/react#28514
- facebook/react#28548
- facebook/react#28526
- facebook/react#28515
- facebook/react#28533
- facebook/react#28532
- facebook/react#28531
- facebook/react#28407
- facebook/react#28522
- facebook/react#28538
- facebook/react#28509
- facebook/react#28534
- facebook/react#28527
- facebook/react#28528
- facebook/react#28519
- facebook/react#28411
- facebook/react#28520
- facebook/react#28518
- facebook/react#28493
- facebook/react#28504
- facebook/react#28499
- facebook/react#28501
- facebook/react#28496
- facebook/react#28471
- facebook/react#28351
- facebook/react#28486
- facebook/react#28490
- facebook/react#28488
- facebook/react#28468
- facebook/react#28321
- facebook/react#28477
- facebook/react#28479
- facebook/react#28480
- facebook/react#28478
- facebook/react#28464
- facebook/react#28475
- facebook/react#28456
- facebook/react#28319
- facebook/react#28345
- facebook/react#28337
- facebook/react#28335
- facebook/react#28466
- facebook/react#28462
- facebook/react#28322
- facebook/react#28444
- facebook/react#28448
- facebook/react#28449
- facebook/react#28446
- facebook/react#28447
- facebook/react#24580
gnoff added a commit to gnoff/next.js that referenced this pull request Mar 25, 2024
- facebook/react#28596
- facebook/react#28625
- facebook/react#28616
- facebook/react#28491
- facebook/react#28583
- facebook/react#28427
- facebook/react#28613
- facebook/react#28599
- facebook/react#28611
- facebook/react#28610
- facebook/react#28606
- facebook/react#28598
- facebook/react#28549
- facebook/react#28557
- facebook/react#28467
- facebook/react#28591
- facebook/react#28459
- facebook/react#28590
- facebook/react#28564
- facebook/react#28582
- facebook/react#28579
- facebook/react#28578
- facebook/react#28521
- facebook/react#28550
- facebook/react#28576
- facebook/react#28577
- facebook/react#28571
- facebook/react#28572
- facebook/react#28560
- facebook/react#28569
- facebook/react#28573
- facebook/react#28546
- facebook/react#28568
- facebook/react#28562
- facebook/react#28566
- facebook/react#28565
- facebook/react#28559
- facebook/react#28508
- facebook/react#20432
- facebook/react#28555
- facebook/react#24730
- facebook/react#28472
- facebook/react#27991
- facebook/react#28514
- facebook/react#28548
- facebook/react#28526
- facebook/react#28515
- facebook/react#28533
- facebook/react#28532
- facebook/react#28531
- facebook/react#28407
- facebook/react#28522
- facebook/react#28538
- facebook/react#28509
- facebook/react#28534
- facebook/react#28527
- facebook/react#28528
- facebook/react#28519
- facebook/react#28411
- facebook/react#28520
- facebook/react#28518
- facebook/react#28493
- facebook/react#28504
- facebook/react#28499
- facebook/react#28501
- facebook/react#28496
- facebook/react#28471
- facebook/react#28351
- facebook/react#28486
- facebook/react#28490
- facebook/react#28488
- facebook/react#28468
- facebook/react#28321
- facebook/react#28477
- facebook/react#28479
- facebook/react#28480
- facebook/react#28478
- facebook/react#28464
- facebook/react#28475
- facebook/react#28456
- facebook/react#28319
- facebook/react#28345
- facebook/react#28337
- facebook/react#28335
- facebook/react#28466
- facebook/react#28462
- facebook/react#28322
- facebook/react#28444
- facebook/react#28448
- facebook/react#28449
- facebook/react#28446
- facebook/react#28447
- facebook/react#24580
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
eps1lon added a commit to vercel/next.js that referenced this pull request Apr 19, 2024
### React upstream changes

- facebook/react#28643
- facebook/react#28628
- facebook/react#28361
- facebook/react#28513
- facebook/react#28299
- facebook/react#28617
- facebook/react#28618
- facebook/react#28621
- facebook/react#28614
- facebook/react#28596
- facebook/react#28625
- facebook/react#28616
- facebook/react#28491
- facebook/react#28583
- facebook/react#28427
- facebook/react#28613
- facebook/react#28599
- facebook/react#28611
- facebook/react#28610
- facebook/react#28606
- facebook/react#28598
- facebook/react#28549
- facebook/react#28557
- facebook/react#28467
- facebook/react#28591
- facebook/react#28459
- facebook/react#28590
- facebook/react#28564
- facebook/react#28582
- facebook/react#28579
- facebook/react#28578
- facebook/react#28521
- facebook/react#28550
- facebook/react#28576
- facebook/react#28577
- facebook/react#28571
- facebook/react#28572
- facebook/react#28560
- facebook/react#28569
- facebook/react#28573
- facebook/react#28546
- facebook/react#28568
- facebook/react#28562
- facebook/react#28566
- facebook/react#28565
- facebook/react#28559
- facebook/react#28508
- facebook/react#20432
- facebook/react#28555
- facebook/react#24730
- facebook/react#28472
- facebook/react#27991
- facebook/react#28514
- facebook/react#28548
- facebook/react#28526
- facebook/react#28515
- facebook/react#28533
- facebook/react#28532
- facebook/react#28531
- facebook/react#28407
- facebook/react#28522
- facebook/react#28538
- facebook/react#28509
- facebook/react#28534
- facebook/react#28527
- facebook/react#28528
- facebook/react#28519
- facebook/react#28411
- facebook/react#28520
- facebook/react#28518
- facebook/react#28493
- facebook/react#28504
- facebook/react#28499
- facebook/react#28501
- facebook/react#28496
- facebook/react#28471
- facebook/react#28351
- facebook/react#28486
- facebook/react#28490
- facebook/react#28488
- facebook/react#28468
- facebook/react#28321
- facebook/react#28477
- facebook/react#28479
- facebook/react#28480
- facebook/react#28478
- facebook/react#28464
- facebook/react#28475
- facebook/react#28456
- facebook/react#28319
- facebook/react#28345
- facebook/react#28337
- facebook/react#28335
- facebook/react#28466
- facebook/react#28462
- facebook/react#28322
- facebook/react#28444
- facebook/react#28448
- facebook/react#28449
- facebook/react#28446
- facebook/react#28447
- facebook/react#24580
- facebook/react#28514
- facebook/react#28548
- facebook/react#28526
- facebook/react#28515
- facebook/react#28533
- facebook/react#28532
- facebook/react#28531
- facebook/react#28407
- facebook/react#28522
- facebook/react#28538
- facebook/react#28509
- facebook/react#28534
- facebook/react#28527
- facebook/react#28528
- facebook/react#28519
- facebook/react#28411
- facebook/react#28520
- facebook/react#28518
- facebook/react#28493
- facebook/react#28504
- facebook/react#28499
- facebook/react#28501
- facebook/react#28496
- facebook/react#28471
- facebook/react#28351
- facebook/react#28486
- facebook/react#28490
- facebook/react#28488
- facebook/react#28468
- facebook/react#28321
- facebook/react#28477
- facebook/react#28479
- facebook/react#28480
- facebook/react#28478
- facebook/react#28464
- facebook/react#28475
- facebook/react#28456
- facebook/react#28319
- facebook/react#28345
- facebook/react#28337
- facebook/react#28335
- facebook/react#28466
- facebook/react#28462
- facebook/react#28322
- facebook/react#28444
- facebook/react#28448
- facebook/react#28449
- facebook/react#28446
- facebook/react#28447
- facebook/react#24580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team React 19
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants