fix: Create __init__ files for the proto-generated python dirs

[achals]

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:
Python packages without the __init__ file become "namespace packages". By default, mypy doesn't understand namespace packages when discovering types for typechecking. python/mypy#1645.

We can add the --namespace-packages flag to solve this problem, but I'm not sure if this will require all consumers to also add this flag. We're not creating namespace packages to begin with so it seems better to just add the __init__ files to simplify this setup. This PR updates the setup.py to create the __init__ files.

The only difference is that we need to exclude types proto subdirectory because that clashes with an existing module in the python standard library. Apparently mypy confuses the two 🤷🏽

Which issue(s) this PR fixes:

Unblocks #2405

[codecov-commenter]

Codecov Report

Merging #2410 (507cf5a) into master (c2389da) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2410      +/-   ##
==========================================
- Coverage   85.47%   85.40%   -0.08%     
==========================================
  Files         122      122              
  Lines       10714    10714              
==========================================
- Hits         9158     9150       -8     
- Misses       1556     1564       +8     

Flag	Coverage Δ
integrationtests	75.24% <ø> (-0.29%)	⬇️
unittests	57.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/wait.py	58.82% <0.00%> (-35.30%)	⬇️
.../integration/online_store/test_universal_online.py	96.68% <0.00%> (-0.48%)	⬇️
sdk/python/feast/go_server.py	89.18% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2389da...507cf5a. Read the comment docs.

[woop]

The only difference is that we need to exclude types proto subdirectory because that clashes with an existing module in the python standard library. Apparently mypy confuses the two

What if we just moved those proto files into the core folder?

[achals]

The only difference is that we need to exclude types proto subdirectory because that clashes with an existing module in the python standard library. Apparently mypy confuses the two

What if we just moved those proto files into the core folder?

I misunderstood your original proposal. I think a better solution would be to rename the package to something like primitives or feast_types. I like having all the generated code together in a single directory, and wouldn't want to move just the types into a different location.

[felixwang9817]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[woop]

I misunderstood your original proposal. I think a better solution would be to rename the package to something like primitives or feast_types. I like having all the generated code together in a single directory, and wouldn't want to move just the types into a different location.

I like this idea @achals. These subfolders suck :)