fix: Added private_key auth for Snowflake

[sfc-gh-madkins]

Signed-off-by: Miles Adkins miles.adkins@snowflake.com

What this PR does / why we need it:

Adds ability for key-pair auth for Snowflake

Which issue(s) this PR fixes:

Fixes #2482

[codecov-commenter]

Codecov Report

Merging #2508 (19fac9e) into master (df51b94) will decrease coverage by 25.08%.
The diff coverage is 30.76%.

@@             Coverage Diff             @@
##           master    #2508       +/-   ##
===========================================
- Coverage   84.24%   59.16%   -25.09%     
===========================================
  Files         134      133        -1     
  Lines       11161    11197       +36     
===========================================
- Hits         9403     6625     -2778     
- Misses       1758     4572     +2814     

Flag	Coverage Δ
integrationtests	?
unittests	59.16% <30.76%> (+0.32%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/infra/utils/snowflake_utils.py	22.65% <30.76%> (-63.06%)	⬇️
.../integration/online_store/test_online_retrieval.py	17.39% <0.00%> (-82.61%)	⬇️
sdk/python/tests/utils/online_read_write_test.py	20.68% <0.00%> (-79.32%)	⬇️
.../integration/online_store/test_universal_online.py	14.85% <0.00%> (-77.72%)	⬇️
...fline_store/test_universal_historical_retrieval.py	23.73% <0.00%> (-76.27%)	⬇️
sdk/python/feast/infra/online_stores/redis.py	27.04% <0.00%> (-69.19%)	⬇️
...gration/registration/test_feature_service_apply.py	31.25% <0.00%> (-68.75%)	⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py	33.87% <0.00%> (-66.13%)	⬇️
sdk/python/tests/data/data_creator.py	34.78% <0.00%> (-65.22%)	⬇️
...dk/python/tests/integration/e2e/test_validation.py	35.18% <0.00%> (-64.82%)	⬇️
... and 69 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df51b94...19fac9e. Read the comment docs.

[achals]

Is this the only supported format for the key pair?

[sfc-gh-madkins]

Yes -- I have add the links to the docs as comments.

[achals]

@sfc-gh-madkins thanks, looks good but linter seems to be failing because of some type mismatches.

[sfc-gh-madkins]

@adchia do you have any ideas on how to fix this lint error:

feast/infra/utils/snowflake_utils.py:75: error: Incompatible types in assignment (expression has type "bytes", target has type "str")

here is the code:

if "private_key" in kwargs:
    kwargs["private_key"] = parse_private_key_path(
        kwargs["private_key"], kwargs["private_key_passphrase"]
    )

parse_private_key_path() returns "bytes"
kwargs["private_key"] is a str that I am looking to overwrite with bytes

PS. Changing the name to create a new entry in the dict doesnt solve the problem either

[achals]

@adchia do you have any ideas on how to fix this lint error:

feast/infra/utils/snowflake_utils.py:75: error: Incompatible types in assignment (expression has type "bytes", target has type "str")

here is the code:

if "private_key" in kwargs:
    kwargs["private_key"] = parse_private_key_path(
        kwargs["private_key"], kwargs["private_key_passphrase"]
    )

parse_private_key_path() returns "bytes" kwargs["private_key"] is a str that I am looking to overwrite with bytes

PS. Changing the name to create a new entry in the dict doesnt solve the problem either

I pushed a couple of fixes here to solve the typing problem! LMK if you have concerns, otherwise we'll get this merged in on Monday.

[sfc-gh-madkins]

Lgtm

…

Sent from my iPhone

On Apr 8, 2022, at 7:59 PM, Achal Shah ***@***.***> wrote:  @adchia do you have any ideas on how to fix this lint error: feast/infra/utils/snowflake_utils.py:75: error: Incompatible types in assignment (expression has type "bytes", target has type "str") here is the code: if "private_key" in kwargs: kwargs["private_key"] = parse_private_key_path( kwargs["private_key"], kwargs["private_key_passphrase"] ) parse_private_key_path() returns "bytes" kwargs["private_key"] is a str that I am looking to overwrite with bytes PS. Changing the name to create a new entry in the dict doesnt solve the problem either I pushed a couple of fixes here to solve the typing problem! LMK if you have concerns, otherwise we'll get this merged in on Monday. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

[achals]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, sfc-gh-madkins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [achals]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment