feat: Filter subset features in postgres #3174 #3203

NhuanTDBK · 2022-09-10T04:14:25Z

Signed-off-by: Steve Tran NhuanTDBK@users.noreply.github.com
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3173

Signed-off-by: NHUAN.TRAN <nhuan.tran@onemount.com> Signed-off-by: NHUAN.TRAN <NhuanTDBK@users.noreply.github.com>

codecov-commenter · 2022-09-12T16:03:03Z

Codecov Report

Base: 67.02% // Head: 58.28% // Decreases project coverage by -8.73% ⚠️

Coverage data is based on head (bc4b939) compared to base (c19d640).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3203      +/-   ##
==========================================
- Coverage   67.02%   58.28%   -8.74%     
==========================================
  Files         175      209      +34     
  Lines       15940    17661    +1721     
==========================================
- Hits        10683    10293     -390     
- Misses       5257     7368    +2111

Flag	Coverage Δ
integrationtests	`?`
unittests	`58.28% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...thon/feast/infra/online_stores/contrib/postgres.py	`32.07% <0.00%> (ø)`
...sts/integration/registration/test_universal_cli.py	`20.20% <0.00%> (-79.80%)`	⬇️
...ts/integration/offline_store/test_offline_write.py	`26.08% <0.00%> (-73.92%)`	⬇️
...fline_store/test_universal_historical_retrieval.py	`28.75% <0.00%> (-71.25%)`	⬇️
...ests/integration/e2e/test_python_feature_server.py	`29.50% <0.00%> (-70.50%)`	⬇️
...dk/python/tests/integration/e2e/test_validation.py	`27.55% <0.00%> (-69.30%)`	⬇️
...s/integration/registration/test_universal_types.py	`32.25% <0.00%> (-67.75%)`	⬇️
sdk/python/feast/infra/online_stores/redis.py	`28.39% <0.00%> (-66.67%)`	⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py	`33.87% <0.00%> (-66.13%)`	⬇️
sdk/python/tests/data/data_creator.py	`34.78% <0.00%> (-65.22%)`	⬇️
... and 160 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

felixwang9817 · 2022-09-12T16:18:57Z

hey @NhuanTDBK thanks for the PR! I left a comment on #3173

kevjumba · 2022-09-12T17:18:28Z

@NhuanTDBK you should address linting. Also could you respond to felix's comment.

Signed-off-by: NHUAN.TRAN <NhuanTDBK@users.noreply.github.com>

felixwang9817

/lgtm

feast-ci-bot · 2022-09-22T17:46:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, NhuanTDBK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Filter subset features Signed-off-by: NHUAN.TRAN <nhuan.tran@onemount.com> Signed-off-by: NHUAN.TRAN <NhuanTDBK@users.noreply.github.com> * Fix python lint Signed-off-by: NHUAN.TRAN <NhuanTDBK@users.noreply.github.com> Signed-off-by: NHUAN.TRAN <nhuan.tran@onemount.com> Signed-off-by: NHUAN.TRAN <NhuanTDBK@users.noreply.github.com> Co-authored-by: NHUAN.TRAN <nhuan.tran@onemount.com>

# [0.26.0](v0.25.0...v0.26.0) (2022-10-06) ### Bug Fixes * Add `X-Trino-Extra-Credential` header and remove user override ([#3246](#3246)) ([164e666](164e666)) * Add postgres to the feature server Dockerfile to fix helm chart flow ([#3261](#3261)) ([6f6cbb7](6f6cbb7)) * Add stream feature view in the Web UI ([#3257](#3257)) ([1f70b3a](1f70b3a)) * Build dockerfile correctly ([#3239](#3239)) ([a2dc0d0](a2dc0d0)) * Configuration to stop coercion of tz for entity_df ([#3255](#3255)) ([97b7ab9](97b7ab9)) * Enable users to upgrade a batch source into a push source ([#3213](#3213)) ([1b312fb](1b312fb)) * Fix docker image for feature-server ([#3272](#3272)) ([eff01d1](eff01d1)) * Fix Feast UI release process to update the feast-ui package ([#3267](#3267)) ([a9d48d0](a9d48d0)) * Return 422 on bad push source name ([#3214](#3214)) ([b851e01](b851e01)) * Stream feature view meta undefined created_timestamp issue ([#3266](#3266)) ([12e1a8f](12e1a8f)) * Stream feature view not shown in the UI ([#3251](#3251)) ([e713dda](e713dda)) * Udf in stream feature view UI shows pickled data ([#3268](#3268)) ([0728117](0728117)) * Update snowflake materialization messages ([#3230](#3230)) ([a63d440](a63d440)) * Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([#3271](#3271)) ([b9b9c54](b9b9c54)) * Use configured user in env var instead of "user" for Trino ([#3254](#3254)) ([532d8a1](532d8a1)) ### Features * Add mysql as online store ([#3190](#3190)) ([cb8db84](cb8db84)) * Add possibility to define feature_store.yaml path with env variable ([#3231](#3231)) ([95fdb19](95fdb19)) * Add request_timeout setting for cassandra online store adapter ([#3256](#3256)) ([da20757](da20757)) * Add tag description in Field in the Feast UI ([#3258](#3258)) ([086f279](086f279)) * Adding billing_project_id in BigQueryOfflineStoreConfig ([#3253](#3253)) ([f80f05f](f80f05f)) * BigTable online store ([#3140](#3140)) ([6bc91c2](6bc91c2)), closes [/github.com/spulec/moto/blob/master/CHANGELOG.md#400](https://github.com//github.com/spulec/moto/blob/master/CHANGELOG.md/issues/400) * Filter subset features in postgres [#3174](#3174) ([#3203](#3203)) ([b48d36b](b48d36b))

# [0.26.0](feast-dev/feast@v0.25.0...v0.26.0) (2022-10-06) ### Bug Fixes * Add `X-Trino-Extra-Credential` header and remove user override ([feast-dev#3246](feast-dev#3246)) ([164e666](feast-dev@164e666)) * Add postgres to the feature server Dockerfile to fix helm chart flow ([feast-dev#3261](feast-dev#3261)) ([6f6cbb7](feast-dev@6f6cbb7)) * Add stream feature view in the Web UI ([feast-dev#3257](feast-dev#3257)) ([1f70b3a](feast-dev@1f70b3a)) * Build dockerfile correctly ([feast-dev#3239](feast-dev#3239)) ([a2dc0d0](feast-dev@a2dc0d0)) * Configuration to stop coercion of tz for entity_df ([feast-dev#3255](feast-dev#3255)) ([97b7ab9](feast-dev@97b7ab9)) * Enable users to upgrade a batch source into a push source ([feast-dev#3213](feast-dev#3213)) ([1b312fb](feast-dev@1b312fb)) * Fix docker image for feature-server ([feast-dev#3272](feast-dev#3272)) ([eff01d1](feast-dev@eff01d1)) * Fix Feast UI release process to update the feast-ui package ([feast-dev#3267](feast-dev#3267)) ([a9d48d0](feast-dev@a9d48d0)) * Return 422 on bad push source name ([feast-dev#3214](feast-dev#3214)) ([b851e01](feast-dev@b851e01)) * Stream feature view meta undefined created_timestamp issue ([feast-dev#3266](feast-dev#3266)) ([12e1a8f](feast-dev@12e1a8f)) * Stream feature view not shown in the UI ([feast-dev#3251](feast-dev#3251)) ([e713dda](feast-dev@e713dda)) * Udf in stream feature view UI shows pickled data ([feast-dev#3268](feast-dev#3268)) ([0728117](feast-dev@0728117)) * Update snowflake materialization messages ([feast-dev#3230](feast-dev#3230)) ([a63d440](feast-dev@a63d440)) * Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([feast-dev#3271](feast-dev#3271)) ([b9b9c54](feast-dev@b9b9c54)) * Use configured user in env var instead of "user" for Trino ([feast-dev#3254](feast-dev#3254)) ([532d8a1](feast-dev@532d8a1)) ### Features * Add mysql as online store ([feast-dev#3190](feast-dev#3190)) ([cb8db84](feast-dev@cb8db84)) * Add possibility to define feature_store.yaml path with env variable ([feast-dev#3231](feast-dev#3231)) ([95fdb19](feast-dev@95fdb19)) * Add request_timeout setting for cassandra online store adapter ([feast-dev#3256](feast-dev#3256)) ([da20757](feast-dev@da20757)) * Add tag description in Field in the Feast UI ([feast-dev#3258](feast-dev#3258)) ([086f279](feast-dev@086f279)) * Adding billing_project_id in BigQueryOfflineStoreConfig ([feast-dev#3253](feast-dev#3253)) ([f80f05f](feast-dev@f80f05f)) * BigTable online store ([feast-dev#3140](feast-dev#3140)) ([6bc91c2](feast-dev@6bc91c2)), closes [/github.com/spulec/moto/blob/master/CHANGELOG.md#400](https://github.com//github.com/spulec/moto/blob/master/CHANGELOG.md/issues/400) * Filter subset features in postgres [feast-dev#3174](feast-dev#3174) ([feast-dev#3203](feast-dev#3203)) ([b48d36b](feast-dev@b48d36b))

Filter subset features

9e140f9

Signed-off-by: NHUAN.TRAN <nhuan.tran@onemount.com> Signed-off-by: NHUAN.TRAN <NhuanTDBK@users.noreply.github.com>

feast-ci-bot added the size/M label Sep 10, 2022

felixwang9817 mentioned this pull request Sep 12, 2022

Support requested features on Postgresql online store #3173

Closed

felixwang9817 self-assigned this Sep 12, 2022

Fix python lint

bc4b939

Signed-off-by: NHUAN.TRAN <NhuanTDBK@users.noreply.github.com>

felixwang9817 approved these changes Sep 22, 2022

View reviewed changes

feast-ci-bot added the lgtm label Sep 22, 2022

feast-ci-bot added the approved label Sep 22, 2022

feast-ci-bot merged commit b48d36b into feast-dev:master Sep 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Filter subset features in postgres #3174 #3203

feat: Filter subset features in postgres #3174 #3203

NhuanTDBK commented Sep 10, 2022

codecov-commenter commented Sep 12, 2022 •

edited

Loading

felixwang9817 commented Sep 12, 2022

kevjumba commented Sep 12, 2022

felixwang9817 left a comment

feast-ci-bot commented Sep 22, 2022

feat: Filter subset features in postgres #3174 #3203

feat: Filter subset features in postgres #3174 #3203

Conversation

NhuanTDBK commented Sep 10, 2022

codecov-commenter commented Sep 12, 2022 • edited Loading

Codecov Report

felixwang9817 commented Sep 12, 2022

kevjumba commented Sep 12, 2022

felixwang9817 left a comment

Choose a reason for hiding this comment

feast-ci-bot commented Sep 22, 2022

codecov-commenter commented Sep 12, 2022 •

edited

Loading