fix: Udf in stream feature view UI shows pickled data #3268

hao-affirm · 2022-10-04T07:53:39Z

Signed-off-by: hao-affirm 104030690+hao-affirm@users.noreply.github.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

adchia

/lgtm

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

codecov-commenter · 2022-10-04T19:19:00Z

Codecov Report

Base: 67.49% // Head: 76.69% // Increases project coverage by +9.19% 🎉

Coverage data is based on head (4db494f) compared to base (53dc811).
Patch coverage: 57.14% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3268      +/-   ##
==========================================
+ Coverage   67.49%   76.69%   +9.19%     
==========================================
  Files         179      216      +37     
  Lines       16420    18266    +1846     
==========================================
+ Hits        11083    14009    +2926     
+ Misses       5337     4257    -1080

Flag	Coverage Δ
integrationtests	`67.32% <42.85%> (-0.18%)`	⬇️
unittests	`58.15% <57.14%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/infra/registry/base_registry.py	`91.40% <0.00%> (-1.46%)`	⬇️
sdk/python/feast/stream_feature_view.py	`92.37% <100.00%> (+16.05%)`	⬆️
sdk/python/feast/infra/offline_stores/bigquery.py	`85.57% <0.00%> (-0.78%)`	⬇️
...on/feast/infra/materialization/snowflake_engine.py	`93.18% <0.00%> (-0.41%)`	⬇️
...tion/contrib/spark/spark_materialization_engine.py	`71.84% <0.00%> (-0.28%)`	⬇️
...ine_stores/contrib/cassandra_repo_configuration.py	`100.00% <0.00%> (ø)`
...ffline_stores/contrib/trino_offline_store/trino.py	`8.78% <0.00%> (ø)`
...ontrib/postgres_offline_store/tests/data_source.py	`51.02% <0.00%> (ø)`
...s/contrib/postgres_offline_store/tests/__init__.py	`100.00% <0.00%> (ø)`
sdk/python/feast/transformation_server.py	`40.47% <0.00%> (ø)`
... and 105 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

hao-affirm · 2022-10-04T23:13:36Z

@adchia Do you have time to have a look? though the unit test failed but doesn't look like relate to this pr.

adchia

/lgtm

feast-ci-bot · 2022-10-04T23:28:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, hao-affirm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [adchia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* fix udf in stream feature view UI shows pickeled data Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> * fix lint Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> * fix lint Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> * fix test Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> * fix lint Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

## [0.25.2](v0.25.1...v0.25.2) (2022-10-06) ### Bug Fixes * Fix docker image for feature-server ([#3272](#3272)) ([4ce366a](4ce366a)) * Fix Feast UI release process to update the feast-ui package ([#3267](#3267)) ([d118fe4](d118fe4)) * Stream feature view meta undefined created_timestamp issue ([#3266](#3266)) ([efbd4b0](efbd4b0)) * Udf in stream feature view UI shows pickled data ([#3268](#3268)) ([f4a83a7](f4a83a7)) * Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([#3271](#3271)) ([7fa4bbf](7fa4bbf))

# [0.26.0](v0.25.0...v0.26.0) (2022-10-06) ### Bug Fixes * Add `X-Trino-Extra-Credential` header and remove user override ([#3246](#3246)) ([164e666](164e666)) * Add postgres to the feature server Dockerfile to fix helm chart flow ([#3261](#3261)) ([6f6cbb7](6f6cbb7)) * Add stream feature view in the Web UI ([#3257](#3257)) ([1f70b3a](1f70b3a)) * Build dockerfile correctly ([#3239](#3239)) ([a2dc0d0](a2dc0d0)) * Configuration to stop coercion of tz for entity_df ([#3255](#3255)) ([97b7ab9](97b7ab9)) * Enable users to upgrade a batch source into a push source ([#3213](#3213)) ([1b312fb](1b312fb)) * Fix docker image for feature-server ([#3272](#3272)) ([eff01d1](eff01d1)) * Fix Feast UI release process to update the feast-ui package ([#3267](#3267)) ([a9d48d0](a9d48d0)) * Return 422 on bad push source name ([#3214](#3214)) ([b851e01](b851e01)) * Stream feature view meta undefined created_timestamp issue ([#3266](#3266)) ([12e1a8f](12e1a8f)) * Stream feature view not shown in the UI ([#3251](#3251)) ([e713dda](e713dda)) * Udf in stream feature view UI shows pickled data ([#3268](#3268)) ([0728117](0728117)) * Update snowflake materialization messages ([#3230](#3230)) ([a63d440](a63d440)) * Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([#3271](#3271)) ([b9b9c54](b9b9c54)) * Use configured user in env var instead of "user" for Trino ([#3254](#3254)) ([532d8a1](532d8a1)) ### Features * Add mysql as online store ([#3190](#3190)) ([cb8db84](cb8db84)) * Add possibility to define feature_store.yaml path with env variable ([#3231](#3231)) ([95fdb19](95fdb19)) * Add request_timeout setting for cassandra online store adapter ([#3256](#3256)) ([da20757](da20757)) * Add tag description in Field in the Feast UI ([#3258](#3258)) ([086f279](086f279)) * Adding billing_project_id in BigQueryOfflineStoreConfig ([#3253](#3253)) ([f80f05f](f80f05f)) * BigTable online store ([#3140](#3140)) ([6bc91c2](6bc91c2)), closes [/github.com/spulec/moto/blob/master/CHANGELOG.md#400](https://github.com//github.com/spulec/moto/blob/master/CHANGELOG.md/issues/400) * Filter subset features in postgres [#3174](#3174) ([#3203](#3203)) ([b48d36b](b48d36b))

* fix udf in stream feature view UI shows pickeled data Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> * fix lint Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> * fix lint Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> * fix test Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> * fix lint Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

# [0.26.0](feast-dev/feast@v0.25.0...v0.26.0) (2022-10-06) ### Bug Fixes * Add `X-Trino-Extra-Credential` header and remove user override ([feast-dev#3246](feast-dev#3246)) ([164e666](feast-dev@164e666)) * Add postgres to the feature server Dockerfile to fix helm chart flow ([feast-dev#3261](feast-dev#3261)) ([6f6cbb7](feast-dev@6f6cbb7)) * Add stream feature view in the Web UI ([feast-dev#3257](feast-dev#3257)) ([1f70b3a](feast-dev@1f70b3a)) * Build dockerfile correctly ([feast-dev#3239](feast-dev#3239)) ([a2dc0d0](feast-dev@a2dc0d0)) * Configuration to stop coercion of tz for entity_df ([feast-dev#3255](feast-dev#3255)) ([97b7ab9](feast-dev@97b7ab9)) * Enable users to upgrade a batch source into a push source ([feast-dev#3213](feast-dev#3213)) ([1b312fb](feast-dev@1b312fb)) * Fix docker image for feature-server ([feast-dev#3272](feast-dev#3272)) ([eff01d1](feast-dev@eff01d1)) * Fix Feast UI release process to update the feast-ui package ([feast-dev#3267](feast-dev#3267)) ([a9d48d0](feast-dev@a9d48d0)) * Return 422 on bad push source name ([feast-dev#3214](feast-dev#3214)) ([b851e01](feast-dev@b851e01)) * Stream feature view meta undefined created_timestamp issue ([feast-dev#3266](feast-dev#3266)) ([12e1a8f](feast-dev@12e1a8f)) * Stream feature view not shown in the UI ([feast-dev#3251](feast-dev#3251)) ([e713dda](feast-dev@e713dda)) * Udf in stream feature view UI shows pickled data ([feast-dev#3268](feast-dev#3268)) ([0728117](feast-dev@0728117)) * Update snowflake materialization messages ([feast-dev#3230](feast-dev#3230)) ([a63d440](feast-dev@a63d440)) * Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([feast-dev#3271](feast-dev#3271)) ([b9b9c54](feast-dev@b9b9c54)) * Use configured user in env var instead of "user" for Trino ([feast-dev#3254](feast-dev#3254)) ([532d8a1](feast-dev@532d8a1)) ### Features * Add mysql as online store ([feast-dev#3190](feast-dev#3190)) ([cb8db84](feast-dev@cb8db84)) * Add possibility to define feature_store.yaml path with env variable ([feast-dev#3231](feast-dev#3231)) ([95fdb19](feast-dev@95fdb19)) * Add request_timeout setting for cassandra online store adapter ([feast-dev#3256](feast-dev#3256)) ([da20757](feast-dev@da20757)) * Add tag description in Field in the Feast UI ([feast-dev#3258](feast-dev#3258)) ([086f279](feast-dev@086f279)) * Adding billing_project_id in BigQueryOfflineStoreConfig ([feast-dev#3253](feast-dev#3253)) ([f80f05f](feast-dev@f80f05f)) * BigTable online store ([feast-dev#3140](feast-dev#3140)) ([6bc91c2](feast-dev@6bc91c2)), closes [/github.com/spulec/moto/blob/master/CHANGELOG.md#400](https://github.com//github.com/spulec/moto/blob/master/CHANGELOG.md/issues/400) * Filter subset features in postgres [feast-dev#3174](feast-dev#3174) ([feast-dev#3203](feast-dev#3203)) ([b48d36b](feast-dev@b48d36b))

fix udf in stream feature view UI shows pickeled data

7017ada

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

feast-ci-bot added the size/S label Oct 4, 2022

adchia approved these changes Oct 4, 2022

View reviewed changes

feast-ci-bot assigned adchia Oct 4, 2022

feast-ci-bot added lgtm approved labels Oct 4, 2022

fix lint

d3e1c0b

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

feast-ci-bot removed the lgtm label Oct 4, 2022

hao-affirm added 3 commits October 4, 2022 11:50

fix lint

a6039bc

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

fix test

80f6a36

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

fix lint

4db494f

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

adchia approved these changes Oct 4, 2022

View reviewed changes

feast-ci-bot added the lgtm label Oct 4, 2022

feast-ci-bot merged commit 0728117 into feast-dev:master Oct 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Udf in stream feature view UI shows pickled data #3268

fix: Udf in stream feature view UI shows pickled data #3268

hao-affirm commented Oct 4, 2022

adchia left a comment

codecov-commenter commented Oct 4, 2022 •

edited

Loading

hao-affirm commented Oct 4, 2022

adchia left a comment

feast-ci-bot commented Oct 4, 2022

fix: Udf in stream feature view UI shows pickled data #3268

fix: Udf in stream feature view UI shows pickled data #3268

Conversation

hao-affirm commented Oct 4, 2022

adchia left a comment

Choose a reason for hiding this comment

codecov-commenter commented Oct 4, 2022 • edited Loading

Codecov Report

hao-affirm commented Oct 4, 2022

adchia left a comment

Choose a reason for hiding this comment

feast-ci-bot commented Oct 4, 2022

codecov-commenter commented Oct 4, 2022 •

edited

Loading