Update to upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR allows configuring the project holding the GCR registry when used in connection with 'create_service_account'=true and grant_registry_access=true. Holding the GCR is a project with other resources increases the risk of exposing sensitive data to the service account running the nodes, as the required permissions of role roles/storage.objectViewer provide access to all storage objects in the project.
Added standalone ACM submodule, embedded acm to examples/simple_zonal. Fixes #268
* Fix #258 * Added test `simple_regional_skip_local_exec` * Remove old upgrading guide from README's
Add a parameter 'registry_project_id' to the GKE module templates
Pull from upstream
Make default metadata, labels and tags optional in beta private cluster
Merge from master
…ate_endpoint is false
Add submodule to set up ACM
…ations Don't attempt to set node_locations on pools if unspecified
Improve templating by removing *.tf in autogen and using *.tf.tmpl
Private zonal example
Add dependency so helm is not going to access the cluster before it is up and running
…sd-count Add support for local_ssd_count in node config
Cluster wait for resource
ghost
approved these changes
Nov 20, 2019
11mariom
pushed a commit
that referenced
this pull request
Nov 26, 2019
Removed kubernetes dashboard add config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need it for: