-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update rcgen to 0.12 #334
Conversation
8eb6a9f
to
39be4cc
Compare
Update several dependencies to pull ring version to 0.17. Upstreamed to quinn-rs/quinn#1751 and fishfolk/bones#334.
Update several dependencies to pull ring version to 0.17. Upstreamed to quinn-rs/quinn#1751 and fishfolk/bones#334.
Hi @hack3ric and thanks for this! I'm sorry I missed the PR and hadn't seen it until now. We're going to look at cleaning up the dependabot PRs so that doesn't happen again. Anyway, I want to wait on merging this until @MaxCWhitehead can check it out and we can make sure we get #355 and this PR merged without conflicts. Very curious about Jumpy on RISC-V, though! What platform are you thinking of targeting? |
There are a few RISC-V boards that can do PCIe and use AMD graphics card (e.g. Milk-V Pioneer and HiFive Unmatched), there's not much of a difference compared to x86 PCs. However SBCs like VisionFive 2 have iGPUs that could only run OpenGL ES. I'm not really sure if Bevy really supports it on Linux. But even if they do, their proprietary GPU driver is a huge issue... |
## Changes - Update `deny.toml` -- remove deprecated keys & opt-in to new behavior (see [relevant cargo-deny change](EmbarkStudios/cargo-deny#611)) - Add `MPL-2.0` to allowed licenses - Upgrade packages: - `async-channel`: 1.7, 1.8, 1.9 to 2.2 - `async-io`: 1.9 to 2.3 - `bevy`: 0.11 to 0.12 - `bevy_egui`: 0.22 to 0.24 - `bevy_prototype_lyon`: 0.9 to 0.10 - `egui`, `egui_plot`: 0.23 to 0.24 - `event-listener`: 3.1 to 4.0 - `futures-lite`: 1.12, 1.13 to 2.3 - `ggrs`: 0.9.4 to 0.10.1 - `mdns-sd`: 0.7 to 0.10 - `mio`: 0.8.10 to 0.8.11 - `noise`: 0.8 to 0.9 - `rcgen`: 0.10, 0.11 to 0.12 - `shlex`: 1.2 to 1.3 I avoided making the same upgrade as #334 but these PRs cause a merge conflict in `Cargo.lock`. Whichever is merged second should delete the lock file and rebuild.
We updated rcgen 0.12 in #355 - will close this one. Sorry missed this PR for so long! Thank you :) |
I am trying to make Jumpy working on RISC-V. rcgen 0.12 uses ring 0.17, which brings support for platforms like RISC-V and LoongArch. This shrinks ring 0.16 dependent to only quinn, whose ring upgrade is discussed in quinn-rs/quinn#1715 and quinn-rs/quinn#1751.
All tests pass after introducing the upgrade.