-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ring to 0.17.7 #1751
Upgrade ring to 0.17.7 #1751
Conversation
ring 0.17.7 brings new platform support such as RISC-V and LoongArch, and is in line with rustls' ring version, thus avoiding multiple ring packages of different versions to be built.
See #1715. |
Sorry about not digging deeper. I didn't find introducing solely ring upgrade causing any incompatibilities while working on building on RISC-V. I guess it could be better to merge the ring upgrade part and release the non-breaking changes first? |
Update several dependencies to pull ring version to 0.17. Upstreamed to quinn-rs/quinn#1751 and fishfolk/bones#334.
Update several dependencies to pull ring version to 0.17. Upstreamed to quinn-rs/quinn#1751 and fishfolk/bones#334.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since rustls 0.21.10 switched to ring 0.17, this does seem like an easy win. Am I forgetting something?
|
Ah, right, it's a breaking change, so we can't release it alone without excessive churn, and it's a trivial enough change that there's not really any benefit from merging it early otherwise. Still, thanks for bringing it up! |
ring 0.17.7 brings new platform support such as RISC-V and LoongArch, and is in line with rustls' ring version, thus avoiding multiple ring packages of different versions to be built.