Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ring to 0.17.7 #1751

Closed
wants to merge 1 commit into from
Closed

Conversation

hack3ric
Copy link

ring 0.17.7 brings new platform support such as RISC-V and LoongArch, and is in line with rustls' ring version, thus avoiding multiple ring packages of different versions to be built.

ring 0.17.7 brings new platform support such as RISC-V and LoongArch, and is in line with rustls' ring version, thus avoiding multiple ring packages of different versions to be built.
@djc
Copy link
Member

djc commented Jan 28, 2024

See #1715.

@hack3ric
Copy link
Author

See #1715.

Sorry about not digging deeper. I didn't find introducing solely ring upgrade causing any incompatibilities while working on building on RISC-V. I guess it could be better to merge the ring upgrade part and release the non-breaking changes first?

hack3ric added a commit to hack3ric/archriscv-packages that referenced this pull request Jan 28, 2024
Update several dependencies to pull ring version to 0.17. Upstreamed to quinn-rs/quinn#1751 and fishfolk/bones#334.
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request Jan 28, 2024
Update several dependencies to pull ring version to 0.17. Upstreamed to quinn-rs/quinn#1751 and fishfolk/bones#334.
Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since rustls 0.21.10 switched to ring 0.17, this does seem like an easy win. Am I forgetting something?

@zh-jq-b
Copy link

zh-jq-b commented Jan 29, 2024

Since rustls 0.21.10 switched to ring 0.17, this does seem like an easy win. Am I forgetting something?

#1678

@Ralith
Copy link
Collaborator

Ralith commented Jan 29, 2024

Ah, right, it's a breaking change, so we can't release it alone without excessive churn, and it's a trivial enough change that there's not really any benefit from merging it early otherwise. Still, thanks for bringing it up!

@Ralith Ralith closed this Jan 29, 2024
@hack3ric hack3ric deleted the upgrade-ring branch March 1, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants