Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

null safety #549

Merged
merged 18 commits into from
Feb 24, 2021
Merged

null safety #549

merged 18 commits into from
Feb 24, 2021

Conversation

lig
Copy link
Contributor

@lig lig commented Nov 28, 2020 •
edited
Loading

This is a work in progress.

ordered_set uses override to a branch in my fork until this is merged bluefireteam/ordered_set#5.

As for now, nothing is done in the flame code itself.

Todo:

  • prepare main pubspec.yaml file
  • migrate main dependencies
  • migrate main code
  • prepare examples pubspec.yaml files
  • migrate examples dependencies
  • migrate examples code
  • ensure CI passes
  • changelog entry
  • rebase on master with null safety backports merged in
  • Dashbook null safety release

@lig lig changed the base branch from master to null-safety November 28, 2020 22:08
@lig lig marked this pull request as draft November 28, 2020 22:10
@lig lig mentioned this pull request Nov 28, 2020
Closed
@unger1984
Copy link
Contributor

I fork your branch and complete null-safety prepare. Please, merge my work to your branch https://github.com/unger1984/flame/tree/null-safety

@lig lig force-pushed the null-safety branch 2 times, most recently from 3a6974a to 449ac1c Compare December 3, 2020 09:43
lig
lig commented Dec 3, 2020
View reviewed changes
Copy link
Contributor Author

@lig lig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luanpotter could you please answer the questions?

lib/effects/effects.dart Show resolved Hide resolved
lib/effects/effects.dart Show resolved Hide resolved
lib/particles/computed_particle.dart Outdated Show resolved Hide resolved
@lig lig mentioned this pull request Dec 3, 2020
Merged
8 tasks
@lig
Copy link
Contributor Author

lig commented Dec 3, 2020

@luanpotter should I target #553 to the develop branch?

@lig lig requested a review from luanpotter December 3, 2020 10:22
@lig lig marked this pull request as ready for review December 3, 2020 10:22
@lig
Copy link
Contributor Author

lig commented Dec 3, 2020

So, it turns out that doc/examples/widgets has dashbook as its dependency. Need to migrate this one.

@lig
Copy link
Contributor Author

lig commented Dec 3, 2020

dashbook null safety PR: bluefireteam/dashbook#25

@lig lig marked this pull request as draft December 3, 2020 22:58
@lig
Copy link
Contributor Author

lig commented Dec 3, 2020

Until dashbook has null safety support I'm marking this as a Draft.

luanpotter
luanpotter reviewed Dec 5, 2020
View reviewed changes
README-RU.md Outdated Show resolved Hide resolved
luanpotter
luanpotter reviewed Dec 5, 2020
View reviewed changes
lib/text_config.dart Outdated Show resolved Hide resolved
@lig lig requested review from luanpotter and spydon December 5, 2020 21:27
@lig
Copy link
Contributor Author

lig commented Jan 11, 2021

+564 −592
less code -- fewer bugs:)

@spydon
Update README to point at rc5 (flame-engine#630)
d39d672 
* Update README to point at rc5

* Update README.md
lig and others added 4 commits January 17, 2021 11:10
@lig
👌 Throw exception from parseAnchor in examples/widgets instead of…
1404ee8 
… returning null (flame-engine#632)
@wolfenrain @erickzanardo
Updated the widgets docs (flame-engine#628)
958b4a2 
Co-authored-by: Erick <erickzanardoo@gmail.com>
@erickzanardo
Removing initialDimensions and removeGesture methods (flame-engine#627)
6b17970 
* Removing initialDimensions and removeGesture methods

* Removing wrongly commited folder

* PR suggestion
@erickzanardo
Making SpriteComponent and SpriteAnimationComponent follow the same s…
0889a29 
…tandard for empty constructors (flame-engine#620)
wolfenrain and others added 2 commits January 18, 2021 00:15
renancaraujo and others added 6 commits January 20, 2021 09:05
@renancaraujo @lig @erickzanardo
Move files to src and comply with the dart package layout convention (f…
00ad86e 
…lame-engine#621)

* 👌 Use `Offset` type directly in `JoystickAction.update` calculations (flame-engine#631)

* Move files to src and comply with the dart package layout convention

* Fixing widgets example

Co-authored-by: Serge Matveenko <lig@countzero.co>
Co-authored-by: Erick Zanardo <erickzanardoo@gmail.com>
@spydon
Fix gesture detection on children (flame-engine#636)
d007019 
* Fix gesture detection on children

* Remove unused imports

* positionParent should be private

* Fixed comment

* Moved parent to BaseComponent

* Fix formatting
@wolfenrain
Initial implementation of the Composition class. (flame-engine#634)
5f52dcd 
* Initial implementation of the Composition class

* Added decodeImageFromPixels web support
@wolfenrain
Added a required to GameWidget and updated the docs (flame-engine#638)
ddcd679 
* Added a required to GameWidget and updated the docs

* Removed entry from CHANGELOG
@spydon
Release v1.0.0-rc6 (flame-engine#639)
192bc2f
@spydon
Add hitbox to PositionComponent (flame-engine#618)
2b873ee 
* Move out collision detection methods

* Add possibility to define a hull for PositionComponents

* Add example of how to use hull with tapable

* Update contains point comment

* Fix contains point

* Hull should be based on center position

* Remove collision detection parts

* Added tests

* Use percentage of size instead of absolute size

* Separate hull from PositionComponent

* Clarify hull example

* Fix formatting

* Override correct method

* Use mixin for hitbox

* Update changelog

* Rename HasHitbox to Hitbox

* Clarified names

* Center to edge is considered as 1.0

* Fix test

* Add spaces within braces

* Removed extra spaces in the braces

* Add hitbox docs

* Fix link

* Moved point rotation to Vector2 extension

* Render hitbox within extension

* Fix rebase

* Fix rebase

* Fix formatting
@lig
Copy link
Contributor Author

lig commented Jan 21, 2021

Updated to rc6.

Going to extract lib/src/components/mixins/hitbox.dart fixes into a separate PR targeted to master (cc: @spydon).

@spydon
Copy link
Member

spydon commented Jan 21, 2021

Updated to rc6.

Going to extract lib/src/components/mixins/hitbox.dart fixes into a separate PR targeted to master (cc: @spydon).

Might not be worth doing that already, because there will be a lot of changes to that in the collision detection branch.

@lig
Copy link
Contributor Author

lig commented Jan 21, 2021

Might not be worth doing that already, because there will be a lot of changes to that in the collision detection branch.

It's not a lot but I would like to see that early in to avoid spreading possible nullable values in null unsafe code.

erickzanardo and others added 5 commits January 25, 2021 08:53
@erickzanardo
Removing Util.dart and moving its remaining parts to better places (f…
a754f8f 
…lame-engine#640)

* Removing Util.dart and moving its remaining parts to better places

* Fixing lint

* Doc fixes

* Doc fixes

* PR suggestions
@erickzanardo
Adapting SpriteBatchComponent constructors to other components (flame…
9eb08a0 
…-engine#643)
@erickzanardo @wolfenrain
Adapting ParallaxComponent constructors to other components (flame-en…
718379a 
…gine#642)

* Adapating ParallaxComponent constructors to other components

* Removing wrongly commited folder

* Update doc/components.md

Co-authored-by: Jochum van der Ploeg <jochum@vdploeg.net>

* Update doc/components.md

Co-authored-by: Jochum van der Ploeg <jochum@vdploeg.net>

Co-authored-by: Jochum van der Ploeg <jochum@vdploeg.net>
@erickzanardo
Updating mds with recently 0.x patches
68865fc
@lig
🏷 Null safety support
a6e8002
@spydon spydon merged commit 0420830 into flame-engine:null-safety Feb 24, 2021
@lig
Copy link
Contributor Author

lig commented Feb 25, 2021

🎉

@lig lig deleted the null-safety branch March 10, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unger1984 unger1984 unger1984 left review comments

@luanpotter luanpotter Awaiting requested review from luanpotter

@spydon spydon Awaiting requested review from spydon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lig @unger1984 @spydon @luanpotter @wolfenrain @erickzanardo @renancaraujo