Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backporting #53 to FCL 0.3 #141

Merged
merged 3 commits into from
Jul 22, 2016
Merged

Backporting #53 to FCL 0.3 #141

merged 3 commits into from
Jul 22, 2016

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jul 21, 2016

as requested.

What I'm not sure is how FCL_ABI_VERSION should be updated.

jslee02 added 3 commits July 21, 2016 18:24
@jslee02
Add tests to show fcl 0.3.2 that returns different results for obj1-o…
a60a0b4 
…bj2 and obj2-obj1
@jslee02
Use same shape algorithms for the reverse case
848d6eb 
(cherry picked from commit 7609e1f)
Remove redundant tests in test_fcl_geometric_shapes.cpp

(cherry picked from commit fcc931d)
Fix typo: uncommnet --> uncomment

(cherry picked from commit d277922)
Remove comment related to ellipsoid which is not merged to master branch yet

(cherry picked from commit 9ed22c3)
@jslee02
Bump version to 0.3.3
9e1f660
@jslee02 jslee02 added this to the FCL 0.3.3 milestone Jul 21, 2016
@wjwwood
Copy link
Contributor

wjwwood commented Jul 21, 2016

@jslee02 I was just trying this locally and I ran into this issue: #132

I looked through our release pipeline and I don't see any patches to address this... It's strange to me that what we're using to release 0.3.2 is compiling, but this branch is not compiling locally...

@wjwwood
Copy link
Contributor

wjwwood commented Jul 21, 2016

Actually, the 0.3.2 tag doesn't compile either 😨. I'll keep looking into this issue.

@wjwwood
Copy link
Contributor

wjwwood commented Jul 21, 2016

I figured out my issue. This is a problem anytime you have fcl installed to the same place as one of the dependencies, like octomap, and the installed config.h is different from the one you generated while building. I'll open a pr.

@jslee02
Copy link
Member Author

jslee02 commented Jul 22, 2016

Interesting. I've never encountered the issue even though I think I had fcl installed when building another fcl. Anyways, you resolved the mysterious building issue (#132) to me. Thanks!

@jslee02 jslee02 mentioned this pull request Jul 22, 2016
Merged
@jslee02 jslee02 merged commit 50a87ce into fcl-0.3 Jul 22, 2016
@jslee02 jslee02 deleted the backport_pr53_to_0.3 branch July 22, 2016 02:32
@k-okada k-okada mentioned this pull request Jul 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Will merge soon unless anyone has an objection
Projects
None yet
Milestone
FCL 0.3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jslee02 @wjwwood