Fixing missing assignment in Convex class #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -278,6 +278,7 @@ class Convex : public ShapeBase | |||
| plane_dis = plane_dis_; | |||
| num_planes = num_planes_; | |||
| points = points_; | |||
| num_points = num_points_; | |||
There was a problem hiding this comment.
How did this ever work without this fix?
There was a problem hiding this comment.
Did it? I do not see any unit tests related to the Convex shape...
isucan
added a commit
that referenced
this pull request
Jul 17, 2015
Fixing missing assignment in Convex class
|
@k-okada I think it's possible. Could you send a pull request for it? I might not able to to this right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I understand the Convex class is not really supported, yet the missing assignment is an error as it is used uninitialized.