Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Multi-File AST #965

Draft
wants to merge 59 commits into
base: main
Choose a base branch
from
Draft

Expose Multi-File AST #965

wants to merge 59 commits into from

Conversation

LukasPietzschmann
Copy link
Collaborator

No description provided.

@LukasPietzschmann LukasPietzschmann added enhancement New feature or request normalize Related to R-AST extraction and normalization labels Sep 10, 2024
@LukasPietzschmann LukasPietzschmann self-assigned this Sep 10, 2024
@LukasPietzschmann LukasPietzschmann linked an issue Sep 10, 2024 that may be closed by this pull request
Expose Multi-File AST #874
Open
@LukasPietzschmann
Copy link
Collaborator Author

LukasPietzschmann commented Sep 10, 2024 •
edited
Loading

@EagleoutIce if you've got time, you can take a look at the code. There is still a TODO I have to implement, but the rest should reviewable :)

Also, there's an error at the end of this line:

flowr/src/cli/repl/server/connection.ts

Line 153 in 7dcdbe6

parse: await printStepResult(PARSE_WITH_R_SHELL_STEP, sanitizedResults.parse as string, StepOutputFormat.RdfQuads, config()),

I can't really make sense of it. Maybe you can assist me with that.

@EagleoutIce
Copy link
Member

sadly i do not have a lot of time at the moment, but looking at it the first time, suggest that it may be the as cast which wrongly tries to handle the striing aray as a strin

EagleoutIce and others added 21 commits September 12, 2024 10:05
@EagleoutIce @LukasPietzschmann
test: targeted the problem with a unit test
26214dc
@EagleoutIce @LukasPietzschmann
wip: working on forced arguments
1393d2b
@EagleoutIce @LukasPietzschmann
feat: working on forced arguments
2b88173
@EagleoutIce @LukasPietzschmann
feat: a lot of fixes and tears
9358e5b
@EagleoutIce @LukasPietzschmann
lint-fix: handle linter errors
406c5ad
@LukasPietzschmann @EagleoutIce
Add additional ":lineage" command and message (#915)
a33b8ce 
* feat: first attempt at the new getLineage command

* feat: walk additional edges for determining the lineage

* feat: store lineage IDs in a set

* feat: prevent infinite recursion when determining the lineage IDs

* feat-fix: fixed lineage network request

* feat-fix: get the dfg and ast from the pipeline in the correct way

* doc: added lineage request doc

* feat-fix: add filetoken to error messages

Co-authored-by: Florian Sihler <florian.sihler@uni-ulm.de>

* feat-fix: updated comment for better clarity

* feat-fix: more guards, more better

* feat-fix: clearer function interface

* feat-fix: removed unused import

No I didn't push with --no-verify

* feat-fix: removed console.log

Co-authored-by: Florian Sihler <florian.sihler@uni-ulm.de>

* feat-fix: criteria resolve now only requires an idmap

* test(lineage): basic test setup

* lint-fix: handle linter issues and empty test labels

* refactor(lineage): remove redundant promise

* doc(lineage): refine wiki entries

---------

Co-authored-by: Florian Sihler <florian.sihler@uni-ulm.de>
@EagleoutIce @LukasPietzschmann
Recognize setwd as a side effect (#933)
c7f98ec 
* feat: support `setwd`

* lint-fix: handle linter errors
@EagleoutIce @LukasPietzschmann
options, set.seed, and on.exit may have global side effects! (#934
fedf248 
)

* feat: support `set.seed`

* feat: recognize options as side effect as well

* feat: support `on.exit` (closes #931)

* feat: supporting `sys.on.exit`

* lint-fix: handle linter errors
@EagleoutIce @LukasPietzschmann
[release:patch] Forcing Arguments, Improved Side-Effect Detection, an…
4f12b7f 
…d Lineage Command
@actions-user @LukasPietzschmann
[skip ci] Release v2.0.17
0976ad7
@actions-user @LukasPietzschmann
[skip ci] doc: new benchmark data
4fe851d
@EagleoutIce @LukasPietzschmann
feat(wip-select): deprecate and remove the old automatic selector
fa1f8df
@EagleoutIce @LukasPietzschmann
feat: side-effects for common installer functions
f294be7
@EagleoutIce @LukasPietzschmann
test: adapt tests to reflect unknown side effects for libraries
30e323d
@EagleoutIce @LukasPietzschmann
test: have some tests for the library loading
647bfaa
@EagleoutIce @LukasPietzschmann
feat-fix: reconstruction should, if unsure, keep arguments!
92fb2c0
@EagleoutIce @LukasPietzschmann
feat-fix: solve by additional read edges if treating indices as string
cad63dc
@EagleoutIce @LukasPietzschmann
feat: redefine := within no string access operations
50a3a4c
@EagleoutIce @LukasPietzschmann
test: add backing tests for the definitions
3b97096
@EagleoutIce @LukasPietzschmann
refactor: minor tune of known fn call handling
40cf209
@EagleoutIce @LukasPietzschmann
test: specify our goal with a few tests :)
f781b26
EagleoutIce and others added 17 commits September 12, 2024 10:05
@EagleoutIce @LukasPietzschmann
test: adding a test case for the problem
e1c8301
@EagleoutIce @LukasPietzschmann
feat-fix: loop environment recovery
ee5bb29
@EagleoutIce @LukasPietzschmann
refactor: clean up todos
31ed6da
@EagleoutIce @LukasPietzschmann
lint-fix: handle linter errors
1fbc358
@EagleoutIce @LukasPietzschmann
[release:patch] Fix: Overshadow Built-Ins in Loops
1b4c8c8
@actions-user @LukasPietzschmann
[skip ci] Release v2.0.20
2c4c44e
@actions-user @LukasPietzschmann
[skip ci] doc: new benchmark data
f2cfc70
@Ellpeck @LukasPietzschmann
ci: try to pass the version output between jobs
d1818b0
@Ellpeck @LukasPietzschmann
docs: update incorrect messages in benchmark data
931a520
@actions-user @LukasPietzschmann
[skip ci] doc: update capabilities
bc55b04
@EagleoutIce @LukasPietzschmann
feat-fix: include CDs based on nesting depth!
ca3fd54
@EagleoutIce @LukasPietzschmann
feat-fix: function argument position forced by mapply
819c010
@EagleoutIce @LukasPietzschmann
feat-fix: nested data frame reassignments
33f0d1b
@EagleoutIce @LukasPietzschmann
[release:patch] Fix mapply, Nested Data-Frame-Assignments, and CD N…
bca1634 
…estings
@actions-user @LukasPietzschmann
[skip ci] Release v2.0.21
c79b1b8
@actions-user @LukasPietzschmann
[skip ci] doc: new benchmark data
72dedc3
@LukasPietzschmann
feat-fix: fixed typing error
2cb8be4
@EagleoutIce
Copy link
Member

EagleoutIce commented Sep 12, 2024 •
edited
Loading

what happened with you now being a co-signed author on all of these commits?

@LukasPietzschmann
Copy link
Collaborator Author

I rebased this branch onto main ':)

@EagleoutIce
Copy link
Member

I pushed a respective fix which causes the parsing to happen sequentially! However, I still noticed that any additional file is normalized an additional time; i.e. there is another normalize call for this. Can you track that down? it is probably due to someone somewhere still not assuming the multifile ast exists (probably my old code) and just triggering a new parsing

@EagleoutIce
Copy link
Member

If you are ready, i will take on the merge regarding the 3-version upgrades we have

@EagleoutIce
Copy link
Member

Additionally, the case you established should probably be added as a test case to avoid regression.

@EagleoutIce EagleoutIce marked this pull request as draft October 25, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EagleoutIce EagleoutIce Awaiting requested review from EagleoutIce

At least 1 approving review is required to merge this pull request.

Assignees

@LukasPietzschmann LukasPietzschmann

Labels
enhancement New feature or request normalize Related to R-AST extraction and normalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose Multi-File AST
4 participants
@LukasPietzschmann @EagleoutIce @actions-user @Ellpeck