Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vector_graphics] Initial import #7941

Merged
merged 211 commits into from
Oct 31, 2024

Conversation

stuartmorgan
Copy link
Contributor

@stuartmorgan stuartmorgan commented Oct 28, 2024

Imports https://github.com/dnfield/vector_graphics into this repository, with history, and updates it to follow repository conventions:

  • Adds missing licence headers.
  • Removes analysis options and fixes resulting warnings.
  • Updates min SDKs.
  • Autoformats.
  • Updates pubspecs to follow repo standard, including updating the metadata
    to point to the Flutter repositories.
  • Allows xml as a pinned dependency, and relaxes the pinning requirement
    in the repo tools to allow an explicit, inclusive-endpoint range.
  • Skips some unit tests on unsupported platforms.
  • Adds repo metadata.
  • Bumps versions and slightly relax version constraints to allow the new
    versions.

dnfield and others added 30 commits February 28, 2022 12:54
Add VectorGraphics codec and assorted classes
Co-authored-by: Jonah Williams <campfish91@gmail.com>
Co-authored-by: Jonah Williams <campfish91@gmail.com>
Add paint, vertices, indexed vertices, and tests
dnfield and others added 9 commits October 11, 2023 14:51
flutter#218)

* Avoid stack overflow when self-referential elemetns present, only use first ID

* bumps
flutter#227)

* oops

* Fix scientific notation parsing

* Update packages/vector_graphics_compiler/test/parsers_test.dart

Co-authored-by: Jonah Williams <jonahwilliams@google.com>

* Fix up analysis issues and half implemented test

---------

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
Skia's SkCanvas::saveLayer does not implicitly clip to the bounds rect.

See flutter/flutter#142620
* Use package http

* delete test
Copy link

google-cla bot commented Oct 28, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@stuartmorgan stuartmorgan force-pushed the import-vector-graphics branch from e6ca39a to 1aecf7a Compare October 28, 2024 14:22
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan force-pushed the import-vector-graphics branch 2 times, most recently from 045598a to 77c9330 Compare October 28, 2024 17:02
- Add missing licence headers.
- Remove analysis options fix new warnings.
- Update min SDKs.
- Autoformat.
- Update pubspecs to follow repo standard.
  - Includes removing dependency overrides for inter-package path
    pinning as a default state; this can be added temporarily in PRs
    with repo tooling.
- Allow xml dependency, and relax the pinning requirement to allow an
  explicit, inclusive-endpoint range.
- Skip tests on unsupported platforms.
- Switch vector_graphics_codec from flutter_test to test.
- Add repo metadata.
- Add commemoration to the README.
- Add AUTHORS files.
- Bump versions and slightly relax version constraints to allow the new
  versions.
@stuartmorgan stuartmorgan force-pushed the import-vector-graphics branch from 77c9330 to a1bfadf Compare October 28, 2024 18:51
@stuartmorgan stuartmorgan merged commit 92238bf into flutter:main Oct 31, 2024
76 checks passed
@stuartmorgan stuartmorgan deleted the import-vector-graphics branch October 31, 2024 17:35
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 1, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 1, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 1, 2024
flutter/packages@7cc1caa...796afa3

2024-11-01 stuartmorgan@google.com [google_maps_flutter] Update Android for non-nullable generics (flutter/packages#7990)
2024-11-01 stuartmorgan@google.com [various] Minor cleanup in recently imported packages (flutter/packages#7995)
2024-11-01 stuartmorgan@google.com [go_router] Update example app to Kotlin 1.9.0 (flutter/packages#7997)
2024-10-31 engine-flutter-autoroll@skia.org Manual roll Flutter from fe71cad to 0fe6153 (18 revisions) (flutter/packages#7989)
2024-10-31 kevmoo@users.noreply.github.com [vector_garphics] fix execution on the web with WebAssembly (flutter/packages#7991)
2024-10-31 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.9.0 to 1.9.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7986)
2024-10-31 stuartmorgan@google.com [flutter_svg] Initial import (flutter/packages#7944)
2024-10-31 stuartmorgan@google.com [vector_graphics] Initial import (flutter/packages#7941)
2024-10-30 stuartmorgan@google.com [ci] Ensure repo tool is autoformatted (flutter/packages#7963)
2024-10-30 zanderso@users.noreply.github.com Updates path_parsing README.md with a note about Dan (flutter/packages#7949)
2024-10-30 stuartmorgan@google.com [tool] Support third_party for --current-package (flutter/packages#7967)
2024-10-30 stuartmorgan@google.com [tool] Fix third_party dependency overrides (flutter/packages#7966)
2024-10-30 jessiewong401@gmail.com Applied Gradle Plugins Declaratively for `path_provider` (flutter/packages#7822)
2024-10-30 stuartmorgan@google.com [palette_generator] Remove unmanaged code snippet (flutter/packages#7962)
2024-10-30 engine-flutter-autoroll@skia.org Roll Flutter from 42132e8 to fe71cad (12 revisions) (flutter/packages#7961)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kevmoo added a commit that referenced this pull request Dec 18, 2024
auto-submit bot pushed a commit that referenced this pull request Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.