-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_svg] Initial import #7944
Conversation
implicit-cast
support transform on use
fix color filtering
Fix for use with groups
Entitlements for network access on macOS, and a typo.
…s before decoding them.
Strip all whitespace instead of only spaces from base64 encoded images.
Diagnosticable => DiagnosticableMixin
Allow additional whitespace between transform commands.
…lutter#1000) * Fixed the hashcode in SvgStringLoader and SvgBytesLoader. It was accidently using the svg global object, instead of a local field. This caused caches (such as PaintingBinding.instance.imageCache) to misbehave. * Add a test which ensures the embedded image in a SvgPicture is not incorrectly cached and carried over.
* Fix semver violation for SvgPicture * fix for older versions of flutter?
Object.operator== takes an `Object`, and no Dart runtime passes a `null` value to an `==` implementation. SvgTheme's implementation should not have an expanded parameter type of `dynamic`. See flutter/flutter#117838 for the overarching issue for Flutter. Co-authored-by: Dan Field <dnfield@google.com>
* Use package:http, drop dart:html * Format
* Relax http * update test package too * format;
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Initial merge commit from dnfield/flutter_svg with no changes other than file locations.
3fb7786
to
0c7e762
Compare
Imports https://github.com/dnfield/flutter_svg into this repository, with history, and updates it to follow repository conventions: - Updates min SDKs. - Removes analysis options and fixes resulting warnings. - Autoformats. - Updates pubspecs to follow repo standard. - Updates repo tooling to allow the `flutter_svg_test` non-dev dependency on `flutter_test`. - Adds repo metadata. - Adds METADATA files. - Adds commemoration to README. - Updates example app Android build files to current standards. - Bumps versions and slightly relax version constraints for vector_graphics* to allow the new versions. - Moves gitignore of golden test diffs into the package.
0c7e762
to
760b8df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/packages@7cc1caa...796afa3 2024-11-01 stuartmorgan@google.com [google_maps_flutter] Update Android for non-nullable generics (flutter/packages#7990) 2024-11-01 stuartmorgan@google.com [various] Minor cleanup in recently imported packages (flutter/packages#7995) 2024-11-01 stuartmorgan@google.com [go_router] Update example app to Kotlin 1.9.0 (flutter/packages#7997) 2024-10-31 engine-flutter-autoroll@skia.org Manual roll Flutter from fe71cad to 0fe6153 (18 revisions) (flutter/packages#7989) 2024-10-31 kevmoo@users.noreply.github.com [vector_garphics] fix execution on the web with WebAssembly (flutter/packages#7991) 2024-10-31 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.9.0 to 1.9.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7986) 2024-10-31 stuartmorgan@google.com [flutter_svg] Initial import (flutter/packages#7944) 2024-10-31 stuartmorgan@google.com [vector_graphics] Initial import (flutter/packages#7941) 2024-10-30 stuartmorgan@google.com [ci] Ensure repo tool is autoformatted (flutter/packages#7963) 2024-10-30 zanderso@users.noreply.github.com Updates path_parsing README.md with a note about Dan (flutter/packages#7949) 2024-10-30 stuartmorgan@google.com [tool] Support third_party for --current-package (flutter/packages#7967) 2024-10-30 stuartmorgan@google.com [tool] Fix third_party dependency overrides (flutter/packages#7966) 2024-10-30 jessiewong401@gmail.com Applied Gradle Plugins Declaratively for `path_provider` (flutter/packages#7822) 2024-10-30 stuartmorgan@google.com [palette_generator] Remove unmanaged code snippet (flutter/packages#7962) 2024-10-30 engine-flutter-autoroll@skia.org Roll Flutter from 42132e8 to fe71cad (12 revisions) (flutter/packages#7961) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Imports https://github.com/dnfield/flutter_svg into this repository, with history, and updates it to follow repository conventions:
flutter_svg_test
non-devdependency on
flutter_test
.vector_graphics* to allow the new versions.