Incorrect format for istio gateways in docs

[chlunde]

Describe the bug

The documentation and some tests uses gw.ns(.svc.cluster.local) for gateways.

I think this is the correct format for istio gateways: <gateway namespace>/<gateway name>

Like here:

flagger/test/istio/test-delegation.sh

Line 41 in 273b05f

- istio-system/istio-ingressgateway

re. https://istio.io/latest/docs/reference/config/networking/virtual-service/#VirtualService

Examples for the alternate syntax:

flagger/pkg/router/istio_test.go

Line 81 in e6c740d

gateways = append(gateways, "test-gateway.istio-system")

flagger/docs/gitbook/faq.md

Lines 505 to 506 in 9c7db58

	gateways:
	- public-gateway.istio-system.svc.cluster.local

flagger/artifacts/examples/istio-canary.yaml

Lines 23 to 24 in e6c740d

	gateways:
	- public-gateway.istio-system.svc.cluster.local

[stefanprodan]

I think both formats work, the dot separator was deprecated in favor of the /, we should update the docs for the latest Istio.

[Abhishek-569]

So we have to replace for example public-gateway.istio-system.svc.cluster.local with public-gateway/istio-system.svc.cluster.local everywhere present in docs?

[stefanprodan]

@Abhishek-569 yes, please open a PR if you have time. Thanks

[Abhishek-569]

Should I open a single PR for all docs ?

[stefanprodan]

Yes please

[Abhishek-569]

okay and there should be more docs that needed these changes other than above mentioned. is there any way to find them once or I have to make changes individually?

[stefanprodan]

Search for gateways in ./docs

[Abhishek-569]

I have found all changes in docs , Do I need to check pkg and artifacts thoroughly?

[stefanprodan]

artifacts/examples yes, pkg no, as in there there are only unit tests that set gateways.

[Abhishek-569]

ok and what about test ?

[stefanprodan]

Oh yeah test/istio needs changing as we use there Istio for e2e and we should test with the latest supported format.

[Abhishek-569]

Created PR in #1377 for this issue.

[Abhishek-569]

I have made the recommended changes. Please have a look into it. Thanks.