Updated the docs with correct istio gateways format. #1377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Abhishek-569 can you please squash all commits into a single one titled "Migrate Istio gateway to new format". Thanks! |
|
done. |
Migrate Istio gateway to new format Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Updated flagger-install-on-google-cloud.md Updated flagger-install-on-google-cloud.md for isitio gateways Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Updated istio-ab-testing.md Updated istio-ab-testing.md for istio Gateways. Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Updated istio-progressive-delivery.md Updated istio-progressive-delivery.md for istio gateways. Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Update1 istio-progressive-delivery.md Update istio-progressive-delivery.md for istio gateways Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Update faq.md Update faq.md for istio gateway. Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Update istio-abtest.yaml Update istio-abtest.yaml for istio gateway. Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Update istio-canary.yaml Update istio-canary.yaml for istio.yaml Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> update test-canary.sh update test-canary.sh for istio gateways Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com>
Abhishek-569
force-pushed
the
docschanges
branch
from
a4ef100 to
a556ca5
Compare
|
Istio tests are now failing with Looks like |
|
So what should be the next step? |
|
The format you used seems wrong, Istio docs are saying
|
|
Replacing flagger/test/istio/test-delegation.sh Line 41 in 273b05f |
|
@Abhishek-569 how are you currently setting the gateways on your cluster? |
|
Don't know how to answer that as I never used istio till now. |
|
@stefanprodan should I close this PR for a new one with the following change: |
Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Update flagger-install-on-google-cloud Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Update istio-ab-testing Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Update istio-progressive-delivery.md Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Update zero-downtime-deployments.md Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Update faq.md Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Update istio-abtest.yaml Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Update istio-canary.yaml Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com>
Abhishek-569
force-pushed
the
docschanges
branch
from
d6db97b to
5df8422
Compare
|
@stefanprodan Can you try the updated PR? |
artifacts/examples/istio-canary.yaml
Outdated
| @@ -21,7 +21,7 @@ spec: | |||
| portName: http | |||
| portDiscovery: true | |||
| gateways: | |||
| - public-gateway.istio-system.svc.cluster.local | |||
| - istio-system.svc.cluster.local/public-gateway | |||
There was a problem hiding this comment.
Have you test this on a cluster? According to Istio docs this is not valid, the prefix should be a namespace not a hostname.
There was a problem hiding this comment.
can you tell me the required tools to test this on a cluster?
Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Update istio-canary.yaml Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Update istio-abtest.yaml Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Update faq.md Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Update zero-downtime-deployments.md Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Update istio-progressive-delivery.md Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Update istio-ab-testing.md Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com> Update flagger-install-on-google-cloud.md Signed-off-by: Abhishek-569 <64806938+Abhishek-569@users.noreply.github.com>
Abhishek-569
force-pushed
the
docschanges
branch
from
2cf085f to
2a7a610
Compare
|
@stefanprodan please check and let me know. |
|
superseded by #1489 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have updated the
docs,/artifacts/examplesand/test/istiowith the correct format of istio gateways according to issue #1104 .Fix: #1104