Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Istio Gateway reference format #1489

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Update Istio Gateway reference format #1489

merged 1 commit into from
Aug 28, 2023

Conversation

sonbui00
Copy link
Contributor

Update format for istio gateways

Fix #1104

Tested:

  • make test
  • e2e-test job with provider istio v1.15, v1.18 (v1.14 does not support my arm64)

@sonbui00 sonbui00 marked this pull request as ready for review August 28, 2023 11:23
@sonbui00 sonbui00 requested a review from stefanprodan as a code owner August 28, 2023 11:23
@stefanprodan stefanprodan changed the title fix: Incorrect format for istio gateways #1104 Update Istio Gateway reference format Aug 28, 2023
stefanprodan
stefanprodan approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @sonbui00 🥇

aryan9600
aryan9600 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! could you please rebase on top of main?

@sonbui00
fix: Incorrect format for istio gateways fluxcd#1104
2e4fe73 
Signed-off-by: Son Bui <sonbv00@gmail.com>
@sonbui00
Copy link
Contributor Author

lgtm! could you please rebase on top of main?

I've made the rebase @aryan9600

@aryan9600 aryan9600 merged commit eb302fe into fluxcd:main Aug 28, 2023
@aryan9600 aryan9600 mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryan9600 aryan9600 aryan9600 approved these changes

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
kind/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect format for istio gateways in docs
3 participants
@sonbui00 @stefanprodan @aryan9600