Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Citadel] Update tutorials #204

Merged
merged 34 commits into from
May 3, 2021
Merged

[Citadel] Update tutorials #204

merged 34 commits into from
May 3, 2021

Conversation

claireyywang
Copy link
Contributor

@claireyywang claireyywang commented Jan 22, 2021

  • Use Doxygen code snippet and image
  • Add example code
  • Update tutorial titles and content

Will forward port this to Dome and main if approved.

anindex and others added 20 commits January 6, 2021 20:48
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
* Initial draft for loading plugin tutorial

Signed-off-by: anindex <an.thai.le97@gmail.com>

* Resolve comments

Signed-off-by: anindex <an.thai.le97@gmail.com>

Co-authored-by: anindex <an.thai.le97@gmail.com>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
* Initial draft for implementing a custom feature
* Update tutorial name in front page
* Change headline names for consistency
* Revised some nitpicks
* Add folder structure for feature

Co-authored-by: anindex <an.thai.le97@gmail.com>
Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
* RemoveModelFromWorld doc
* SetBasicJointState doc
* SetJointVelocity doc
* SetShape* doc
* SetCylinderShapeProperties* doc
* SetFreeGroupWorldPose and Velocity doc
* Refine docs

Co-authored-by: anindex <an.thai.le97@gmail.com>
* Initial draft physics concepts tutorial

Signed-off-by: anindex <an.thai.le97@gmail.com>

* Finalize physics simulation concepts

Signed-off-by: anindex <an.thai.le97@gmail.com>

* Add links to existing manipulating SDF params tutorials

Signed-off-by: anindex <an.thai.le97@gmail.com>

* Revised physics terminology tutorial

Signed-off-by: anindex <an.thai.le97@gmail.com>

* Revised Physics terminology

Signed-off-by: anindex <an.thai.le97@gmail.com>

* Final refine

Signed-off-by: anindex <an.thai.le97@gmail.com>

Co-authored-by: anindex <an.thai.le97@gmail.com>
* Common Attach* feature doc

Signed-off-by: anindex <an.thai.le97@gmail.com>

* Refine docs

Signed-off-by: anindex <an.thai.le97@gmail.com>

Co-authored-by: anindex <an.thai.le97@gmail.com>
Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com>
* Attach* docs

Signed-off-by: anindex <an.thai.le97@gmail.com>

* Refine docs

Signed-off-by: anindex <an.thai.le97@gmail.com>

* Final refine

Signed-off-by: anindex <an.thai.le97@gmail.com>

Co-authored-by: anindex <an.thai.le97@gmail.com>
* GetEngineInfo docs

Signed-off-by: anindex <an.thai.le97@gmail.com>

* GetWorldFromEngine docs

Signed-off-by: anindex <an.thai.le97@gmail.com>

* GetModelFromWorld docs

Signed-off-by: anindex <an.thai.le97@gmail.com>

* GetLinkFromModel docs

Signed-off-by: anindex <an.thai.le97@gmail.com>

* GetJointFromModel docs

Signed-off-by: anindex <an.thai.le97@gmail.com>

* GetShapeFromLink docs

Signed-off-by: anindex <an.thai.le97@gmail.com>

* GetJoint* docs

Signed-off-by: anindex <an.thai.le97@gmail.com>

* GetShape* docs

Signed-off-by: anindex <an.thai.le97@gmail.com>

* GetShapeFriction docs

Signed-off-by: anindex <an.thai.le97@gmail.com>

* Get bounding box docs

Signed-off-by: anindex <an.thai.le97@gmail.com>

* Refine docs

Signed-off-by: anindex <an.thai.le97@gmail.com>

Co-authored-by: anindex <an.thai.le97@gmail.com>
Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
@claireyywang claireyywang added documentation Improvements or additions to documentation 🏰 citadel Ignition Citadel labels Jan 22, 2021
@claireyywang claireyywang self-assigned this Jan 22, 2021
@claireyywang claireyywang linked an issue Jan 22, 2021 that may be closed by this pull request
@claireyywang
Copy link
Contributor Author

@chapulina I addressed your tutorial comments in this PR. Feel free to take a look if you have time .

@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #204 (ac86f6f) into ign-physics2 (671ee8c) will increase coverage by 0.19%.
The diff coverage is n/a.

❗ Current head ac86f6f differs from pull request most recent head 5add03c. Consider uploading reports for the commit 5add03c to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           ign-physics2     #204      +/-   ##
================================================
+ Coverage         82.94%   83.14%   +0.19%     
================================================
  Files               106      106              
  Lines              4034     3998      -36     
================================================
- Hits               3346     3324      -22     
+ Misses              688      674      -14     
Impacted Files Coverage Δ
tpe/lib/src/Model.cc 98.36% <0.00%> (-0.03%) ⬇️
tpe/lib/src/Link.cc 100.00% <0.00%> (ø)
tpe/lib/src/Link.hh 100.00% <0.00%> (ø)
tpe/lib/src/World.cc 100.00% <0.00%> (ø)
tpe/plugin/src/SDFFeatures.cc 84.45% <0.00%> (+1.12%) ⬆️
tpe/plugin/src/FreeGroupFeatures.cc 79.68% <0.00%> (+12.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 671ee8c...5add03c. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a CMakeLists file to examples/simple_tpe_plugin so that it's possible to compile it?

tutorials/03_physics_plugins.md Outdated Show resolved Hide resolved
tutorials/02_installation.md Outdated Show resolved Hide resolved
tutorials/02_installation.md Show resolved Hide resolved
tutorials/04_physics_engines.md Outdated Show resolved Hide resolved
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
@claireyywang
Copy link
Contributor Author

Can we add a CMakeLists file to examples/simple_tpe_plugin so that it's possible to compile it?

I added an example CMakeList but don't think it's working correctly yet. I'm still not sure how exactly CMake links different libraries so it'd take some time to figure that out. I think it'd be preferable to merge the tutorial part of the this PR first, and take the CMake part out for later improvement. What do you think?

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an example CMakeList but don't think it's working correctly yet.

The plugin fails to compile for me with:

/home/chapulina/ws_citadel/src/ign-physics/examples/simple_tpe_plugin/plugin.cc:20:10: fatal error: Base.hh: No such file or directory
 #include "Base.hh"
          ^~~~~~~~~

Looking through the code, I imagine this is supposed to refer to tpe/plugin/src/Base.hh, right? The reason that the example is not being able to find it, is that the header isn't being installed. I suspect this is on purpose though, because we don't need downstream users to be using tpe-plugin, only tpe-lib, right? I haven't looked closely enough to have a suggestion here, but I think that the example needs to be reworked to only use things from tpe-lib, not tpe-plugin.

I think it'd be preferable to merge the tutorial part of the this PR first, and take the CMake part out for later improvement.

I think that the CMake failure exposed a potential problem in the tutorial. I think it's worth it getting it to work before we publish it, so we're sure we're giving users working instructions.

tutorials/09_use_custom_engine.md Outdated Show resolved Hide resolved
tutorials/09_use_custom_engine.md Outdated Show resolved Hide resolved
claireyywang and others added 4 commits February 10, 2021 10:40
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
@chapulina chapulina requested review from scpeters and removed request for maryaB-osr March 8, 2021 19:47
scpeters and others added 5 commits March 8, 2021 11:48
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some tweaks to:

  • Make the example and test compile
  • Maintain the current tutorial URLs, so we don't break existing links to the site
  • Fix snippets

LGTM!

@chapulina chapulina merged commit 966b7ec into ign-physics2 May 3, 2021
@chapulina chapulina deleted the claire/update-tutorials branch May 3, 2021 22:15
chapulina added a commit that referenced this pull request Jun 18, 2021
* [Citadel] Update tutorials (#204)

Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: anindex <an.thai.le97@gmail.com>

Co-authored-by: anindex <an.thai.le97@gmail.com>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>

* Remove tools/code_check and update codecov (#257)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Fix dart deprecation warning (#263)

Copied from #262.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com>
Co-authored-by: anindex <an.thai.le97@gmail.com>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
@azeey azeey mentioned this pull request Sep 14, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use doxygen snippets to reference code in tutorials
4 participants