-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Citadel] Update tutorials #204
Conversation
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
* Initial draft for loading plugin tutorial Signed-off-by: anindex <an.thai.le97@gmail.com> * Resolve comments Signed-off-by: anindex <an.thai.le97@gmail.com> Co-authored-by: anindex <an.thai.le97@gmail.com> Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
* Initial draft for implementing a custom feature * Update tutorial name in front page * Change headline names for consistency * Revised some nitpicks * Add folder structure for feature Co-authored-by: anindex <an.thai.le97@gmail.com> Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
* RemoveModelFromWorld doc * SetBasicJointState doc * SetJointVelocity doc * SetShape* doc * SetCylinderShapeProperties* doc * SetFreeGroupWorldPose and Velocity doc * Refine docs Co-authored-by: anindex <an.thai.le97@gmail.com>
* Initial draft physics concepts tutorial Signed-off-by: anindex <an.thai.le97@gmail.com> * Finalize physics simulation concepts Signed-off-by: anindex <an.thai.le97@gmail.com> * Add links to existing manipulating SDF params tutorials Signed-off-by: anindex <an.thai.le97@gmail.com> * Revised physics terminology tutorial Signed-off-by: anindex <an.thai.le97@gmail.com> * Revised Physics terminology Signed-off-by: anindex <an.thai.le97@gmail.com> * Final refine Signed-off-by: anindex <an.thai.le97@gmail.com> Co-authored-by: anindex <an.thai.le97@gmail.com>
* Common Attach* feature doc Signed-off-by: anindex <an.thai.le97@gmail.com> * Refine docs Signed-off-by: anindex <an.thai.le97@gmail.com> Co-authored-by: anindex <an.thai.le97@gmail.com> Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com>
* Attach* docs Signed-off-by: anindex <an.thai.le97@gmail.com> * Refine docs Signed-off-by: anindex <an.thai.le97@gmail.com> * Final refine Signed-off-by: anindex <an.thai.le97@gmail.com> Co-authored-by: anindex <an.thai.le97@gmail.com>
* GetEngineInfo docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetWorldFromEngine docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetModelFromWorld docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetLinkFromModel docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetJointFromModel docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetShapeFromLink docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetJoint* docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetShape* docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetShapeFriction docs Signed-off-by: anindex <an.thai.le97@gmail.com> * Get bounding box docs Signed-off-by: anindex <an.thai.le97@gmail.com> * Refine docs Signed-off-by: anindex <an.thai.le97@gmail.com> Co-authored-by: anindex <an.thai.le97@gmail.com> Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
@chapulina I addressed your tutorial comments in this PR. Feel free to take a look if you have time . |
Codecov Report
@@ Coverage Diff @@
## ign-physics2 #204 +/- ##
================================================
+ Coverage 82.94% 83.14% +0.19%
================================================
Files 106 106
Lines 4034 3998 -36
================================================
- Hits 3346 3324 -22
+ Misses 688 674 -14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a CMakeLists
file to examples/simple_tpe_plugin
so that it's possible to compile it?
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
I added an example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an example CMakeList but don't think it's working correctly yet.
The plugin fails to compile for me with:
/home/chapulina/ws_citadel/src/ign-physics/examples/simple_tpe_plugin/plugin.cc:20:10: fatal error: Base.hh: No such file or directory
#include "Base.hh"
^~~~~~~~~
Looking through the code, I imagine this is supposed to refer to tpe/plugin/src/Base.hh, right? The reason that the example is not being able to find it, is that the header isn't being installed. I suspect this is on purpose though, because we don't need downstream users to be using tpe-plugin
, only tpe-lib
, right? I haven't looked closely enough to have a suggestion here, but I think that the example needs to be reworked to only use things from tpe-lib
, not tpe-plugin
.
I think it'd be preferable to merge the tutorial part of the this PR first, and take the CMake part out for later improvement.
I think that the CMake failure exposed a potential problem in the tutorial. I think it's worth it getting it to work before we publish it, so we're sure we're giving users working instructions.
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed some tweaks to:
- Make the example and test compile
- Maintain the current tutorial URLs, so we don't break existing links to the site
- Fix snippets
LGTM!
* [Citadel] Update tutorials (#204) Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com> Signed-off-by: anindex <an.thai.le97@gmail.com> Co-authored-by: anindex <an.thai.le97@gmail.com> Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org> * Remove tools/code_check and update codecov (#257) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Fix dart deprecation warning (#263) Copied from #262. Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com> Co-authored-by: anindex <an.thai.le97@gmail.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Will forward port this to Dome and main if approved.