Add support for 16KB page sizes (Android 15) #3620
Merged
+37
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markushi
requested review from
adinauer,
romtsn and
stefanosiano
as code owners
|
3 tasks
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fc147ba | 396.92 ms | 443.64 ms | 46.72 ms |
| e677f6f | 392.02 ms | 454.48 ms | 62.46 ms |
| d332ad2 | 376.36 ms | 429.84 ms | 53.48 ms |
| f453aca | 408.87 ms | 436.92 ms | 28.04 ms |
| c9fcd15 | 424.92 ms | 453.36 ms | 28.44 ms |
| a61b52a | 398.18 ms | 477.58 ms | 79.40 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fc147ba | 1.70 MiB | 2.35 MiB | 668.28 KiB |
| e677f6f | 1.70 MiB | 2.35 MiB | 668.27 KiB |
| d332ad2 | 1.70 MiB | 2.35 MiB | 668.24 KiB |
| f453aca | 1.70 MiB | 2.35 MiB | 668.28 KiB |
| c9fcd15 | 1.70 MiB | 2.35 MiB | 668.26 KiB |
| a61b52a | 1.70 MiB | 2.35 MiB | 668.28 KiB |
| ### Fixes | ||
|
|
||
| - Load lazy fields on init in the background ([#3803](https://github.com/getsentry/sentry-java/pull/3803)) | ||
| - Replace setOf with HashSet.add ([#3801](https://github.com/getsentry/sentry-java/pull/3801)) | ||
|
|
||
| ### Dependencies | ||
|
|
||
| - Bump Native SDK from v0.7.2 to v0.7.8 ([#3620](https://github.com/getsentry/sentry-java/pull/3620)) |
There was a problem hiding this comment.
native 0.7.4+ needed to be in v8
Or did anything change?
There was a problem hiding this comment.
As discussed, it's actually fine to bump sentry-native, as the NDK move does still allow us to directly include sentry-native in 7.x
stefanosiano
approved these changes
Oct 23, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Configures all relevant builds to use 16KB page size, inspired by getsentry/sentry-native#1028.
💡 Motivation and Context
This fixes the
7.xsentry-androidSDK side of getsentry/sentry-native#989.💚 How did you test it?
Manual testing using the Android 15 - 16KB page size enabled emulator.
📝 Open Tasks
sentry-native(right now it's the feat/support_16kb_page_size branch)🔮 Next steps